From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 128F338F92A for ; Thu, 26 Feb 2026 07:59:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.67 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772092767; cv=none; b=D7wtMnXC+ZgzLBkB2r46u0J0WGyj7YTt4gYNeYXXUWFS7RJ4ieC+yNYAd5lb+UDuqSxVMuDoUJsdBwHqATillCk77ExPXB2lVnMROtLfEuWcNDX+3oHZ0z6zci6XFSMQ7vxqNu6hpAawX3SlY//lfjyhAiD5nJm0sLVuGbmTL9I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772092767; c=relaxed/simple; bh=qLG7wMVtf/j22IKOyovAjOUI9k6Ney9TZklG84nK0qU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=uukAYVFKpxnCg/a7px2CVZ0lziMh0JwjVmhiKKrvThe0lvownNZGvsQz1Ey68l/lJEoF4MRtt756VdK71Tu2NRkuU5DtOtRHkHqTqzK9eYiypti/ZHwxoBbeS5tfOlOXjW78Ir6qds3MK+YVoYJnxBIfAvTiYK4noDmEWt+t8Cc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=tgbRkVyR; arc=none smtp.client-ip=209.85.128.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="tgbRkVyR" Received: by mail-wm1-f67.google.com with SMTP id 5b1f17b1804b1-483487335c2so4678195e9.2 for ; Wed, 25 Feb 2026 23:59:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1772092763; x=1772697563; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=NLdqyb8yIbOLy6zeHm6lvt/oajlIBvuw62gXqoMgj+0=; b=tgbRkVyRbndhwc1kX47CdzxrZrKVsNPpyfdxBvoMmy3wy3dx5L7Nfx7JiUO2XQYvF+ akDaUS5D6MgjuNv583GXvMEPVgZbuCnYVvcz+ShaIfybJi9USGTl6cROwH2CQGTEJ86V YSlFUisw1hpGH5r4X7t9r5ORdCKYQ+RkK2dLtErx4sTDCEyPKKbKLSlAhMpzvLoX2SNt bqXyBkubx1zjqdxvMPF4dG8IHvGf0CbHtKgd6FUgJyxryybLfYjm6SJSoRbBImIRuzKT 6F6p9VB5XJpGJdDi7EmcepxC+ORLAHtoao/32Gff77XtsZq5gsA54F0CVIlvRFsDbUBu m46Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772092763; x=1772697563; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NLdqyb8yIbOLy6zeHm6lvt/oajlIBvuw62gXqoMgj+0=; b=OMboIcsq8/OkditrtuJjbU3zaIJmkr28Im20mONCY37SSNYdYdx+wPsMCwvWYkSiQ+ rXZN0Mbt2D9GwCALZbzxsL+wDZgVIYa4gShOEinXzah43NSRSmotWfbUdSCKvGEZIkvJ tdDEgUwLBZ0CWTgduOGR2EeRlGm2W6MISytzX5YhxeNGIyPExPDA168JnVIVfP4QRdxE mnS+DYVeiJl1fplpLbxWri0EOhph+6Brh1BQmqPY53AX88R6or8OBghG2XeXhwiheGaK 1X50IPAbq/BLdMnF6NmWtVROlmPocLKUBPQhZug0hFvs2bD6PJWSVR2D26P7eVEUI/VN 5jYg== X-Forwarded-Encrypted: i=1; AJvYcCXnE25g2GuSV1Bi2XTwDAJg1QM6+X43bGmTR8i1ZzkeG/3bKKKbR/mhxc6C+JNh0wAGFgRntqzjQsD2Rkw=@vger.kernel.org X-Gm-Message-State: AOJu0YzjA/zefXKSPLB3STvL1jkx+P0EcD1CpOqCAiNPfg9e1oYnU/UQ Wx+arYxn39dUWVIIcCmTuZSFsZDmY42AF7G5crUh+GmFfLBD7eEGqBOmcbMkd1D/1Yg= X-Gm-Gg: ATEYQzzuMjdwTMGiD8QHafIQ/nswmii560WDFmLkvRG4v0OyhQiELI1cnZJqYeoxQfP lwalITsRCs/p3nkmWFyE30iXWBz4V1jujx39uUDpP1Dt6SRcSpubQKejRJiE9yroQUCE8X9aY0z l7waLdp9xbi2c6OTnZuXDe8CnjGoOW7/1eHE5QjGSXYE4KVHoIT1SzGDwxTB2PyYxgC4ylDFjQ3 XFRK3c3ud2q1bHQxUPMyz1Tpb8BVbIrGVgfaaLxnXXY8W1pPuPoyRL6t5yBiza86MFPjpdnDD6b SwoogfCVKuz6zoPJArcwKqkfBdUmQGvbUHsry7aGHk2zqgVXHKr+UmbCfLpq7S4jLj3Dc+G7+Hj OQnhSM1XqXEIzd11aEuhAP7eHw7oGWesOyOQEu61HGvBW6aUeGMgoxbsX2Ly2kjJx1kr1O7JD0/ aRSL9uXLBijSAP+jomlaUAn3meG3qs X-Received: by 2002:a05:600c:3b17:b0:46e:32dd:1b1a with SMTP id 5b1f17b1804b1-483a95b15b6mr324802165e9.7.1772092763082; Wed, 25 Feb 2026 23:59:23 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483c3b89c99sm26081755e9.15.2026.02.25.23.59.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Feb 2026 23:59:22 -0800 (PST) Date: Thu, 26 Feb 2026 10:59:19 +0300 From: Dan Carpenter To: Shubham Chakraborty Cc: David Lin , Johan Hovold , Alex Elder , Greg Kroah-Hartman , greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] staging: greybus: uart: fix style issues Message-ID: References: <20260225183836.20434-1-chakrabortyshubham66@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260225183836.20434-1-chakrabortyshubham66@gmail.com> On Thu, Feb 26, 2026 at 12:08:35AM +0530, Shubham Chakraborty wrote: > Fix checkpatch.pl warnings by adding comments to mutex and spinlocks, > and fixing alignment to match open parenthesis. > > Signed-off-by: Shubham Chakraborty > --- > drivers/staging/greybus/uart.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/greybus/uart.c b/drivers/staging/greybus/uart.c > index 7d060b4cd33d..1d2c4ef70865 100644 > --- a/drivers/staging/greybus/uart.c > +++ b/drivers/staging/greybus/uart.c > @@ -50,12 +50,12 @@ struct gb_tty { > unsigned int minor; > unsigned char clocal; > bool disconnected; > - spinlock_t read_lock; > - spinlock_t write_lock; > + spinlock_t read_lock; /* protects read operations */ This is really vague, but I wouldn't say it was accurate. > + spinlock_t write_lock; /* protects write operations */ Also really vague. What does "operations" mean in this context? But word "write" is correct at least. > struct async_icount iocount; > struct async_icount oldcount; > wait_queue_head_t wioctl; > - struct mutex mutex; > + struct mutex mutex; /* serializes port operations */ This comment is doesn't really add any value. regards, dan carpenter