From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 103D43806BA for ; Thu, 26 Feb 2026 08:00:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772092814; cv=none; b=GPkYfCQ/cBMULIgLkYGh/6c92WWM5lwkhBEdrnWdftauzOezL5vVWmJkcvOizJQpjw30Te4uGeT/x4P2ju9QkJGwYfg8lRzEnWlERHDD5wacttaQbueJQbHUYCZCS6FU0oWrK2I9pgHO31EICDal6lTNXxQMR+F8nPaTnFdCHh8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772092814; c=relaxed/simple; bh=Cs2HOWVMSl0LT0MUkOnTph/1WtHB6lPLfpy1IpPXD0Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=b2udiQW7bpaoG4Q+eZOrHhv+cS+HCew5TwtlKWyDwABzAdcqHA3n8aDjmsn7zz3aob3CmM48cM2MFFWGEN0bvWFnkNWbCwSL/DqtO4sKIJEabn743PS4LAPM73cqLaVhJS31sPaL8RsbLQir5eKfYTfQ7hSV5+XEmuEoA2Hzs1U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=EgqNYs9L; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="EgqNYs9L" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-43991064db8so554460f8f.2 for ; Thu, 26 Feb 2026 00:00:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1772092811; x=1772697611; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=DhhLSJx/NkkogoubBZaHI7OfYKzmGyTd4xSdN54lguo=; b=EgqNYs9LbYPGhz3iTkxHjq4LxfbgvWPBYmNXYUN5c88TRRZ5pw9OzJqLg4MxnaS15g jsSs7enN8L/CRDzI1YOW2SKbeW3Xh+QIslrYGn/MFkFVAA4sjCplab/DSQzxUQUIBCnT UKcA09TXu4ry6O49Vt4vfAu23nL2qJHwjjmIu5X9h+14G7ah4OJm2I7/cIRLFCj46BgL yzr/mMckrBv8H3+EYo6VKbRP0tsmlzZLeEYLk7lSudnuqpXHND7zpupT61YCMQg/e2jx 3ROf4o8yekWwwxjG7IfRFI8koCoGuybQL69JVLJCv7aAKD+JZcqgrDT37NgQ/ms+A+7T MuJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772092811; x=1772697611; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DhhLSJx/NkkogoubBZaHI7OfYKzmGyTd4xSdN54lguo=; b=fjEaK/X//qKuLeQgOF+U0lZM8lZkNThY1BL6ZfvjYzTHXNtYY8EtQBPq4RVUt17AQ7 2VVMEN3DwV+d8aVxDVKhI2O94YiIdU+iN/fJYSbcTnBy3FuwiiMtxE2DbZBwy6wNjPWX cqmmvlVAuPLCYy3L2zCei6QGsn2HazQBRaSABbIIDsGdh1KGjvDrtdX8uvlSj5UKY1HY SMG3o3dcx+0kmDBXyQLlj0jis1QiMCEW2WXHnnG2DvSVVv9znMph16Cp3OMVJZnBQ1qS CPVbYqZM/YsReB6/zX1v3RhFk4tbTRB2dvjKg1gLk0iQgA7ufF8Di6t9oUVztXtcAaXd szdw== X-Forwarded-Encrypted: i=1; AJvYcCWwGorKbRdqADSoycIgpJ+KBij/Bru34QGJTdJ3xCTthcRXo78fNUAQm4RJOWTp2dGfzjMG7ZDOV6SI+V4=@vger.kernel.org X-Gm-Message-State: AOJu0Yzy5hLuR7iHLPjwn4Kt4lRzcTn4pkB0DRs7MGOYUDhG4PfSZnZA HnX+QyE5EQ3h4c1aD2i+xj+j8Kgwy7Qew6i8WmfVL+f5HQuF1yL5SBA36wab4vjbr0E= X-Gm-Gg: ATEYQzx4nEkn3P7LK4eeIe8K2JXUEfk1yEczEhBT+zeEDqiRYp6MhIqWS7xHLF/Jjqs MpFwmFmXJPlWOXiHb8t+Unmqw4H/qRJgl/+r952VUOw2zP3X8bpZQ3JtVoy+e3W3o7Y1DGF3hn6 Ms1+TN4vS37uVVbBC3FmTKkwDfUFWiUGe+fsFHauCRq9EEYWbojl3IvK1hBI4TOBVGq2kmvDiyK yqn52ImRMb5q1MR0o75XmkIIQHBr3oQSaYfe6AlJ8OF5oHCWQsrk0+tVL5KeoN6o00Xmi+y+ilf pliRLO2dudB90Tcu4YoYbDKEGRFhG9NHdh14dW32Q7l5HhRpp+eJF3YiJ0Qw7lvN/+e3D7iCnZL liYD6d1Z4Y9+BPhHow+ssSMy1Pj8ysVK4hj6bVhA0rmDQJ9BWLp9FlDiCtylkpit/VwiRaoBKHX SSyoakWOu7vcykeH8i3s+BKgWF8v8Y X-Received: by 2002:a05:6000:310b:b0:437:66bf:a9d4 with SMTP id ffacd0b85a97d-4396f17cc72mr32819273f8f.37.1772092811208; Thu, 26 Feb 2026 00:00:11 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43992ced321sm7296891f8f.35.2026.02.26.00.00.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Feb 2026 00:00:10 -0800 (PST) Date: Thu, 26 Feb 2026 11:00:07 +0300 From: Dan Carpenter To: Ruslan Valiyev Cc: Vaibhav Hiremath , Johan Hovold , Alex Elder , Greg Kroah-Hartman , greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: greybus: arche: use sysfs_emit() instead of sprintf() Message-ID: References: <20260225212955.57102-1-linuxoid@gmail.com> <20260226074858.67635-1-linuxoid@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260226074858.67635-1-linuxoid@gmail.com> On Thu, Feb 26, 2026 at 07:48:58AM +0000, Ruslan Valiyev wrote: > Replace sprintf() with sysfs_emit() in state_show() sysfs attribute > callbacks in arche-platform.c and arche-apb-ctrl.c. > > Checkpatch complains about code using sprintf(). This code here is > obviously safe as-is, but it would be more appropriate to use > sysfs_emit(). > > Signed-off-by: Ruslan Valiyev > --- Thanks! Reviewed-by: Dan Carpenter regards, dan carpenter