From: Geraldo Nascimento <geraldogabriel@gmail.com>
To: Dragan Simic <dsimic@manjaro.org>
Cc: "Bjorn Helgaas" <helgaas@kernel.org>,
"Shawn Lin" <shawn.lin@rock-chips.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Heiko Stuebner" <heiko@sntech.de>,
linux-rockchip@lists.infradead.org, linux-pci@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] PCI: rockchip-host: comment danger of 5.0 GT/s speed
Date: Thu, 26 Feb 2026 02:06:24 -0300 [thread overview]
Message-ID: <aZ_U0ASjuK2fZi5h@geday> (raw)
In-Reply-To: <e0aa10e5-ec0a-4d0d-6f71-6797286221cc@manjaro.org>
Hi Dragan, thank you for the review!
On Thu, Feb 26, 2026 at 05:52:58AM +0100, Dragan Simic wrote:
> I agree about removing the effectively unused code block that handles
> the "link_gen == 2" case from pcie-rockchip-host.c, but then please
> remove the PCIE_CLIENT_GEN_SEL_2 define from pcie-rockchip.h and its
> single "link_gen == 2" use from pcie-rockchip.c as well.
Good.
There's also some code that needs to be dropped from the endpoint
driver.
>
> As part of that additional removal, an early check for "link_gen == 1"
> should be added to function rockchip_pcie_init_port() in pcie-rockchip.c,
> because that will become the only "link_gen" value it supports.
What do you think, should the driver bail out completely if
link_gen != 1 or just let it force 2.5 GT/s speed with a warning?
I tend to go with the latter.
Thanks,
Geraldo Nascimento
next prev parent reply other threads:[~2026-02-26 5:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-25 22:26 [PATCH v3 0/2] PCI: rockchip: 5.0 GT/s speed may be dangerous Geraldo Nascimento
2026-02-25 22:27 ` [PATCH v3 1/2] PCI: rockchip: limit RK3399 to 2.5 GT/s to avoid data loss Geraldo Nascimento
2026-02-25 22:27 ` [PATCH v3 2/2] PCI: rockchip-host: comment danger of 5.0 GT/s speed Geraldo Nascimento
2026-02-26 0:12 ` Bjorn Helgaas
2026-02-26 0:18 ` Geraldo Nascimento
2026-02-26 4:52 ` Dragan Simic
2026-02-26 5:06 ` Geraldo Nascimento [this message]
2026-02-26 6:52 ` Dragan Simic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZ_U0ASjuK2fZi5h@geday \
--to=geraldogabriel@gmail.com \
--cc=bhelgaas@google.com \
--cc=dsimic@manjaro.org \
--cc=heiko@sntech.de \
--cc=helgaas@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=robh@kernel.org \
--cc=shawn.lin@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox