From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D42C8215F7D for ; Thu, 19 Feb 2026 14:40:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771512054; cv=none; b=tcgG+uFv+SconO0CMWCrXSqGTws5OK5+xWfy4k/m2z3jpiUukOYSmhnCmBkBt1CIj8V8DUener7ericFHtiEub8pA3nSXZdQfXMyN5TdiIAxY4Nak4b3D5DhVNkThc7g4jvlj+pfesFW6vpw0KSVly2FyW5K8ZR2+EtaFjHEpA4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771512054; c=relaxed/simple; bh=AB0fltUCIl+uCvWaVEjTQqfnw1TOfpgRT0gBJMvnhAs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Re7ERsUgCF7RczsZfWf3IYLCWqw863vIlR0eOP6vos9OvS5hdMWaAls+yLJ3yT76TxrA+t5oCE7L0pJRdzb6ovoPmwQgacY/+4svM41VM4Nb0pUiML1AkQrxjFZCs8cpkzKX+/4xS5BsCD6KTR2k+XVgKVwOLRSr3yJObPI6jDU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=chrisdown.name; spf=pass smtp.mailfrom=chrisdown.name; dkim=pass (1024-bit key) header.d=chrisdown.name header.i=@chrisdown.name header.b=KedJYlcs; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=chrisdown.name Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chrisdown.name Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chrisdown.name header.i=@chrisdown.name header.b="KedJYlcs" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-826c49b7628so122355b3a.0 for ; Thu, 19 Feb 2026 06:40:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; t=1771512053; x=1772116853; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=dSZloSHy3iMOIon4wfGXcKPwDGVRD9yg/n5oTL5CWDM=; b=KedJYlcsx6egcREdFDUwlCVbS8tthZpEXbCQL5vnG6tmKxmM4QNTtt8r786L2uNsbB qtwpw412Goe3EmMrrfFTpal97Erd2epj6a4h0bkr6GP9czm3P5Ga18UMxr95mNNDh9pv bWcIzig8jnb+Gr8WM3aM/MDjsXbA8NyNY8LHA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771512053; x=1772116853; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=dSZloSHy3iMOIon4wfGXcKPwDGVRD9yg/n5oTL5CWDM=; b=wpGdZwGCCIfLgyaOPtBeRcsi0D0gs4sEEkxQceOlRbO3sXgN6eOXkV7yD1qoc6RChp l/i+R5OE8KmvBtLkK+xwgwGxFS/WnVDrB4662aUAg1VTNThX80R0FQeBZK0uTvtdO3j6 l8yGg1cd1QnsoKE9KVn0rXbHU+ZtKz49Qmp+J/h5C+3Zj1uJt6VyhBPRFgFaXkwWQUF2 0UYS+E1vnV5GrprUttj+q9nPJ5Or6iVE5HyvHnRrxwVVsn+92R7KtYknJkvrReiKRUnw 7rOB4DJvJ1sQFFD/eQyezuNWzPIGJyoM8nRfSwmxlO4ASPsyFDQfWSz1qoaqDyfDRI6/ M9ng== X-Forwarded-Encrypted: i=1; AJvYcCWiTFrOyjqoDrt28iXgaR98nQjZ9slFLeVXvI6qHfwd+juLSwZeOfAeMBfLaOZpkZbsKGx+Md2zW6B87dM=@vger.kernel.org X-Gm-Message-State: AOJu0YwgKPqvX9IzBcJwURCMIoEYlgReKXA8BUmTQiwdxyYZpuTxsNju Y/wrZQdcNNtez70pQIBZHwTZEgp0aUatDz2zrWInf4+/72vX7c+cwn8ZgOmebdeN8dM= X-Gm-Gg: AZuq6aJx3Vgm3m4N+zo40hwZUinHq6dWk15sPm1tWYKWzKKbixMOfrJEH+yeWj14vES ggGfWEEakjlVMVzDb3XfMJNXfVQ2PdLZe8QAUivy1eGayLo4bG7a2aUBAxV3DdRMtBRJ8cmQTU0 bvotr+If71ijWC8goiVaXaMot/xRMtuVVa73T9ejaEUKl4kbZw+PgDTTrmb4nQMncp9wl9U3WTP EFDB/fWs+te9uP8oaqN3Jis51HNJqESVOSHQeLLl4FPyDkBPusQTP4K7tDR5CrDOBWP7FLv7y9+ iQSl6p+aVHMPZ9A8TNGXqB59FDt7MqajaXQQ8GeZd3UGRPuH29hkgbc2rKPN6gpgKso2U1pVfPV SNooPA5MmFR61VUYT31HdUnfQZR9DeX/WSmIqhBciSvoE2ziYy7x71Ev7QHRfqRqS53uJh8SoeO CmiGwZAzTQ5v4w+eXJY1Jq X-Received: by 2002:a05:6a20:12c5:b0:38d:ee4a:e80e with SMTP id adf61e73a8af0-39483a4a60emr18359358637.76.1771512053130; Thu, 19 Feb 2026 06:40:53 -0800 (PST) Received: from localhost ([175.139.248.66]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c6e52fe2300sm16430016a12.8.2026.02.19.06.40.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Feb 2026 06:40:52 -0800 (PST) Date: Thu, 19 Feb 2026 22:40:50 +0800 From: Chris Down To: Petr Mladek Cc: John Ogness , Sergey Senozhatsky , Steven Rostedt , Marcos Paulo de Souza , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/8] printk: Rename struct console_cmdline to preferred_console Message-ID: References: <20260206165002.496724-1-pmladek@suse.com> <20260206165002.496724-2-pmladek@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20260206165002.496724-2-pmladek@suse.com> User-Agent: Mutt/2.2.15 (2b349c5e) (2025-10-02) The rename itself looks correct and is a clear improvement. Only one small thing: Petr Mladek writes: >-static void set_user_specified(struct console_cmdline *c, bool user_specified) >+static void set_user_specified(struct preferred_console *pc, bool user_specified) > { > if (!user_specified) > return; >@@ -2500,7 +2500,7 @@ static void set_user_specified(struct console_cmdline *c, bool user_specified) > * @c console was defined by the user on the command line. > * Do not clear when added twice also by SPCR or the device tree. > */ The comment is stale, it should be @pc. With that fix: Acked-by: Chris Down