public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Chris Down <chris@chrisdown.name>
To: Petr Mladek <pmladek@suse.com>
Cc: John Ogness <john.ogness@linutronix.de>,
	Sergey Senozhatsky <senozhatsky@chromium.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Marcos Paulo de Souza <mpdesouza@suse.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/8] printk: Do not set Braille console as preferred_console
Date: Thu, 19 Feb 2026 23:03:01 +0800	[thread overview]
Message-ID: <aZcmJaG1cKPWTIOU@chrisdown.name> (raw)
In-Reply-To: <20260206165002.496724-7-pmladek@suse.com>

Petr Mladek writes:
>The Braille console reuses the framework for handling consoles preferred
>via the command line. However, it is a special-purpose interface that
>neither receives standard printk messages nor associates with
>/dev/console.
>
>Currently, the "preferred_dev_console" variable can point to a Braille
>console entry in the "preferred_consoles[]" array. This occurs if an
>entry was first created for a non-Braille console, but a later 'console='
>parameter redefined it as a Braille console.
>
>Since a Braille console will only ever be enabled as such, it should not
>be tracked as the primary system console. Adjust the logic to ensure
>"preferred_dev_console" continues to point to the previously designated
>normal console instead.
>
>Signed-off-by: Petr Mladek <pmladek@suse.com>

Looks good to me, after fixing John's comment about resetting 
preferred_dev_console_prev, please feel free to add:

Acked-by: Chris Down <chris@chrisdown.name>

  parent reply	other threads:[~2026-02-19 15:03 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-06 16:49 [PATCH 0/8] printk: Clean up preferred console handling Petr Mladek
2026-02-06 16:49 ` [PATCH 1/8] printk: Rename struct console_cmdline to preferred_console Petr Mladek
2026-02-19 14:40   ` Chris Down
2026-02-19 18:34   ` Marcos Paulo de Souza
2026-02-06 16:49 ` [PATCH 2/8] printk: Rename preferred_console to preferred_dev_console Petr Mladek
2026-02-19 14:41   ` Chris Down
2026-02-19 18:37   ` Marcos Paulo de Souza
2026-02-06 16:49 ` [PATCH 3/8] printk: Separate code for adding/updating preferred console metadata Petr Mladek
2026-02-16 14:05   ` John Ogness
2026-02-19 12:46     ` Petr Mladek
2026-02-19 14:06       ` John Ogness
2026-02-19 14:48   ` Chris Down
2026-02-19 16:51     ` Petr Mladek
2026-02-06 16:49 ` [PATCH 4/8] printk: Cleanup _braille_(un)register_console() wrappers Petr Mladek
2026-02-19 14:49   ` Chris Down
2026-02-19 18:50   ` Marcos Paulo de Souza
2026-02-06 16:49 ` [PATCH 5/8] printk: Try to register each console as Braille first Petr Mladek
2026-02-19 14:59   ` Chris Down
2026-02-19 16:59     ` Petr Mladek
2026-02-20  4:52       ` Chris Down
2026-02-20 11:43         ` Petr Mladek
2026-02-06 16:50 ` [PATCH 6/8] printk: Do not set Braille console as preferred_console Petr Mladek
2026-02-16 16:07   ` John Ogness
2026-02-19 14:55     ` Petr Mladek
2026-02-19 15:35       ` John Ogness
2026-02-19 15:03   ` Chris Down [this message]
2026-02-06 16:50 ` [PATCH 7/8] printk: Handle pre-enabled consoles directly in register_console() Petr Mladek
2026-02-19 15:03   ` Chris Down
2026-02-06 16:50 ` [PATCH 8/8] printk: Try enable preferred consoles only when there are any Petr Mladek
2026-02-19 15:16   ` Chris Down
2026-02-17  8:56 ` [PATCH 0/8] printk: Clean up preferred console handling John Ogness
2026-02-19 15:20 ` Chris Down

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aZcmJaG1cKPWTIOU@chrisdown.name \
    --to=chris@chrisdown.name \
    --cc=john.ogness@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpdesouza@suse.com \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    --cc=senozhatsky@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox