From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F94933FE06 for ; Thu, 19 Feb 2026 15:03:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771513385; cv=none; b=oU9G5Cc2h144JCV3eHXL3BUJPjE9pEZj5n5D4yCldAmg4QWHVU2sp26pL2xexGJsV7dV2YUUoB4/FTmU+CopA3BNuyfIZXGRm/bnblJwW8RHUNjgXR5nlyJG+AMhgB3+yksFetJxbkjp2lfNmGOFkD+As/JXnPxk4Pj5pnH3Fv0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771513385; c=relaxed/simple; bh=qsrOLx+Sq4MaJKixsqdFqTP2jiDyE4xKDgaU3cGsXdM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Bq6xeKN1r1ROK4XzvuWq5DCi58C+YBqZiBqAsby+QsLzwahw48mMV0PXcAiMG9faCrU7HHj7J2ji+klVwUtiAbNko4patjNuCt2LCrKpyYq871R+kjrh+8pHotClHUUn/ofK+yMELX11GA6hCXfg0G+u7mCY9l86LicmS0KaTuM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=chrisdown.name; spf=pass smtp.mailfrom=chrisdown.name; dkim=pass (1024-bit key) header.d=chrisdown.name header.i=@chrisdown.name header.b=CzFNMKtp; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=chrisdown.name Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chrisdown.name Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chrisdown.name header.i=@chrisdown.name header.b="CzFNMKtp" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2a871daa98fso6481125ad.1 for ; Thu, 19 Feb 2026 07:03:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; t=1771513384; x=1772118184; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=7k5IVa5QDMQHP1n1uoKmTDoAM3ox9qJffQBl+WaEB94=; b=CzFNMKtpaEcWT+4o92373vmCh5wVMvY3HmkxqCgGFo+tnw3fSUbcklAkOis0Trv3qK EOBiSjeeNkLwtJD+a/WAMmy4ZkkgvYWgDaw0czpSOR8NM/dk0YhFeaoQQ8VsnpeqLH6A E4ucnfYUi5VwGcSVfNUZOpYiUynAaRy1qCV9c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771513384; x=1772118184; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=7k5IVa5QDMQHP1n1uoKmTDoAM3ox9qJffQBl+WaEB94=; b=GRC3IXZdz5XqE4tB+2SFWEiSPYF/ZJ+cEHUTYZmLfgjYiS6bqQuGidlrbHaEs5DCNP gK5pFnSDDkcnUQJmKN7P4aCos7rLbIamr6ytT0vFC2urDZRDsAtwWFGIdjsHlaxH6B9G lr6HfRwO13lKg+1w+IldEOGY5dUH26tZG2kymb3n1/k72n+SMPacSFqOP2XLgwD1OPhn CqSdZAdlvYOA6/G4pwJOHNR6z6dRIcbw5M9/FIZf28ueXEXepSphohBZfTHZHiC6p/a1 1t1ZLh4Sy+CPByA6P04I4LXGsh0omRREirsh54KNZo3kWp9gdf+Dmd4JjkKkUAPl6MnH Gfaw== X-Forwarded-Encrypted: i=1; AJvYcCWZjFmnYoWBTlYfgkmNwepwfhH5QEe/rcJU15eQfCGEiyYk6/zA4o06BCQhhHFkKPOHh8NIlQfv4JyrFSU=@vger.kernel.org X-Gm-Message-State: AOJu0YxDAboLekEt48lrV4SIH3h3skcU72GNZoaUIjXX74ssoeQdcO43 HOLkvzYRQlPUk4hGcQMgFttEjHwCtv9/H11OGS/4H5T2l/unc2sF03rTHU5zJGL5fTI= X-Gm-Gg: AZuq6aJQ5OfahrM/B/1kLyWGqV/mxZtqfKjtt5zbKwv1T3L8I5VN+AECwsioFMTNGuh k1QqNvID2i3XifwYDzy0kHargXebyP+lE4iCvn1ngaVBEPuWUCX7490ZOSS7+KVgaqaEm46Ttr5 U9MS2YmxJjVMjTu0w9XZi3hjkNecGUeL3/K0YDPSPeyhhF8cwzmNg3B9zfhkmIOZVmRU5kwxn5c mZxFElyhvhHV1gI9WDVzersZ7DMKyGMFB2em0e1oVi4GjToj5PtH5f5L0ZUG7WhLVjW3LYYRAhq 8pGM/gkI3fz4yWvdDtq/9RW6A8l7Ek/+DIeGonhCvxvUI9PJwrgKC5x4Yw5+pcizzOYmM0L41DT ObgAXWPTFg8MA73K+HdcdpwsIYvw6M1pivXBNtZHNG2+7IkRJE79EVdAwy4n+LsB7/TNCKnCfn+ zZe0IFdkHmFDGbXy4HM5OK6ofDqPnBDRs= X-Received: by 2002:a17:903:37c8:b0:2a8:ac0f:9aec with SMTP id d9443c01a7336-2ad17553253mr185090645ad.49.1771513383511; Thu, 19 Feb 2026 07:03:03 -0800 (PST) Received: from localhost ([175.139.248.66]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ad1a713e8bsm238543655ad.28.2026.02.19.07.03.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Feb 2026 07:03:02 -0800 (PST) Date: Thu, 19 Feb 2026 23:03:01 +0800 From: Chris Down To: Petr Mladek Cc: John Ogness , Sergey Senozhatsky , Steven Rostedt , Marcos Paulo de Souza , linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/8] printk: Do not set Braille console as preferred_console Message-ID: References: <20260206165002.496724-1-pmladek@suse.com> <20260206165002.496724-7-pmladek@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20260206165002.496724-7-pmladek@suse.com> User-Agent: Mutt/2.2.15 (2b349c5e) (2025-10-02) Petr Mladek writes: >The Braille console reuses the framework for handling consoles preferred >via the command line. However, it is a special-purpose interface that >neither receives standard printk messages nor associates with >/dev/console. > >Currently, the "preferred_dev_console" variable can point to a Braille >console entry in the "preferred_consoles[]" array. This occurs if an >entry was first created for a non-Braille console, but a later 'console=' >parameter redefined it as a Braille console. > >Since a Braille console will only ever be enabled as such, it should not >be tracked as the primary system console. Adjust the logic to ensure >"preferred_dev_console" continues to point to the previously designated >normal console instead. > >Signed-off-by: Petr Mladek Looks good to me, after fixing John's comment about resetting preferred_dev_console_prev, please feel free to add: Acked-by: Chris Down