From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B010345CD8 for ; Thu, 19 Feb 2026 15:03:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771513437; cv=none; b=q7anz0K1NfTxg4DaS7pEAbfnL8rgR0/1c027ug9HYZTV3FZoEJiJ8XpEwfP2xRbKdrceElglL7+pwPJKuPDR924onkQDzLXNeKoM2j2Vo6u/D4dKZh9/+j5y19n41aMPGLMhgyKBkq1MLlLl4M8x+TyUefHsnPbxf5f1VW3rCOw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771513437; c=relaxed/simple; bh=pe4zWuk4QI8d5GKCA8WVeSwNBnwTVpHLBgU+aOAi2mk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Ub+G99QfU8Qc8eaBKNuQNtE/NPEP23uil+EuvjeevabvMdG3pCKrvwrpWIVOxQb2zx3zXFcFxnFyfCSfX87+dILY6KpFP7QTD53vPWoNFkT4FYeumG1ST3tLL7LzLfIEIt0fAk04j3IQF7U55yP5B/v4dRaX775tmYpS9873ltM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=chrisdown.name; spf=pass smtp.mailfrom=chrisdown.name; dkim=pass (1024-bit key) header.d=chrisdown.name header.i=@chrisdown.name header.b=PFlMH0py; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=chrisdown.name Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chrisdown.name Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chrisdown.name header.i=@chrisdown.name header.b="PFlMH0py" Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-824adc96ad2so991313b3a.3 for ; Thu, 19 Feb 2026 07:03:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; t=1771513435; x=1772118235; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=pe4zWuk4QI8d5GKCA8WVeSwNBnwTVpHLBgU+aOAi2mk=; b=PFlMH0pyTx+YuexacB6PdlKTdjK/UspzR3n+huL9QXpSjJfJ98pGkp5H5COkeD+OOq o84Swuy/DuqqCC34cDab7UX0hHBxhq2JV0UgAPhvtGrmDYavXOoVe+uFm7hhaQTqNHiB RoKBWYy/xadMOPLQAuESkXfTDcfN0aboN2Vn0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771513435; x=1772118235; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=pe4zWuk4QI8d5GKCA8WVeSwNBnwTVpHLBgU+aOAi2mk=; b=cyWWDH+t6JLjDhattRx27CX7/B+tytmqbdJj6Or3YiUBQUg8GCPNQ3rUcXqLDzYaRU YsFAGZ6g7GsnBMmgiycz7Y+GNzk0MlFDDDaigV18JbpAVCISH1aqcghtk+wXTDX6BHC4 GF8Vt8MrdumZuCoDBBBRScH0SVnJD6IYSyHLZmHhcwJNRebnVQLRkDuo32KYrDV+gHUo kZud6Wi365lSe+gQPMAkMDKHYQ6NkXlGiJOi2Vix2yVNys34EVjsk+d8Y5/kljCdOxil gw77cej9AP7+KYjxb3PGzMGor3sQd2SyB/+GSbt91w4vyeVXsdXPsNrvllvNSGI6mCWL p7JA== X-Forwarded-Encrypted: i=1; AJvYcCXft33StVJt7WJ6BVdfskIe96PaxQ6QOr8cJuXMiklnxFwa/C1WZ26/bp6bCTdTvd8rLLGuDXpIq3mXgu0=@vger.kernel.org X-Gm-Message-State: AOJu0YzlUWUiunPsb3oFdkqbf4mT7TPFw3bbef4CFBgkfDlSR6TBs1UT NOCKa8DHREuyRT2uRtfEbXDh9JscFjAw4kIZX7Dfpk/b2Uk4VBG3y0W9ozlBDmEhBs4= X-Gm-Gg: AZuq6aL6RE5FtDJbFhyHLiJJEavzS2FohsVRWgVxHoNtMd1FiRERocGOAaVl0ZguyBi OkecbO+2hmAkIg9J/dJg3ykbwydBUKulbavP64AnxclkbcaCfbapJxObuid3uUDqh0GrtI2y7Hz skt1HBUoOP8LoXf1OhnVwmmZlSlxLzwDQ8EnW+WKKDLOOmw1cvojQl0w14iK3DOF301azshkRpN 6PxV4KYqwdW0b/o6nNBiOwXHxAb0+X0SAKApWcRKL5M5wiNaT/8NpgHlBKCpkcCjMOakSU/8T2d lUa7Nsy2FDAtckYtcejQNHn2PO3zuPyW9kUIGF3DUM+5BHHDrBPDDuGNp9c5HDjQBFvs3D2DxFV zzUgTqP/ve52388BIKpRESEL6evU3WLW4raPGao/dUqWKtJCySX+9+IwfHEhBtBvwQhDw7KU5Gm isaMhIkOihyH0BYVivLmNX X-Received: by 2002:a05:6a00:440b:b0:81b:14e1:a17b with SMTP id d2e1a72fcca58-824c617d126mr18415355b3a.70.1771513435489; Thu, 19 Feb 2026 07:03:55 -0800 (PST) Received: from localhost ([175.139.248.66]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-824c6a626bfsm19289380b3a.28.2026.02.19.07.03.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Feb 2026 07:03:54 -0800 (PST) Date: Thu, 19 Feb 2026 23:03:53 +0800 From: Chris Down To: Petr Mladek Cc: John Ogness , Sergey Senozhatsky , Steven Rostedt , Marcos Paulo de Souza , linux-kernel@vger.kernel.org Subject: Re: [PATCH 7/8] printk: Handle pre-enabled consoles directly in register_console() Message-ID: References: <20260206165002.496724-1-pmladek@suse.com> <20260206165002.496724-8-pmladek@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20260206165002.496724-8-pmladek@suse.com> User-Agent: Mutt/2.2.15 (2b349c5e) (2025-10-02) Petr Mladek writes: >The function try_enable_preferred_console() currently has the >non-obvious side effect of returning success for consoles that are >already pre-enabled. This obscures the logic flow during console >registration. > >Move the check for pre-enabled consoles directly into >register_console(). This change makes the handling of pre-enabled >consoles explicit and easier to follow. > >Furthermore, this separation lays the groundwork for future cleanups >where try_enable_preferred_console() can be restricted to cases where >an entry actually exists in the preferred_consoles[] array. > >Possible behavior change: > >try_enable_preferred_console() will newly be called also with >@user_specified parameter set to "false" when it failed with the "true" >variant. But it looks like the right way to do. It will allow to call >newcon->setup() when the console was preferred by some platform >specific code. > >Signed-off-by: Petr Mladek Looks cracking, thanks. Acked-by: Chris Down