From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08317284898 for ; Thu, 19 Feb 2026 17:21:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771521689; cv=none; b=t+kpoTsQPqo2RsQf2hA7rnBVOxtzTuWq2QEI6KCtLlkSE60qiS7D5tUmxZ/cv5Az2JobD+3e3x5owJV9F9A07wfuhu3S8B9vYF+ZYCGr4W0siNBikHZh2WfqfbyQ6n2q/enXiXIFNeXGJw7lKmek6xwQ9iHLprZdB5A2AtO+RaI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771521689; c=relaxed/simple; bh=CctkxF5c2z/goU09kMRIOU62BOJ7tyoO11bfcPniLO8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=M51Nfb1O5dDm9waUr3utgAkqAgda1wNM2wTBPOVbSH+eUK/atkWL0IK0uw3dHjGG/GKiGov0HdKjfnwTSxFiR88vlMhNclY9hte5/zXlvVr1hhB82xxTX7q65l/KBrC0B5PS7n/JkHx1hLWIC6GaxH2BX0g17yWctOp9wI8vn8g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=YtA4Rrlt; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=lvBm1Hwk; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="YtA4Rrlt"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="lvBm1Hwk" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1771521686; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=a+MlxWO2a/5NxxDnoLl6rDcBacWRef25tqpr85yXgBM=; b=YtA4RrltXnmf68orgPvU1G0Gz7AOYA35B7viHf7foyxBcGUa3yr+5MuD+QpTO0+0RH0VH4 lx38VT/0B5UUX+0xKoYMhqnK1+87ne7j0TL0I+PGnTt+wJo0uc0bNc1wz3+Vs59FoKTQdx WMTqJMGZ3xzepbEyqEoDk3rR+n2hzPI= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-628-f6YjERaUNT2sI8GF9vxR3w-1; Thu, 19 Feb 2026 12:21:25 -0500 X-MC-Unique: f6YjERaUNT2sI8GF9vxR3w-1 X-Mimecast-MFC-AGG-ID: f6YjERaUNT2sI8GF9vxR3w_1771521685 Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8cb3b6b37d8so795568385a.3 for ; Thu, 19 Feb 2026 09:21:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1771521685; x=1772126485; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=a+MlxWO2a/5NxxDnoLl6rDcBacWRef25tqpr85yXgBM=; b=lvBm1HwkaeZN8eU8m3mxObIeOpfHwbtalZ8c4svUJjzoVBd2i7iNViSTPFs0wp5ik5 6ymbgtNosQBGouh3fgitW5MM7Ubo3nNRP2E46pJwFVJLySIPz1OLsU40cQv5YRNqgt8i 9i2MZqF/uyyTl5EbUwYrg8U3Tfxab4jzPtbyo/Lov2a/ATeZIzEMQXGmxIxbXRC3bryc Yt1Wc8WvVy2NRtj1zX5wzfUR4OyN2nG5OQ7nUCkSbEyNwtwYl2VzDmlLSBgZjNkfmbmI w+TOGhnWF2NiqphZaxsYKhodCzSRHLvkaRk+CBIugHPtzIvDIM9KaMBUPHG1MxquPpAt hZDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771521685; x=1772126485; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=a+MlxWO2a/5NxxDnoLl6rDcBacWRef25tqpr85yXgBM=; b=V1AUBU2Asw4wcnZC7jrLnYhEYr0yITbSdIglcyOu7qrfq5A56WeowYToTq9Fih4y33 TXYAnLbwREFMJEsTyq/IfiSEqaHLmLkgP6A7x4wZmTudjB2ROUKYT7qGwp5/yUSltegE CoQNmpY+h+Xm+aAzsRhcn4/r2fjeTC5CLOMuPfB+5eCRd7XUpB4PRURsAmjwi/WAW3XZ qM1gcmGNqBUczgQcIHo6didZCdGZGCAcpqFkBrH+iyfdsAFDWsDcGzWB5eJ2v/+J6y9w 5L4bMfzxs7wEqsL7dNQhd/axMZnAxW/E2iPSK42ahoKzlf98aVuFUg2Gd6gDInIKWB6e cWAQ== X-Forwarded-Encrypted: i=1; AJvYcCW8lnGhEOsPWBYJpz+cVDwh1h0ZewHmsm28ffg2eHtTsC4VX+VGMXdHLAgEHCpg3/O4yEbYn2DPTmQVYYA=@vger.kernel.org X-Gm-Message-State: AOJu0Yy4de1fm5owASQhyslDYg7PeEPV+AjTVWsYZpgK8hrhfwU3dN02 UtBXZWBAMp9Es6C3UN7uf0vVBBiS1xJd/HC+UyM6FJHhcMOq3IuwRqg0OD4zmt0xFQPsrkeWPUS BDFEJiuAGPSC4Z2dASvhHOWPq8ro7sE2HhZ5ltze6UZxAIX88o7bXPQSXXLae3M4Nig== X-Gm-Gg: AZuq6aI2QsyhbUSGGn5WRKEtmcJty50u36h31YmWtUMwqYGppVgvgdGGPiUUKw+XFTy +R9DAk147uCdJiD/vzyZGJOLFhxWQf70tt16RRaNtaXF6W4pIXi18lkOJpyYOr0ZEd3z6Cz9XX2 kLkxR3cqlxu0Z5vgS3K7CiuwCSpvSjUX+Y491AJc6nWuoO6IVrzZw0pyvH7IvJx/NQeGqOH88Eo ygVWTWKrzUIzZ45LvcxMa157Xt9pn+sMQ3D9k7dGScyCE0CdSr0RRZ5yk0DxK0ulZNiVbPjne45 KhlDWdXrgkjDc0mH57SPCuM1aJsJsBpuDGffAxYpRnAq6x60KE8dtFqCvrf4xA9jugwgRcFThC3 NY82P0p65gPeIi7KChRxLkUmcHYSvZEsgk55ay5AGRKLDPCv4itZf7zP37kqjt0A= X-Received: by 2002:a05:620a:4148:b0:8cb:3f0e:7740 with SMTP id af79cd13be357-8cb79f3269dmr425871885a.51.1771521685056; Thu, 19 Feb 2026 09:21:25 -0800 (PST) X-Received: by 2002:a05:620a:4148:b0:8cb:3f0e:7740 with SMTP id af79cd13be357-8cb79f3269dmr425866385a.51.1771521684499; Thu, 19 Feb 2026 09:21:24 -0800 (PST) Received: from localhost (pool-100-17-19-56.bstnma.fios.verizon.net. [100.17.19.56]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-50684b94e9fsm210902201cf.24.2026.02.19.09.21.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Feb 2026 09:21:24 -0800 (PST) Date: Thu, 19 Feb 2026 12:21:23 -0500 From: Eric Chanudet To: Maxime Ripard Cc: Sumit Semwal , Benjamin Gaignard , Brian Starkey , John Stultz , "T.J. Mercier" , Christian =?utf-8?B?S8O2bmln?= , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org, Albert Esteve , linux-mm@kvack.org Subject: Re: [PATCH v2 3/3] dma-buf: heaps: cma: charge each cma heap's dmem Message-ID: References: <20260218-dmabuf-heap-cma-dmem-v2-0-b249886fb7b2@redhat.com> <20260218-dmabuf-heap-cma-dmem-v2-3-b249886fb7b2@redhat.com> <20260219-illustrious-tungsten-starfish-5dad8c@houat> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260219-illustrious-tungsten-starfish-5dad8c@houat> On Thu, Feb 19, 2026 at 10:16:37AM +0100, Maxime Ripard wrote: > Hi, > > On Wed, Feb 18, 2026 at 12:14:12PM -0500, Eric Chanudet wrote: > > The cma dma-buf heaps let userspace allocate buffers in CMA regions > > without enforcing limits. Since each cma region registers in dmem, > > charge against it when allocating a buffer in a cma heap. > > > > Signed-off-by: Eric Chanudet > > --- > > drivers/dma-buf/heaps/cma_heap.c | 15 ++++++++++++++- > > 1 file changed, 14 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/dma-buf/heaps/cma_heap.c b/drivers/dma-buf/heaps/cma_heap.c > > index 49cc45fb42dd7200c3c14384bcfdbe85323454b1..bbd4f9495808da19256d97bd6a4dca3e1b0a30a0 100644 > > --- a/drivers/dma-buf/heaps/cma_heap.c > > +++ b/drivers/dma-buf/heaps/cma_heap.c > > @@ -27,6 +27,7 @@ > > #include > > #include > > #include > > +#include > > > > #define DEFAULT_CMA_NAME "default_cma_region" > > > > @@ -58,6 +59,7 @@ struct cma_heap_buffer { > > pgoff_t pagecount; > > int vmap_cnt; > > void *vaddr; > > + struct dmem_cgroup_pool_state *pool; > > I guess we should add an #if IS_ENABLED #endif guard for dmem? > Sure, I saw the other user (ttm) didn't, but that makes sense as the field is useless if dmem is not enabled. > > }; > > > > struct dma_heap_attachment { > > @@ -276,6 +278,7 @@ static void cma_heap_dma_buf_release(struct dma_buf *dmabuf) > > kfree(buffer->pages); > > /* release memory */ > > cma_release(cma_heap->cma, buffer->cma_pages, buffer->pagecount); > > + dmem_cgroup_uncharge(buffer->pool, buffer->len); > > kfree(buffer); > > } > > > > @@ -319,9 +322,17 @@ static struct dma_buf *cma_heap_allocate(struct dma_heap *heap, > > if (align > CONFIG_CMA_ALIGNMENT) > > align = CONFIG_CMA_ALIGNMENT; > > > > + if (mem_accounting) { > > + ret = dmem_cgroup_try_charge( > > + cma_get_dmem_cgroup_region(cma_heap->cma), size, > > + &buffer->pool, NULL); > > This alone doesn't call for a new version, but adhering to the kernel > coding style would look like this: > > + ret = dmem_cgroup_try_charge(cma_get_dmem_cgroup_region(cma_heap->cma), > + size, &buffer->pool, NULL); Will add to v3 with the other changes. Thanks, > > It looks good to me otherwise, > Acked-by: Maxime Ripard > > Maxime -- Eric Chanudet