public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Melo <arnaldo.melo@gmail.com>
Cc: David Ahern <dsahern@kernel.org>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>, Jiri Olsa <jolsa@kernel.org>
Subject: Re: perf-trace: improving ioctl details
Date: Thu, 19 Feb 2026 10:49:37 -0800	[thread overview]
Message-ID: <aZdbQYkeAzJlocmU@google.com> (raw)
In-Reply-To: <EEBA89DA-0867-4F9C-A618-8DCD6B61E9DF@gmail.com>

Hi David!

On Wed, Feb 18, 2026 at 04:34:33PM -0300, Arnaldo Melo wrote:
> 
> 
> On February 18, 2026 2:09:26 PM GMT-03:00, David Ahern <dsahern@kernel.org> wrote:
> >Hi Arnaldo, Namhyung:
> >
> >I have a couple of patches to perf-trace to improve the details on ioctl
> >calls. The first one tracks stats by individual filenames, and for the
> >summary output prints the ioctl stats per filename.
> >
> 
> Looks interesting!

Indeed.

> 
> 
> >The second patch improves the output for the _IOC_NR element of the op
> >argument. For flexibility across kernel versions and drivers, it adds
> >the ability to read input files that contain the conversion from number
> >to human readable name. The files (if the option is set) are parsed at
> >start up. In addition to the summary, the cache is also used to improve
> >the readability of each ioctl line.
> >
> >Questions for you:
> >1. is such an open ended design acceptable for perf-trace?
> 
> Is it lazy, i.e. only when needed this cache/table gets loaded? 

I think it's ok.  But I'm curious what's the actual usecases.. do you
want it for testing kernels and drivers?  I guess we can have a default
table for regular users and provide the option for kernel developers.

> 
> >
> >2. if yes, is there any preference on file format (json, yaml,
> >key-value, ...)?
> 
> We already have JSON parsing infra, so probably that is better? 

JSON should be fine, although it's a bit verbose.  I'm fine with plain
KEY=VALUE format too if it's really a simple mapping.

> 
> Great to see you contributing to perf again! 

+1

Thanks,
Namhyung


  reply	other threads:[~2026-02-19 18:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-18 17:09 perf-trace: improving ioctl details David Ahern
2026-02-18 19:34 ` Arnaldo Melo
2026-02-19 18:49   ` Namhyung Kim [this message]
2026-02-20 15:33     ` David Ahern
2026-02-26  1:41       ` Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aZdbQYkeAzJlocmU@google.com \
    --to=namhyung@kernel.org \
    --cc=acme@kernel.org \
    --cc=arnaldo.melo@gmail.com \
    --cc=dsahern@kernel.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox