From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Danilo Krummrich <dakr@kernel.org>
Cc: Bartosz Golaszewski <brgl@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Linus Walleij <linusw@kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
driver-core@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH 1/2] driver core: provide device_match_fwnode_ext()
Date: Thu, 19 Feb 2026 21:27:51 +0200 [thread overview]
Message-ID: <aZdkN2zje5CEaar_@smile.fi.intel.com> (raw)
In-Reply-To: <DGJ3H078RVW8.28AJL6FR3OKOO@kernel.org>
On Thu, Feb 19, 2026 at 05:55:20PM +0100, Danilo Krummrich wrote:
> On Thu Feb 19, 2026 at 5:39 PM CET, Bartosz Golaszewski wrote:
...
> Also, is there a reason why we need both device_match_fwnode() *and*
> device_match_fwnode_ext()?
Yes. We don't want (at least for now) to dive into bug hunting in a 2+ years
horizon if something goes wrong with [currently] working drivers that use
device_match_fwnode() against the cases when there are primary and secondary
fwnodes present.
I won't put my bet that extending device_match_fwnode() won't break anything.
And I don't want to invest (waste?) my time to learn each of the existing cases.
The proposed way is robust and safest. And for the record, I will be the first
person to push back device_match_fwnode() upgrade without a comprehensive testing
on real (affected) HW.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-02-19 19:27 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-19 16:31 [PATCH 0/2] driver core: provide and use device_match_fwnode_ext() Bartosz Golaszewski
2026-02-19 16:31 ` [PATCH 1/2] driver core: provide device_match_fwnode_ext() Bartosz Golaszewski
2026-02-19 16:36 ` Greg Kroah-Hartman
2026-02-19 16:39 ` Bartosz Golaszewski
2026-02-19 16:50 ` Greg Kroah-Hartman
2026-02-19 16:54 ` Dmitry Torokhov
2026-02-19 21:15 ` Bartosz Golaszewski
2026-02-20 0:47 ` Dmitry Torokhov
2026-02-20 7:27 ` Andy Shevchenko
2026-02-20 11:06 ` Bartosz Golaszewski
2026-02-19 16:55 ` Danilo Krummrich
2026-02-19 19:27 ` Andy Shevchenko [this message]
2026-02-19 21:18 ` Bartosz Golaszewski
2026-02-20 0:21 ` Danilo Krummrich
2026-02-20 7:42 ` Andy Shevchenko
2026-02-20 11:21 ` Bartosz Golaszewski
2026-02-19 21:16 ` Bartosz Golaszewski
2026-02-19 19:58 ` Andy Shevchenko
2026-02-19 21:21 ` Bartosz Golaszewski
2026-02-20 7:36 ` Andy Shevchenko
2026-02-20 11:25 ` Bartosz Golaszewski
2026-02-20 12:08 ` Rafael J. Wysocki
2026-02-20 14:35 ` Bartosz Golaszewski
2026-02-20 14:49 ` Andy Shevchenko
2026-02-20 14:55 ` Rafael J. Wysocki
2026-02-20 15:43 ` Danilo Krummrich
2026-02-20 16:03 ` Rafael J. Wysocki
2026-02-19 16:31 ` [PATCH 2/2] gpiolib: use device_match_fwnode_ext() Bartosz Golaszewski
2026-02-19 17:32 ` [PATCH 0/2] driver core: provide and " Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZdkN2zje5CEaar_@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=brgl@kernel.org \
--cc=dakr@kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=driver-core@lists.linux.dev \
--cc=gregkh@linuxfoundation.org \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox