From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f171.google.com (mail-dy1-f171.google.com [74.125.82.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 308F82D8376 for ; Thu, 19 Feb 2026 23:57:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771545437; cv=none; b=SucYNq44/A7QYJTOaCqzFYWdg5zJs1D+dxmOOQ+5XvRreiOCqqDqSs6k5rOWEb6t1xF9iNk9DYDzNJZZk0ZRaGr+tIsZxoChYb09NppHk+Ab9TL4dz+QZKHx1iMDlz6xwCSORmLH1soF+EKldvVevqijfI3FjWCPKSholBWt6o0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771545437; c=relaxed/simple; bh=sj2tJYCyT+rHyjWzt7ciuMOJEoBsJ6ghU0FECAPFjiw=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=s0tPpd+XUOvQCB4w5wSFGqlvrs1hWyln9BPD/ZNEserTCzANloNXBAWeBeKcrcUu9MDIkK39wM5dB/MdWqI5lHCu8nCmtSVMnpMpMx0vPWCV9PLNX8VCylU2FbKvQ+QNBcavcx77UfSDVOrByGZEM694IQJJdYjazuCNjeeSmfI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FT0mqq1A; arc=none smtp.client-ip=74.125.82.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FT0mqq1A" Received: by mail-dy1-f171.google.com with SMTP id 5a478bee46e88-2baab3137bcso1380106eec.0 for ; Thu, 19 Feb 2026 15:57:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771545435; x=1772150235; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=L/tn3rlV+s5Ib8pBAw6WX/SwGwQbUEk8OO3BWVinzBQ=; b=FT0mqq1Aw2KR2Jvr2Rf6psMJnwDWGwGI0g+IGUSXZkbdpHElrsx0cXpC8/7MMJIB/w QXiNVOC+4zu6+m8rVV08LSNqUMbkZ4Nhpjj2d5qlBl0OHIf+HdkeizbgNDEi3QYvXiDs KgTILNjtUVSQSMJ4cJVZVPSBAZArKb05Qp3akLY/ltBVGx3VbMBBvh0PC227Gx43QHUo x+1ixv7cKy1ggdd8g1+J954cWikqywRbtoL91p+8iUacTe7YsjoeaeDfdVxgRNyf2FyE PKy/hzC1yPW7F153kxxHJj2BXUS4lVb3VC+Hs+PDWMktUke1+0ax4yYVatsxDMPv7XBb SnsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771545435; x=1772150235; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=L/tn3rlV+s5Ib8pBAw6WX/SwGwQbUEk8OO3BWVinzBQ=; b=rHiNFBmR6Om04Pa+PB9bCWfplPek3wK6ynQppD6bZLFPCyHXh3gnpr0sQ6AwBJ0LTG cYZ+Mkw6nNH/OmIfienWmsMxCT4z3fAtwEsUruFeGA+zZ71IcVCHd2wg5wqvKfHNnAEn BIqSFVcoVMt7W05NgxSmMm5iK3LiWJnF7HjjcaA42LMzndkREJkCUP7blpGokTw4Vxwf ZuvAUyKIVQQqxvU4ByI+cvPeTDb3M6VKkCzrcVU8Zsl9lu62U4MI8VkaRs3HWGWQmE0F 9pIu+R6HOY9/WLUpffu+OTWVdLMOfAjRv0eLuAkeSh+gs8g+PS3oGqHoXgvFcFVcD7wc sjYg== X-Forwarded-Encrypted: i=1; AJvYcCUhnnktpAAQcD+r5GgwX/dOLFovMcMiHrsVmB8W7jolF+BXs3+8ETexSqgmdPgYUrNBcsUXual5k+Wnibo=@vger.kernel.org X-Gm-Message-State: AOJu0YwHQ4OzaXxIC3BWl5t2d1cxHazW9+tRqMBFycywCD4y5f+jrjWD VmDnwr9wD+X59mh99EUqv1+GTn4i/FxJh0BE6i9jomDn2O7UV62rLhul X-Gm-Gg: AZuq6aJa7Z83JCiTPe21Z9tPS5lYoXbZTYthr1th7kYvh5Hw0psdpgrp7oQi0iSvIPX e0GgP8CllkxHUIxWJEbLrir8Y6v3MK6K5hpHI2H94uvZ4oO9SuAgRz6J55mfLzNQjwB0ARZ1kQ0 ugtNgT21HrZrPavyqsqsWJBSo8ssAk0aF4v8Gi//NG32BJnLxhAI0VFtzo8UmpXE3S5x5zpp5Wt TyIGulQEm7qxodkJf5HFth5mQeXg3L83ADseLvuEjiWjImibOTi917mcVw5TpLkZMF+PN+oQvda vSNGSfssoV7wPLWHyVy1LOBO8Ne70E/X8sbu9SyGAEugTE9kLmQBeyJHzf9bMJnjpdsIn6DbxNG rQWNzWIYxzOVVkA80mXP6XITAvfbwOZSzNcZfZ0qAPBUV1cQCgq4GMW2asPIazpx6EMZiPeLDY8 nYMj6j826GH6yXuNKyKEgJ0n3nK0lTTnmjT/z30Sjd3HXMRol0/fmsFYiePTriwUsH X-Received: by 2002:a05:7301:3f07:b0:2b7:19f2:6b70 with SMTP id 5a478bee46e88-2bac97ab3b9mr7434358eec.26.1771545435151; Thu, 19 Feb 2026 15:57:15 -0800 (PST) Received: from google.com ([2a00:79e0:2ebe:8:9c24:8181:603e:7ad7]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2bacb543e1dsm22099845eec.4.2026.02.19.15.57.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Feb 2026 15:57:14 -0800 (PST) Date: Thu, 19 Feb 2026 15:57:11 -0800 From: Dmitry Torokhov To: Vinod Koul Cc: Neil Armstrong , "Rafael J. Wysocki" , Geert Uytterhoeven , Johan Hovold , Claudiu Beznea , "Dr. David Alan Gilbert" , Peter Griffin , Dmitry Baryshkov , Krzysztof Kozlowski , Zijun Hu , linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] phy: core: fix potential UAF in of_phy_simple_xlate() Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline The implementation put_device()s located device and then uses container_of() on the pointer. The device may disappear by that time, resulting in UAF. Fix the problem by keeping the reference to the framer device, avoiding getting an extra reference to it in framer_get(), and making sure to drop the reference in error path when we fail to get the module. Fixes: e6625db66212 ("phy: core: Simplify API of_phy_simple_xlate() implementation") Signed-off-by: Dmitry Torokhov --- drivers/phy/phy-core.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c index 4ad396214d0c..cf62eb9ddca9 100644 --- a/drivers/phy/phy-core.c +++ b/drivers/phy/phy-core.c @@ -682,10 +682,10 @@ struct phy *of_phy_get(struct device_node *np, const char *con_id) if (IS_ERR(phy)) return phy; - if (!try_module_get(phy->ops->owner)) + if (!try_module_get(phy->ops->owner)) { + put_device(&phy->dev); return ERR_PTR(-EPROBE_DEFER); - - get_device(&phy->dev); + } return phy; } @@ -765,7 +765,6 @@ struct phy *of_phy_simple_xlate(struct device *dev, if (!target_dev) return ERR_PTR(-ENODEV); - put_device(target_dev); return to_phy(target_dev); } EXPORT_SYMBOL_GPL(of_phy_simple_xlate); -- 2.53.0.345.g96ddfc5eaa-goog -- Dmitry