From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f46.google.com (mail-dl1-f46.google.com [74.125.82.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A5922236EE for ; Fri, 20 Feb 2026 00:48:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771548485; cv=none; b=a4oi1IeMSXjYdHBiCEJ2CRq4zgqp4fQaYEJMbuI7+HPUjAfRuUQ+XiUG4kwzaENXukvMHgKDt0gYCxwc9hgP27GfhWxHblqRseiVnb6UwN03mKi+oP4SUWCA2ovLNnlyboP7ypT7a7rdEI34xCD0uPG5fJI+K0kUgJ15MvwI8uE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771548485; c=relaxed/simple; bh=8y+r57ZYPNPnm4O2JdX7FqAZsK4OphEX+0PbJ4Nkie4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=L8KTfkhP5grdWgI/ny+Vi1mIQPNpRTgKCmfOxNQvuyWiGxH4RBs0Bbd6a/i4x4yepUDtw/79Gl0Cif1wcfLzrP91/zvTfE0CyPV7XkhLZTQ/qIL3XoTVnjWvAM2ti8sX70MOUa6Yw38gpBwCisqRpjuOtuisRgAmG487az6oOwk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OY7xwtaf; arc=none smtp.client-ip=74.125.82.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OY7xwtaf" Received: by mail-dl1-f46.google.com with SMTP id a92af1059eb24-124a635476fso1562195c88.0 for ; Thu, 19 Feb 2026 16:48:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771548483; x=1772153283; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=9VgbZEML7yTCSAlB27Kxxz5xLL3aoTRKE4aYyfo5H6w=; b=OY7xwtafQWF2jcUXkbYGEUnhXOgr9GQdxjDJqpyczrWAHEAT9aWE6nAa4eJQyCHhuZ to5RlPTQe+C8zxmn0I1RCARUBBm0TM7ikrwudXuTzFWNssAM0WCHRiyeVY1JjBHZ9doI YPx+uFrcxnxdeRKqShrZr9cTU2MUgWRsUPXQhRbCZOD3zphxRXq3qYsNyUrGl18BCYKC zrVxp3iLvBOuIqqkQO/BApXYgfnl43mDUC8yFgoLif7wEyKl8gmcjEldqwGHLBr3fCMO BJZQnK75+yodMJMMEdOCemk/ULVQdKV0h9PgT49VBCmkuWBQiphdqJtUENpifcXGQLoF SSzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771548483; x=1772153283; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9VgbZEML7yTCSAlB27Kxxz5xLL3aoTRKE4aYyfo5H6w=; b=UOPg96/wuzAuZIuUMcYcy7SB01qc8XnbHQPZtkvdN2W4J0XVawFgoJPv/nofRLjPOr 0+CX3zlKLkEXv2o605VaElvU4TDri5w/4naI1i6dAz4Ja4+muGyHe0WnnX8QdNKzf3dA HhPbzHj0CT0NsebIMFz27kmJfkhGfW60pFPMKpd5g8wgi5br+6YC5H0LRRnLguBXq9by z/NnDcbs0TEx6AL3axm9HWNsrGr9Q0FU6EAx+JoqwJL9nC1wopn23X+jZCsemU3fDrBL xAPFhT6FhqSZa79HDdZqtc/e4e73F4O/NkRit2zKDeR5zbEhyrxy+uaLlj/+vny7E7B9 srxg== X-Forwarded-Encrypted: i=1; AJvYcCWDiCAEgXaVD/B2KGz24rUKsyAI/iP03/TJ47CKoingzTloIqHnfQ9SRU0Di9poRBaPoBUPggRdFnLxaIk=@vger.kernel.org X-Gm-Message-State: AOJu0YxTBZKQNlY5w/qKLrDVFJ0J/whUm1WY2NibxZUHAWTNFh76VjKt qVg7wxV6WNkK1tJuIXVBIgV9QHU2Nala1o4egIlP8C3PHsBgro6Yvti7 X-Gm-Gg: AZuq6aI/g7vHf7mYyLkc3gr7v+AcbgYlswsNKw9nfkv/rcw+j6DMsYZU6p1ZvoHrN4B cKXugK92S2L60L/vpCxJNqAF1AkkLW4KulvfhEmBJ1I5B/Dmrc2itXDbcAE/sJdZzOIf9mVhT0E 38kqy7qghAT5AEcVGo8ljZAt++sti/57B520xQbo6cM2UPN2xvUOPDzSMGYtyOxce8winq4IV5P Lxb+F6PmBq5COYpRkEFPATSpke1kPC3CeZDFR2KND8Z+XwvgQd3LSGlPT4kSaYeQvU5lsJIcI8z oKo40cIyDyjWesfYcwE30m7vWsRZqnXbwezM+oU7ECfFNibdHd15eZK7VBknPcY1pfIhFLi+HgT XGGfil+xOkYhqNy/17P9HmvSrceQi5i/UAzumSFYfYCqonjg0pq54HYlzN2gfFbupHk3zRPgPEB vUqvzkWZ+elFneqm/pgRnIMz63v4lavyxibOJ40liftSn+2R6tm7/4woCQYbiWAuP8 X-Received: by 2002:a05:7022:49c:b0:127:35af:143c with SMTP id a92af1059eb24-12759a75a8emr3117889c88.37.1771548483309; Thu, 19 Feb 2026 16:48:03 -0800 (PST) Received: from google.com ([2a00:79e0:2ebe:8:9c24:8181:603e:7ad7]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2bacb66addcsm22398999eec.24.2026.02.19.16.48.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Feb 2026 16:48:02 -0800 (PST) Date: Thu, 19 Feb 2026 16:47:59 -0800 From: Dmitry Torokhov To: Bartosz Golaszewski Cc: Greg Kroah-Hartman , Bartosz Golaszewski , "Rafael J. Wysocki" , Danilo Krummrich , Linus Walleij , Andy Shevchenko , driver-core@lists.linux.dev, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH 1/2] driver core: provide device_match_fwnode_ext() Message-ID: References: <20260219-device-match-secondary-fwnode-v1-0-a64e8d4754bc@oss.qualcomm.com> <20260219-device-match-secondary-fwnode-v1-1-a64e8d4754bc@oss.qualcomm.com> <2026021900-trekker-twenty-9daa@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Thu, Feb 19, 2026 at 03:15:53PM -0600, Bartosz Golaszewski wrote: > On Thu, 19 Feb 2026 17:54:24 +0100, Dmitry Torokhov > said: > > Hi Bartosz, > > > > On Thu, Feb 19, 2026 at 05:39:47PM +0100, Bartosz Golaszewski wrote: > >> On Thu, Feb 19, 2026 at 5:36 PM Greg Kroah-Hartman > >> wrote: > >> > > >> > On Thu, Feb 19, 2026 at 05:31:22PM +0100, Bartosz Golaszewski wrote: > >> > > Provide an extended variant of device_match_fwnode() that also tries to > >> > > match the device's secondary fwnode. > >> > > > >> > > Signed-off-by: Bartosz Golaszewski > >> > > --- > >> > > drivers/base/core.c | 14 ++++++++++++++ > >> > > include/linux/device/bus.h | 1 + > >> > > 2 files changed, 15 insertions(+) > >> > > > >> > > diff --git a/drivers/base/core.c b/drivers/base/core.c > >> > > index f599a1384eec90c104601422b04dc2b4c19d4382..bbf1337978fafc35eb94bda85e0bb7f6879879c0 100644 > >> > > --- a/drivers/base/core.c > >> > > +++ b/drivers/base/core.c > >> > > @@ -5326,6 +5326,20 @@ int device_match_fwnode(struct device *dev, const void *fwnode) > >> > > } > >> > > EXPORT_SYMBOL_GPL(device_match_fwnode); > >> > > > >> > > +int device_match_fwnode_ext(struct device *dev, const void *fwnode) > >> > > >> > No kernel doc to explain what this function does? > >> > > >> > :( > >> > > >> > >> It's not like any of the other variants from this file were documented > >> but ok, I can add it in v2. Still, I'd like to hear if this even makes > >> sense. > > > > I think it really needs a good explanation given how it goes through > > secondaries on one side but not on the other (but maybe it should? Why > > one would not want to match secondary?) > > > > I don't think it should. You have one, concrete fwnode and you want to match > it against a struct device: in this variant both its primary and secondary > nodes. I don't think we should do a four-way matching. I wonder why you consider these 2 distinct fwnodes instead of a single object that has multiple components? After all in device we have a pointer to fwnode, and not list of fwnodes.... Thanks. -- Dmitry