* [PATCH v1 1/1] ata: ahci-dwc: Remove not-going-to-be-supported code for Baikal SoC
@ 2026-02-20 10:42 Andy Shevchenko
2026-02-20 13:27 ` Niklas Cassel
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2026-02-20 10:42 UTC (permalink / raw)
To: Damien Le Moal, Krzysztof Kozlowski, Andy Shevchenko, linux-ide,
linux-kernel
Cc: Niklas Cassel
As noticed in the discussion [1] the Baikal SoC and platforms
are not going to be finalized, hence remove stale code.
Link: https://lore.kernel.org/lkml/22b92ddf-6321-41b5-8073-f9c7064d3432@infradead.org/ [1]
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/ata/Kconfig | 1 -
drivers/ata/ahci_dwc.c | 54 ------------------------------------------
2 files changed, 55 deletions(-)
diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 2349bca136e0..fff305ec1e78 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -194,7 +194,6 @@ config AHCI_DM816
config AHCI_DWC
tristate "Synopsys DWC AHCI SATA support"
select SATA_HOST
- select MFD_SYSCON if (MIPS_BAIKAL_T1 || COMPILE_TEST)
help
This option enables support for the Synopsys DWC AHCI SATA
controller implementation.
diff --git a/drivers/ata/ahci_dwc.c b/drivers/ata/ahci_dwc.c
index 64abf865bb67..436041c57f73 100644
--- a/drivers/ata/ahci_dwc.c
+++ b/drivers/ata/ahci_dwc.c
@@ -13,7 +13,6 @@
#include <linux/kernel.h>
#include <linux/libata.h>
#include <linux/log2.h>
-#include <linux/mfd/syscon.h>
#include <linux/module.h>
#include <linux/of.h>
#include <linux/platform_device.h>
@@ -92,20 +91,6 @@
#define AHCI_DWC_PORT_PHYCR 0x74
#define AHCI_DWC_PORT_PHYSR 0x78
-/* Baikal-T1 AHCI SATA specific registers */
-#define AHCI_BT1_HOST_PHYCR AHCI_DWC_HOST_GPCR
-#define AHCI_BT1_HOST_MPLM_MASK GENMASK(29, 23)
-#define AHCI_BT1_HOST_LOSDT_MASK GENMASK(22, 20)
-#define AHCI_BT1_HOST_CRR BIT(19)
-#define AHCI_BT1_HOST_CRW BIT(18)
-#define AHCI_BT1_HOST_CRCD BIT(17)
-#define AHCI_BT1_HOST_CRCA BIT(16)
-#define AHCI_BT1_HOST_CRDI_MASK GENMASK(15, 0)
-
-#define AHCI_BT1_HOST_PHYSR AHCI_DWC_HOST_GPSR
-#define AHCI_BT1_HOST_CRA BIT(16)
-#define AHCI_BT1_HOST_CRDO_MASK GENMASK(15, 0)
-
struct ahci_dwc_plat_data {
unsigned int pflags;
unsigned int hflags;
@@ -122,39 +107,6 @@ struct ahci_dwc_host_priv {
u32 dmacr[AHCI_MAX_PORTS];
};
-static int ahci_bt1_init(struct ahci_host_priv *hpriv)
-{
- struct ahci_dwc_host_priv *dpriv = hpriv->plat_data;
- int ret;
-
- /* APB, application and reference clocks are required */
- if (!ahci_platform_find_clk(hpriv, "pclk") ||
- !ahci_platform_find_clk(hpriv, "aclk") ||
- !ahci_platform_find_clk(hpriv, "ref")) {
- dev_err(&dpriv->pdev->dev, "No system clocks specified\n");
- return -EINVAL;
- }
-
- /*
- * Fully reset the SATA AXI and ref clocks domain to ensure the state
- * machine is working from scratch especially if the reference clocks
- * source has been changed.
- */
- ret = ahci_platform_assert_rsts(hpriv);
- if (ret) {
- dev_err(&dpriv->pdev->dev, "Couldn't assert the resets\n");
- return ret;
- }
-
- ret = ahci_platform_deassert_rsts(hpriv);
- if (ret) {
- dev_err(&dpriv->pdev->dev, "Couldn't de-assert the resets\n");
- return ret;
- }
-
- return 0;
-}
-
static struct ahci_host_priv *ahci_dwc_get_resources(struct platform_device *pdev)
{
struct ahci_dwc_host_priv *dpriv;
@@ -457,15 +409,9 @@ static struct ahci_dwc_plat_data ahci_dwc_plat = {
.pflags = AHCI_PLATFORM_GET_RESETS,
};
-static struct ahci_dwc_plat_data ahci_bt1_plat = {
- .pflags = AHCI_PLATFORM_GET_RESETS | AHCI_PLATFORM_RST_TRIGGER,
- .init = ahci_bt1_init,
-};
-
static const struct of_device_id ahci_dwc_of_match[] = {
{ .compatible = "snps,dwc-ahci", &ahci_dwc_plat },
{ .compatible = "snps,spear-ahci", &ahci_dwc_plat },
- { .compatible = "baikal,bt1-ahci", &ahci_bt1_plat },
{},
};
MODULE_DEVICE_TABLE(of, ahci_dwc_of_match);
--
2.50.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] ata: ahci-dwc: Remove not-going-to-be-supported code for Baikal SoC
2026-02-20 10:42 [PATCH v1 1/1] ata: ahci-dwc: Remove not-going-to-be-supported code for Baikal SoC Andy Shevchenko
@ 2026-02-20 13:27 ` Niklas Cassel
2026-02-20 13:36 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Niklas Cassel @ 2026-02-20 13:27 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Damien Le Moal, Krzysztof Kozlowski, linux-ide, linux-kernel
On Fri, Feb 20, 2026 at 11:42:08AM +0100, Andy Shevchenko wrote:
> As noticed in the discussion [1] the Baikal SoC and platforms
> are not going to be finalized, hence remove stale code.
>
> Link: https://lore.kernel.org/lkml/22b92ddf-6321-41b5-8073-f9c7064d3432@infradead.org/ [1]
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/ata/Kconfig | 1 -
> drivers/ata/ahci_dwc.c | 54 ------------------------------------------
> 2 files changed, 55 deletions(-)
>
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index 2349bca136e0..fff305ec1e78 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -194,7 +194,6 @@ config AHCI_DM816
> config AHCI_DWC
> tristate "Synopsys DWC AHCI SATA support"
> select SATA_HOST
> - select MFD_SYSCON if (MIPS_BAIKAL_T1 || COMPILE_TEST)
> help
> This option enables support for the Synopsys DWC AHCI SATA
> controller implementation.
> diff --git a/drivers/ata/ahci_dwc.c b/drivers/ata/ahci_dwc.c
> index 64abf865bb67..436041c57f73 100644
> --- a/drivers/ata/ahci_dwc.c
> +++ b/drivers/ata/ahci_dwc.c
> @@ -13,7 +13,6 @@
> #include <linux/kernel.h>
> #include <linux/libata.h>
> #include <linux/log2.h>
> -#include <linux/mfd/syscon.h>
> #include <linux/module.h>
> #include <linux/of.h>
> #include <linux/platform_device.h>
Since you are removing the, from what I can tell, unused syscon.h, I think
we should remove the, from what I can tell, unused linux/regmap.h include
as well.
(snip)
> static const struct of_device_id ahci_dwc_of_match[] = {
> { .compatible = "snps,dwc-ahci", &ahci_dwc_plat },
> { .compatible = "snps,spear-ahci", &ahci_dwc_plat },
> - { .compatible = "baikal,bt1-ahci", &ahci_bt1_plat },
If we are dropping support for baikal,bt1-ahci, then I think it makes sense
to remove Documentation/devicetree/bindings/ata/baikal,bt1-ahci.yaml
as well.
Kind regards,
Niklas
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] ata: ahci-dwc: Remove not-going-to-be-supported code for Baikal SoC
2026-02-20 13:27 ` Niklas Cassel
@ 2026-02-20 13:36 ` Andy Shevchenko
0 siblings, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2026-02-20 13:36 UTC (permalink / raw)
To: Niklas Cassel
Cc: Damien Le Moal, Krzysztof Kozlowski, linux-ide, linux-kernel
On Fri, Feb 20, 2026 at 02:27:28PM +0100, Niklas Cassel wrote:
> On Fri, Feb 20, 2026 at 11:42:08AM +0100, Andy Shevchenko wrote:
> > As noticed in the discussion [1] the Baikal SoC and platforms
> > are not going to be finalized, hence remove stale code.
...
> > #include <linux/kernel.h>
> > #include <linux/libata.h>
> > #include <linux/log2.h>
> > -#include <linux/mfd/syscon.h>
> > #include <linux/module.h>
> > #include <linux/of.h>
> > #include <linux/platform_device.h>
>
> Since you are removing the, from what I can tell, unused syscon.h, I think
> we should remove the, from what I can tell, unused linux/regmap.h include
> as well.
>
> (snip)
>
> > static const struct of_device_id ahci_dwc_of_match[] = {
> > { .compatible = "snps,dwc-ahci", &ahci_dwc_plat },
> > { .compatible = "snps,spear-ahci", &ahci_dwc_plat },
> > - { .compatible = "baikal,bt1-ahci", &ahci_bt1_plat },
>
> If we are dropping support for baikal,bt1-ahci, then I think it makes sense
> to remove Documentation/devicetree/bindings/ata/baikal,bt1-ahci.yaml
> as well.
Thanks, I have just sent a v2 with the suggested changes.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-02-20 13:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-20 10:42 [PATCH v1 1/1] ata: ahci-dwc: Remove not-going-to-be-supported code for Baikal SoC Andy Shevchenko
2026-02-20 13:27 ` Niklas Cassel
2026-02-20 13:36 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox