public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Niklas Cassel <cassel@kernel.org>
Cc: Damien Le Moal <dlemoal@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>,
	linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1] ata: ahci-dwc: Remove not-going-to-be-supported code for Baikal SoC
Date: Fri, 20 Feb 2026 15:36:47 +0200	[thread overview]
Message-ID: <aZhjb6EF4nPi-hMI@smile.fi.intel.com> (raw)
In-Reply-To: <aZhhO5lMa0p41_VR@ryzen>

On Fri, Feb 20, 2026 at 02:27:28PM +0100, Niklas Cassel wrote:
> On Fri, Feb 20, 2026 at 11:42:08AM +0100, Andy Shevchenko wrote:
> > As noticed in the discussion [1] the Baikal SoC and platforms
> > are not going to be finalized, hence remove stale code.

...

> >  #include <linux/kernel.h>
> >  #include <linux/libata.h>
> >  #include <linux/log2.h>
> > -#include <linux/mfd/syscon.h>
> >  #include <linux/module.h>
> >  #include <linux/of.h>
> >  #include <linux/platform_device.h>
> 
> Since you are removing the, from what I can tell, unused syscon.h, I think
> we should remove the, from what I can tell, unused linux/regmap.h include
> as well.
> 
> (snip)
> 
> >  static const struct of_device_id ahci_dwc_of_match[] = {
> >  	{ .compatible = "snps,dwc-ahci", &ahci_dwc_plat },
> >  	{ .compatible = "snps,spear-ahci", &ahci_dwc_plat },
> > -	{ .compatible = "baikal,bt1-ahci", &ahci_bt1_plat },
> 
> If we are dropping support for baikal,bt1-ahci, then I think it makes sense
> to remove Documentation/devicetree/bindings/ata/baikal,bt1-ahci.yaml
> as well.

Thanks, I have just sent a v2 with the suggested changes.

-- 
With Best Regards,
Andy Shevchenko



      reply	other threads:[~2026-02-20 13:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-20 10:42 [PATCH v1 1/1] ata: ahci-dwc: Remove not-going-to-be-supported code for Baikal SoC Andy Shevchenko
2026-02-20 13:27 ` Niklas Cassel
2026-02-20 13:36   ` Andy Shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aZhjb6EF4nPi-hMI@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=cassel@kernel.org \
    --cc=dlemoal@kernel.org \
    --cc=krzysztof.kozlowski@oss.qualcomm.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox