From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Antoniu Miclaus <antoniu.miclaus@analog.com>
Cc: "Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Cosmin Tanislav" <cosmin.tanislav@analog.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] iio: adc: ad7266: simplify error return
Date: Fri, 20 Feb 2026 16:09:08 +0200 [thread overview]
Message-ID: <aZhrBO0dkftNJ_z1@smile.fi.intel.com> (raw)
In-Reply-To: <20260220131847.76968-2-antoniu.miclaus@analog.com>
On Fri, Feb 20, 2026 at 03:18:46PM +0200, Antoniu Miclaus wrote:
> Return PTR_ERR() directly instead of assigning it to an intermediate
> variable first.
Definitely!
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-02-20 14:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-20 13:18 [PATCH 0/2] iio: simplify return statements Antoniu Miclaus
2026-02-20 13:18 ` [PATCH 1/2] iio: adc: ad7266: simplify error return Antoniu Miclaus
2026-02-20 14:09 ` Andy Shevchenko [this message]
2026-02-22 16:50 ` Jonathan Cameron
2026-02-20 13:18 ` [PATCH 2/2] iio: addac: ad74413r: simplify timeout return Antoniu Miclaus
2026-02-20 14:08 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZhrBO0dkftNJ_z1@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=cosmin.tanislav@analog.com \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox