From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f201.google.com (mail-pg1-f201.google.com [209.85.215.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E496365A1D for ; Fri, 20 Feb 2026 17:36:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771608980; cv=none; b=oebdTq9fev0AidH/VLy8pP13ZrKjAoFvqqmO2/j8pS3FfvvaYDR3lqZzKzGAiW7qhAkwEXdtTUEzcKOIeGtuc/6I6Zqp1PC/XDbK/uUcXJniYdKW09w+3Pnfu9EnpgY7fT993zDOGr2YIus3wh4bjX2V1xy/9NG8Wz1SrH0hVOk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771608980; c=relaxed/simple; bh=hk7yXmM1aV9/FRe2EJXMXYJoy7A43ImHdOcEk/9ZdFM=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=VFKOIF7ZTsSOyyttB9Akig22NdJ4hLoymQfzqWVQMIRvnnE5wH1C3QWLsV33xAHUCbxOJRrtBdPMXvo2YhDs8SrfzJTZp3Nm61c4NPJZm0MSJlavse8g+WrsJJCOHYXuUi+ZEnlaKVWwLr6MVOg2eqEU72wip4LDAL2jkJOG8Lk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=L1qfMPPF; arc=none smtp.client-ip=209.85.215.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="L1qfMPPF" Received: by mail-pg1-f201.google.com with SMTP id 41be03b00d2f7-c6e1d074b26so1386577a12.3 for ; Fri, 20 Feb 2026 09:36:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1771608978; x=1772213778; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=hk7yXmM1aV9/FRe2EJXMXYJoy7A43ImHdOcEk/9ZdFM=; b=L1qfMPPFcJoYeLbiti+bP6vb6ymgMCcdS5ZZWaWhp16pKhRDsjwQ44if9bT0KZdL2R zUr/x7jpRON5KBOUaWRiHtAgcwDLHyn4N0h38/CyGCJytJCWVgSkmmcNs+690FAValHO h0x5qIrLY6zL2gMOckvgMw/Br2iO7evJ4EEqSIs670kJngHXYvXDGUlhlHX4poG+beQb rox+bUtSbnSBNpEFyrDG4VPQiHfYRjdvJ6+K9naEhwckmad1673gRmJuP7TRrg7AOKrJ 2YQM1uOSx/9XGcNBQLBVPX94B8a9SUEE/yEGZFeu8UDELAkqccPvs2+uOM82a/E+giBL zFGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771608978; x=1772213778; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=hk7yXmM1aV9/FRe2EJXMXYJoy7A43ImHdOcEk/9ZdFM=; b=KgNbrlKHffjb13N5RMP6J73/xVIPGIbqPED9oYG1Cl9x9mCUXQb9C5xXdcu9FJ3U1Z 3TTVaW+OW39DL7Tf4rNCQYc1xozBBuflPhkf2NJ/jwTbC9ys0FGCyHdfhn9k9YVqfVJH RnD9C0fx7iyV+skM+dBNr9Hq8vxEcvFLg53gP0wQOg7ERab76f4NtQpGZuZLxbbnLyjI nXdD1keYOIff78IPoMNKyolmRrXoe8B05mvPCRD8akAKYoTbf2H6Uc/xxh2rWtObzf0b sfuGFkBy5qyabrrtmQsTPe31nkvdoHa5HOI+8w29hEX3dDMhbhejWGHPlQCvg2orS0XH OWxQ== X-Forwarded-Encrypted: i=1; AJvYcCWxDBJmK/LHcln8H4SBBA8Dc75CYC+L2hgoebkK3cI3LzoWS7EhhXF/Scwz4zmj4s6cmMk+V04+2jVBmvY=@vger.kernel.org X-Gm-Message-State: AOJu0YyKzRtTvhu2EwwRK8fIcMRd2zKdqPXu+j3V1FN7yOz3XIi06iGA DrPk7DC8wfReL2vdwKIXSFLOgloYNaiAV9190fJcAqzrVldgafKD/4Rg2Gqtrx+HhOtHYA87d0s 0xPnm4w== X-Received: from pgbz2.prod.google.com ([2002:a63:6502:0:b0:c6e:4b29:e099]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a21:e095:b0:366:14ac:8c6f with SMTP id adf61e73a8af0-39545fe80e9mr288982637.69.1771608978196; Fri, 20 Feb 2026 09:36:18 -0800 (PST) Date: Fri, 20 Feb 2026 09:36:16 -0800 In-Reply-To: <75fc3f45e24309abef6dae31809012440de6d4ee.camel@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260129011517.3545883-1-seanjc@google.com> <20260129011517.3545883-6-seanjc@google.com> <75fc3f45e24309abef6dae31809012440de6d4ee.camel@intel.com> Message-ID: Subject: Re: [RFC PATCH v5 05/45] KVM: TDX: Drop kvm_x86_ops.link_external_spt(), use .set_external_spte() for all From: Sean Christopherson To: Rick P Edgecombe Cc: Yan Y Zhao , "kvm@vger.kernel.org" , "linux-coco@lists.linux.dev" , Xiaoyao Li , Kai Huang , "dave.hansen@linux.intel.com" , "kas@kernel.org" , "binbin.wu@linux.intel.com" , "mingo@redhat.com" , "pbonzini@redhat.com" , "ackerleytng@google.com" , "linux-kernel@vger.kernel.org" , Isaku Yamahata , "sagis@google.com" , "tglx@kernel.org" , "bp@alien8.de" , Vishal Annapurve , "x86@kernel.org" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Wed, Feb 18, 2026, Rick P Edgecombe wrote: > On Tue, 2026-02-03 at 20:05 +0000, Sean Christopherson wrote: > > > And mirror_spte --> new_spte? > >=20 > > Hmm, ya, I made that change later, but it can probably be shifted here. >=20 > Sorry for the late comment on the tiny detail, but things seemed to have = calmed > down enough to attempt to merge these discussions into the snarl. >=20 > It doesn't quite fit in this patch=C2=A0because the set_external_spte() o= p also uses > the mirror_pte name. So then you need to either expand the scope of the p= atch to > change "mirror" to "new" across the callchain, or creating a small mismat= ch > between tdx_sept_set_private_spte() and tdx_sept_link_private_spt(). >=20 > The patch where it happens in this series needs to add the old_pte, forci= ng > mirror_spte to grow some new nomenclature. So on balance I think it fits = better > there, and we should leave it alone here. We can update it in > tdx_sept_link_private_spt() in "KVM: x86/mmu: Plumb the old_spte into > kvm_x86_ops.set_external_spte()". No argument from me.