From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92E6417A2FA for ; Sat, 21 Feb 2026 13:20:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771680014; cv=none; b=JKC31W92zplgY3x0pY78o+tG+/nlzz6JhuYBRAhpZZ5tEDe5WeSClM3V+ycF6al79V8QvY2Y7kDE7/DEneDSRDh2vEHTBdIzou4qiFW8FQQoqoD11AHKLDK0ycG95XfMezWU6UNuqRwKIX6r0facJle9lD5wvCW8EFxVgM0+NAM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771680014; c=relaxed/simple; bh=yhItmu6FwILqw3juiZ762Wal0BhMMNKFmFnYzaB6CTM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=r/G5yPDIMYlDbJ8XPY/YDjA1iMm8wrZredayVjJkx32uap41CZ4Ygi0gzOt0/Pd/yCk+X4pbeC21pD2omp0edZotaorc1hJsUMXqV8/i6F6LjV3MT0qnpwxiaYHry6iulvkWWOHG6c4izFQdwrvdje0inXi5W9F3R6chUQG95gs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=wGjYm8TN; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wGjYm8TN" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-4834826e5a0so34986145e9.2 for ; Sat, 21 Feb 2026 05:20:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1771680011; x=1772284811; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ygKOGn/6qB099OqOl4y/DQB2ZJZmO/cFE4lvTvj5L4M=; b=wGjYm8TNDm5uCqsda+JvFK3GvFEoN9MUuKn/i3BEToOJrdBMADSFzmXn/wl1EAM198 CxkjXpAUVKvxU4jaJMLz2KD2lZfzgGH0uCW0FUNiQsF52ywp1a/Ewk16eaQvphKANPWZ glqeoxBNHUfAy+blnsf1o4DdDGbMJhW1Hsh0kiGQ1pdczNpDx9mIVU9RXpIZCVmJ8ZUn +n1gjrygwcZM3sCpw811MYYqZJ5URtJQkFJByez0+1f8jwwz/u1f/68JTERs9hl7Msri scL7naXYrXf6PGSNDnwxcZ5HG2rLfzGjGu+42uZcvcVbQ2zuLmn6u24xkYHRvTXD/HPq X5gQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771680011; x=1772284811; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ygKOGn/6qB099OqOl4y/DQB2ZJZmO/cFE4lvTvj5L4M=; b=WCElCcEVwmb25d6kI9f1I4pwuga4NwLcLjwO7IWUr9ZBWeVRLUh3pT96V5eff2IsSe gY8Cd9x6V19fOBjTVnMqH4daBWeL1ydnlDl53MAuZSTYvD5ENnfE5tKLzYSvM20oBygT I31uC14g+FBT7vz8arWwopEXsal7wEXu34T2I+sNxCekEm+VHtGoHl1+zSdELp3anev2 +OYRqoN80+6IFbzestk+PTmd035oIrX2Ts89AEj96EO1YKW9/RF/Bl27VZujMkdtnJ37 IK0yzpjb+D54JNyWjHoFBGjnzWifoBd1nwWFzz0VOUMdYQ3NwkhHBQkI8tHpVYaE605J Rujw== X-Forwarded-Encrypted: i=1; AJvYcCXfG/PcmJWJJRDucXQZ2u2kxp5RdOxzWQR01Y7J032VfUWMSZXlsFRUVYwZkPbE7w7i6t9GNZJrvpOvgLE=@vger.kernel.org X-Gm-Message-State: AOJu0YxOBy8QaP5+OpHW7kFX3pvQUvjJOGS5B+7Og/DeYJGVlVY7azUs T9mbsW3qU+w1DfCLloDCeXYD5fUSMNTAtTnxwctt2MUTMPtPSlGz2dsKYzBBzeRzRaI= X-Gm-Gg: AZuq6aJxGvoNtNpohVi5n7d5cZWWc0SryKdCQ6E2HuXxBIRLtUTGPOR3O1oqI6OOZfV UkkPAx/RvbEEQEU/ds1Cc0hbKoP/G+gCnn8RD4osg7+DIHXkGcIkSN+4/77y0YhR8ttCcKurIGT MDXbZ0tk0lBlUgeZmWQbhiQUsYyBdmW1KLVkpB80jEyWGpEIY3vWj2Y7R6cJL8WAQudN5Lxm4kn zkc7CH9L8+OxcciSwRafjUWqBelJA37gOcnnw663EOHkyHVhfHo6mvhGwV5SkKsBaEaVd7jovtb ie6R0B4ORX1m2D0by/kYFC03vJVaOACCVYg3f9hTXWRt5Smi3/4QAL80WZxAf+dkIWOu9VNYlem pC/SMGCqru1tdNXsy+rbaHiJ5LMdu7f9jEEebpZNZlt5wm64/ea68VfhRxqT1xJcUjYSUTHuWX/ 2VsIWV3xIbJ5pB6XXQdf3uHiBrMWgG X-Received: by 2002:a05:600c:1e1d:b0:483:456a:514b with SMTP id 5b1f17b1804b1-483a95befe5mr46388145e9.12.1771680010849; Sat, 21 Feb 2026 05:20:10 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483a9b7fddbsm52095355e9.8.2026.02.21.05.20.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Feb 2026 05:20:10 -0800 (PST) Date: Sat, 21 Feb 2026 16:20:07 +0300 From: Dan Carpenter To: Giorgi Tchankvetadze Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8723bs: Use kmemdup in sdio_ops.c Message-ID: References: <20260221105148.309255-2-giorgitchankvetadze1997@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260221105148.309255-2-giorgitchankvetadze1997@gmail.com> On Sat, Feb 21, 2026 at 02:51:49PM +0400, Giorgi Tchankvetadze wrote: > Replace kmalloc() + memcpy() with kmemdup() to simplify the code. > No functional change. > > Signed-off-by: Giorgi Tchankvetadze > --- > drivers/staging/rtl8723bs/hal/sdio_ops.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c b/drivers/staging/rtl8723bs/hal/sdio_ops.c > index c9cb20c61a2b..6e03d3d8a6ab 100644 > --- a/drivers/staging/rtl8723bs/hal/sdio_ops.c > +++ b/drivers/staging/rtl8723bs/hal/sdio_ops.c > @@ -583,11 +583,10 @@ s32 sdio_local_write( > ) > return sd_cmd52_write(intfhdl, addr, cnt, buf); > > - tmpbuf = kmalloc(cnt, GFP_ATOMIC); > + tmpbuf = kmemdup(buf, cnt, GFP_ATOMIC); > if (!tmpbuf) > return -ENOMEM; > > - memcpy(tmpbuf, buf, cnt); > You need to delete a blank line here as well. regards, dan carpenter > err = sd_write(intfhdl, addr, cnt, tmpbuf);