From: Lukas Wunner <lukas@wunner.de>
To: Aksh Garg <a-garg7@ti.com>
Cc: linux-pci@vger.kernel.org, linux-doc@vger.kernel.org,
bhelgaas@google.com, corbet@lwn.net, cassel@kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, s-vadapalli@ti.com,
danishanwar@ti.com, srk@ti.com
Subject: Re: [RFC PATCH 2/4] PCI/DOE: Move common definitions to the header file
Date: Sun, 22 Feb 2026 14:01:56 +0100 [thread overview]
Message-ID: <aZr-RMZlgO0eEM8n@wunner.de> (raw)
In-Reply-To: <20260213123603.420941-3-a-garg7@ti.com>
On Fri, Feb 13, 2026 at 06:06:01PM +0530, Aksh Garg wrote:
> Move common macros and structures from drivers/pci/doe.c to
> include/linux/pci-doe.h to allow reuse across root complex and
> endpoint DOE implementations.
Please use drivers/pci/pci.h for declarations that need not be visible
outside the PCI core.
There are users of pci_doe() & pci_find_doe_mailbox() outside the
PCI core, that's the (only) reason the declarations are in
include/linux/pci-doe.h.
> Also add CONFIG_PCI_DOE guards around the root complex DOE APIs to
> maintain proper conditional compilation.
It's not clear to me why these empty inlines are needed, please drop
them or provide an explanation in the commit message.
Thanks,
Lukas
next prev parent reply other threads:[~2026-02-22 13:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-13 12:35 [RFC PATCH 0/4] PCI: Add DOE support for endpoint Aksh Garg
2026-02-13 12:36 ` [RFC PATCH 1/4] PCI: Add documentation for DOE endpoint support Aksh Garg
2026-02-13 20:33 ` Niklas Cassel
2026-02-18 11:21 ` Aksh Garg
2026-02-13 12:36 ` [RFC PATCH 2/4] PCI/DOE: Move common definitions to the header file Aksh Garg
2026-02-22 13:01 ` Lukas Wunner [this message]
2026-02-23 7:30 ` Aksh Garg
2026-02-13 12:36 ` [RFC PATCH 3/4] PCI/DOE: Add DOE mailbox support for endpoint functions Aksh Garg
2026-02-13 13:21 ` Niklas Cassel
2026-02-18 4:28 ` Alistair Francis
2026-03-04 14:18 ` Manivannan Sadhasivam
2026-03-06 12:14 ` Aksh Garg
2026-02-22 13:06 ` Lukas Wunner
2026-02-23 10:44 ` Aksh Garg
2026-03-04 14:17 ` Manivannan Sadhasivam
2026-03-06 8:17 ` Aksh Garg
2026-02-13 12:36 ` [RFC PATCH 4/4] PCI: Document APIs for endpoint DOE implementation Aksh Garg
2026-02-13 13:16 ` [RFC PATCH 0/4] PCI: Add DOE support for endpoint Niklas Cassel
2026-03-04 14:22 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZr-RMZlgO0eEM8n@wunner.de \
--to=lukas@wunner.de \
--cc=a-garg7@ti.com \
--cc=bhelgaas@google.com \
--cc=cassel@kernel.org \
--cc=corbet@lwn.net \
--cc=danishanwar@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=s-vadapalli@ti.com \
--cc=srk@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox