From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f169.google.com (mail-dy1-f169.google.com [74.125.82.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C96EA1624C5 for ; Sun, 22 Feb 2026 21:39:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771796362; cv=none; b=T4C08thS7dr6RzDUv4k7FaRIW2T+l/4oANPdRKZ3ZMtFofnLGmKkqyJqPwD2s4om08ufTIZ0Pu2WLWVJF/7rpjGJVnaRJHJv6+hemj4sm82enV0n/NLIseOcrXaQ5yYTLwxOveYwm3IUgLHdD4lOY7KcX/IKOBHyFI9qpZYHtB0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771796362; c=relaxed/simple; bh=HzrKTPvXlTJ+y/nQ94Q31CSXj4sSzxZ6mrkMBtYDf+8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=eziO/gB67cluaZn14skDMp8PEBHcxzt+1npf7HwWqOpme7CzNRED/T55vplmVNQg2DZNCU3tju60vjHGw1i5UfaIdJpOodYoQkojWU9NYjUzoCn0VkFiHNml3W/mr08kabdnogBd58aHm8F71r2WmqEXvYoUuTeQW1063dGN7YM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Yn1tevL3; arc=none smtp.client-ip=74.125.82.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Yn1tevL3" Received: by mail-dy1-f169.google.com with SMTP id 5a478bee46e88-2bab70f8c8aso3460279eec.1 for ; Sun, 22 Feb 2026 13:39:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771796361; x=1772401161; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=B+Ki2+Wg/SQ/F2z698NW70nywxyMc5k+gAsNO7ctLsc=; b=Yn1tevL3/wwuJVuLOU8KBiAHXeacUF1Pa3/X6DooDGcqPDV+zOWho+JvRKNFrt5Vu9 WeP/edmf9Ln66n/0N1PpE5cMrqp2M8/BLCwgZBgAde9OqVi7MRSlNpw5ekyeZi+5yBvx 3MF+gAYrXAkNu8LuSWf4Lem6jbtzQWO3kOBP+jTdf2jQE2Xi4Ts2acLKkjN9+WJkbwm0 9ZMEVUNgPEmOUiOMl0exU5liEQIW400ML9z0mGIJCEdUzAoAoCJHUzS+RFDeQbIAgH8F Zlr9pAYfqgtOwi3SNK6DbwBY4jI/x9BFxQtBEV5a5oRqDMUkxjctH/QG2f0e+ke3DkdE 821Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771796361; x=1772401161; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=B+Ki2+Wg/SQ/F2z698NW70nywxyMc5k+gAsNO7ctLsc=; b=Wr5R1BODsFdMl89eQuodrOypobYMyGnUZ4aLJfphF/p3wdDmTuXVwC1baOr1PoaHgL tsRDQqCvFjXgFaX0N1awlaAYuKzcUnoMsFjS0w3Npqnh1d6grCVhxzfckzpfxgCTX7Lm qugWpBSIKM7u663wiYI83sM4NRyPf4HbnsAuXnuLrvslQGrRqCfM4t68eyR/QJYzAlXl dWJ67LjADpV5DSOhIX2j+jRFe+1jTf8KpIDVFYTY/fONVNPWd86TTy0omstmTHxfctRE qzR03q1UCMK4SiFg0GWMzOIb8LfFXdP7+4mbkwpm0OPHbNC+MikudB92VpGTdFnr+KDc LQ2w== X-Forwarded-Encrypted: i=1; AJvYcCVLpYecdqEk6PwVPevI5DXbjK54Lo9oX2IrNqLqq6KYWscPK+6kNYDZb0Z39dgRgK17DGCJC9lgibZM4/I=@vger.kernel.org X-Gm-Message-State: AOJu0YweIRspxwI68L9bqoh/lI5Ubn/QQNw8xg+YFXUsrSVeSLx48ECa yxXS4VTD4WnZuUShFARhccADgl6NJYUpuioYkBrDBtHEDwNngv8PFp+L X-Gm-Gg: AZuq6aJHzgOEX5G695oxfDXXIqPIDrO5AuCL2NJDYG3or6jVHOl2oLpMJmVPcVed5Dp v4Tf/yRlCt0GpwfSYaEnvkFtpIENIedo8K5iGvK3cga8tKD6Uc5PoomACTegCQ9mRGJ21bxhpVF Uh0qxCdPQZm9rh2v9dC6nEtzkoAOIoI1pYPBaUxOEryCIGbaX5x5wMxsMiqAU63SHh5nXRxNSWh O6hkhzAl2V9Y+XXKzzh2bINKvVvBeLPFVyp0wqy8tWZ+ZWWAo/QinJkYSou/DYPThe9J3oRLo9b 7TkKrBdYVZCHLnd6YDc60eu70ntdIByNrm4U+WPLqcShsTGaT72JnVNflc3tcDPYg3YHjPwc3/W Q6v5TSYKXZVfCBmZuCeTfapnQFqHFxM/a88L3Fx0dNCWhk3x6Q0B3L5ofAIG/OyS8Y5SyajrsYD fnDWmLl9iiKioxegeNV7fGjJ2YhAFL9d7pjDt8QmPDrVlH++LaUtoGzB2yRNI1Oo4= X-Received: by 2002:a05:7022:608e:b0:11a:61df:252a with SMTP id a92af1059eb24-1276acda11dmr3017797c88.6.1771796360879; Sun, 22 Feb 2026 13:39:20 -0800 (PST) Received: from google.com ([2a00:79e0:2ebe:8:c6c:6cca:170e:c77b]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1276af8c936sm6588341c88.14.2026.02.22.13.39.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Feb 2026 13:39:20 -0800 (PST) Date: Sun, 22 Feb 2026 13:39:17 -0800 From: Dmitry Torokhov To: Jonathan Cameron Cc: David Lechner , Nuno =?utf-8?B?U8Oh?= , Andy Shevchenko , Linus Walleij , Bartosz Golaszewski , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH v2 4/4] iio: adc: ti-ads7950: complete conversion to using managed resources Message-ID: References: <20260219022929.3558081-1-dmitry.torokhov@gmail.com> <20260219022929.3558081-5-dmitry.torokhov@gmail.com> <20260222140923.10bd9b7a@jic23-huawei> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260222140923.10bd9b7a@jic23-huawei> On Sun, Feb 22, 2026 at 02:09:23PM +0000, Jonathan Cameron wrote: > On Wed, 18 Feb 2026 18:29:28 -0800 > Dmitry Torokhov wrote: > > > All resources that the driver needs have managed API now. Switch to > > using them to make code clearer and drop ti_ads7950_remove(). > > > > Signed-off-by: Dmitry Torokhov > > Hi Dmitry > > One additional comment from me. > > > static int ti_ads7950_probe(struct spi_device *spi) > > { > > > indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*st)); > > @@ -598,36 +605,36 @@ static int ti_ads7950_probe(struct spi_device *spi) > > mutex_init(&st->slock); > > > > st->reg = devm_regulator_get(&spi->dev, "vref"); > > - if (IS_ERR(st->reg)) { > > - ret = dev_err_probe(&spi->dev, PTR_ERR(st->reg), > > + error = PTR_ERR_OR_ZERO(st->reg); > > To me this reads worse than original IS_ERR() / PTR_ERR() pair. OK, I'll keep that in mind. It is no longer there anyways after converting to devm_regulator_get_enable_read_voltage() that David suggested. Thanks. -- Dmitry