From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: "Nuno Sá" <nuno.sa@analog.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
"David Lechner" <dlechner@baylibre.com>,
"Andy Shevchenko" <andy@kernel.org>
Subject: Re: [PATCH v2 1/1] iio: core: Simplify IIO core managed APIs
Date: Sun, 22 Feb 2026 21:07:10 +0200 [thread overview]
Message-ID: <aZtT3pDS9X6pGVnT@smile.fi.intel.com> (raw)
In-Reply-To: <20260222165411.427e6a9c@jic23-huawei>
On Sun, Feb 22, 2026 at 04:54:11PM +0000, Jonathan Cameron wrote:
> On Fri, 20 Feb 2026 14:25:19 +0100
> Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
>
> > Use devm_add_action_or_reset() instead of devres_alloc() and
> > devres_add(), which works the same. This will simplify the
> > code. There is no functional changes.
> >
> > While at it, inline devm_iio_kfifo_allocate() into its only user.
> >
> > Reviewed-by: Nuno Sá <nuno.sa@analog.com>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Nice. Applied
Thanks!
One minor thing though. The iio_kfifo_alloc()/free() uses variable name 'r'
while devm_iio_kfifo_alloc() uses 'buffer'. I was thinking again and now
I probably would go with 'buffer' in devm_iio_kfifo_release() as well
to have a symmetry with the devm_*_alloc(). If you think it worth changing,
may you fold it? (AFAIU the applied patch is still in the pending/testing
queue that is okay for rebase, squash, et cetera.)
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-02-22 19:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-20 13:25 [PATCH v2 1/1] iio: core: Simplify IIO core managed APIs Andy Shevchenko
2026-02-22 16:54 ` Jonathan Cameron
2026-02-22 19:07 ` Andy Shevchenko [this message]
2026-02-23 21:00 ` Jonathan Cameron
2026-02-24 9:17 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZtT3pDS9X6pGVnT@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox