From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA44842A96 for ; Sun, 22 Feb 2026 22:18:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771798707; cv=none; b=seXwHOhD22ao5baZiT3PS+XFSwXTDo8iCLuD7hTXxCELRmw/F57xQL7la2ZWfIhjIMpR/s9RdibtGdSWW/x5b0PXevrvhdg6VbUnWTjgE2vTdXM94neYJTeq31oYX7Pt1YjQZH7fzhrvUaDLiLuq6C8DydhLcyObC8LmU4omGAk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771798707; c=relaxed/simple; bh=dNILPZtJXme7gFNDrLJYRrBFIWDyamblBRN+r/OZOvM=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rpBQdovcNZpsnZhsMt1582IfWqwqda2/Cv/ZtIh/8bss1/XqhON4XfD/GvqQKsBLPc657FWtWNq3PGWXVICziDjvuJFgzvaPnWxcCtEeNAQjRnSA43L/8a64ArEH9fsA7Nt4Awt5bXQcRZR2A4Ha48558pwe7sMzpy0n8/LWOvg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BR2+TOQu; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BR2+TOQu" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-48371119eacso42394545e9.2 for ; Sun, 22 Feb 2026 14:18:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771798704; x=1772403504; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=/d2EEaoaANoFCXVulitR21x938DiZzyh+0j1o5c+nxo=; b=BR2+TOQuQuosUOwWGynjfkC8ESSF3UFf0SGr5bgJ9/3n9ELjvWsHDV5otiS/SJaZyP R7cpVUcoYK1SDbO7Tdd37acvMqNRC0+2NyG6+dgUh7VRapk5XsDAmKjKBERf67usSJy4 u7q9W0ZmkHb3cbRvyJjRB29f6lFHgtzAQI/Z4siZZ6FkgpDMvo0EB0J/LD1FpkKzvBMN YDFi0fmjhxs8JnkFwFhRyYyifsrqnMhMYyoiBpsU5kS3oUxbEZHt5XiXztb/vN7Pdk1R SncSa7A4DscuvSlADWxVhDnx5dVzY9LLXd3SKemfUVivDlQLsl/CF/9S6QdAdb7QUX7V tm5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771798704; x=1772403504; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/d2EEaoaANoFCXVulitR21x938DiZzyh+0j1o5c+nxo=; b=TQ+VFeQGpS+uf7dr3medWSSx1hGDxpCA1MsbGJO0wUkoCBXtxRCGoPVFnwF1SOhMS+ ZHboFvBhXgjeUJEOHtuQm5qhB5Djp+6oZhQu0mJwxv/ZoixsFmr9Rw8icL7dD6HIwz5P 2+9KtFWzXcj2sBptKUYQjNTIaOShCJ+VSwcxIjCVMC/5kJTUOup9ACsKvDCoxGRkcSDC QGCCMU7LTWK8WZKdR/eNaLh/ghXCSZkCM1k1MJEDM0S6cV6ribzbteIfEHjKk1yBZlbt SDLMmOiiFxGWeOwEcylKfaTqcyC+FUQm0wwPXHWrAJeoSEKWEqeWdoqTCKt0CRKeWG9m 1VOw== X-Forwarded-Encrypted: i=1; AJvYcCXosBoPKVCo6UdEVmLAR0L7AM/lgHgp85PTh/Muyt2+AmjgR5cwOQixxovy7yVwR8ICXsTgDlUK8Cm6rPk=@vger.kernel.org X-Gm-Message-State: AOJu0YydT4ZDYBzR2Tb3d/jRt4QfPqmkODRz08eCqFFCQJfoHFAK/o2e CxM+Lqk50hiUHGe/RG3rd8u2DxmkpKf06IGxuaz0ie2DIkpZeuBcfXXk X-Gm-Gg: AZuq6aI4BW7Ie98myaF1/Fs8NpRCiFvTaYcqL2T6u5f4WdcTFFKOYbPjot40cKSNaaH CLDxA4mKmp41gLUH2hHBrmLRcnO4L0s6WSFeX8/J5WQIbSdNC9jz0Qg0jbOzm0xXXXn8UY3MppF ey28qHgo89XX+ib9A1BbDdMZQgYI0w+u93sQqeb17B1CNKsRo8z2gjR690kaQdp13husTYU56tw ZNTah176Qzso74XV67IETDGBmGro9P+5gsFfVtzZD/tWIqc5YQrU7ccqJqMHsJuAIgElLhohLGJ LLjxHs0NC0X7AXwt1IV5YhYntglJVhvu/by7eJXbfyGH9CWccIIjx8l3jc55yi2oeNou+Nl7iAP DdbML7dhibUIMl8d61duI3aTvnrWEI2GmQQ/u6XsFq4F84tfzB6yq2ORAYmJMbQVva7E5t32s3Q WOwmgPGVLUBJCvgF7g9jma8A== X-Received: by 2002:a05:600c:5020:b0:483:71f7:2767 with SMTP id 5b1f17b1804b1-483a95fc0a9mr121520455e9.11.1771798703917; Sun, 22 Feb 2026 14:18:23 -0800 (PST) Received: from krava ([176.74.159.170]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483a42f8027sm72575795e9.24.2026.02.22.14.18.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Feb 2026 14:18:23 -0800 (PST) From: Jiri Olsa X-Google-Original-From: Jiri Olsa Date: Sun, 22 Feb 2026 23:18:21 +0100 To: Ihor Solodrai Cc: Alexei Starovoitov , Andrii Nakryiko , Daniel Borkmann , Eduard Zingerman , Jiri Olsa , Mykyta Yatsenko , Amery Hung , bpf@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, Alexis =?iso-8859-1?Q?Lothor=E9?= Subject: Re: [PATCH bpf v2 09/15] selftests/bpf: Fix double thread join in uprobe_multi_testg Message-ID: References: <20260218003041.1156774-1-ihor.solodrai@linux.dev> <20260218003041.1156774-10-ihor.solodrai@linux.dev> <53f7ac2f-3e7f-485e-ae46-040518ee7610@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53f7ac2f-3e7f-485e-ae46-040518ee7610@linux.dev> On Wed, Feb 18, 2026 at 09:54:41AM -0800, Ihor Solodrai wrote: > On 2/17/26 4:30 PM, Ihor Solodrai wrote: > > ASAN reported a "joining already joined thread" error. The > > release_child() may be called multiple times for the same struct > > child. > > > > Fix with a memset(0) call at the end of release_child(). > > > > Acked-by: Mykyta Yatsenko > > Acked-by: Jiri Olsa > > Signed-off-by: Ihor Solodrai > > --- > > tools/testing/selftests/bpf/prog_tests/uprobe_multi_test.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/tools/testing/selftests/bpf/prog_tests/uprobe_multi_test.c b/tools/testing/selftests/bpf/prog_tests/uprobe_multi_test.c > > index 2ee17ef1dae2..be6ff1d4a75b 100644 > > --- a/tools/testing/selftests/bpf/prog_tests/uprobe_multi_test.c > > +++ b/tools/testing/selftests/bpf/prog_tests/uprobe_multi_test.c > > @@ -68,6 +68,7 @@ static void release_child(struct child *child) > > close(child->c2p[1]); > > if (child->pid > 0) > > waitpid(child->pid, &child_status, 0); > > + memset(child, 0, sizeof(*child)); > > The CI is failing because of this change. it's on that child->pid,child->tid check in uprobe_multi_test_run? > > Apparently, there are asserts on child object after it's released in > kick_child(), so we can't just memset it (without changing the test > logic). The previous version of the fix [1], resetting only > child->thread, is more appropriate I think. > > I missed this because uprobe_multi is in DENYLIST.asan > > I'll wait a bit in case there is more feedback and send a v3. I think we should somehow separate the thread logic from the child to make the test more clear.. I'll take a look for now zero-ing the thread, so there's no double join makes sense to me thanks, jirka > > [1] https://lore.kernel.org/bpf/20260212011356.3266753-10-ihor.solodrai@linux.dev/ > > > } > > > > static void kick_child(struct child *child) > >