From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f179.google.com (mail-dy1-f179.google.com [74.125.82.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F6833385A3 for ; Mon, 23 Feb 2026 03:49:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771818599; cv=none; b=rgNKXZ55S7w5WiAUl9N7oztf5C1a4GbC9dPd5uADSbk6eIFhrg+xM54ZRzQ7zLIgBWTaDq3XMVS5CTCgTQMQiBSTeFphvYN9E2T/yX/yhydaSOI/KqGl5suguiunmyt4sqaq+SqOkTAPXrhU9LLQa608x5Sddgc1z9UAOBTOAAU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771818599; c=relaxed/simple; bh=DH3MlKBo8OepM5KCx3hb0qCHe0GY1i5bgyS+qzKnpUc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EnpNkoPXXwUqAHgL/ntLH6pBGBQ6wsrd84FADRD41CumRYNykSctcyUelZw15//N12skY8orXqE8cUnjVRbbqAeQrqxl5gdGGie3M2J+4v0OUTAnqwo1GVSR2WrXKt3QjR8bAGvgQW5jEP61LvblirEDzCUVWhd9SLLQ0IKb2GQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XhBdKzVb; arc=none smtp.client-ip=74.125.82.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XhBdKzVb" Received: by mail-dy1-f179.google.com with SMTP id 5a478bee46e88-2bd3b0bc201so2219931eec.1 for ; Sun, 22 Feb 2026 19:49:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771818597; x=1772423397; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=yPs2RWVwVls5m0dIdxfZah4HJgj117r2pISP+fJO5+A=; b=XhBdKzVb8RfZNb4ISWxOPndA1hvC2IEPnT3X0kDIzcn1CGyKk/mR9I8rN90dgGfDgK ANPfavnebyw5xkspTcHJPYw69Eiq8YGGFwJe6oZ98C4ve1xAcJN9eqc/q6iYsOmh6ZZm /kEDjMRwkq/v9NuROB++sEItNga5+zE9IOxxIELosSsohicaGR2c5DwTMfapYdcX3Npl qwgq1C8gWqV7Yrgn5uOQI1mDYfM/tF45OxOOz+s4v5Gtm7HOvwDwAvuFHDUV+MKhrosE oepTUlNwJko1SuCky52k5D9Hgs2ESJYsp8ensiTyR5QVGYRbX1sM4sVygaTraYkm+fXt B50g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771818597; x=1772423397; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yPs2RWVwVls5m0dIdxfZah4HJgj117r2pISP+fJO5+A=; b=Dyee86WZUqniqgmIezKPqCGHgtMJBI1+Pko4krFEzKWnjMcHBdEgd67wUoNGpGL+eG lIaHQGS6kFSfRWiqXWwz1beNwfWmRkk/M6wCZg8pvKhziI3Mhezj3Xil5onRznK3nD17 GGlwgS63tzlr38d8ZOKAolzDxRjpVQ6Lxencq2AEKmAj+X66Qo/3d63FNgStIkl+lTYj sXVIZ07KT4UNB4bXrCPjtuxxVmhz1Wbbsxnu/yfY5fr/anE4JnDeYPqnDV22iZ+GKwA3 ADuhIOKUab47RuBEefDJwpS7NpMwYrTQSHv1W00DL72rkhbnlBpnt6PoFpeu11zJApQ+ mR7A== X-Forwarded-Encrypted: i=1; AJvYcCX7fgmQ04I+OcEIA705fBqNdw2xMbCGL0syUC1/Ka2zQvWD6XVISHNdmBpLYAWOkRSKxErKSyHsvIKheTs=@vger.kernel.org X-Gm-Message-State: AOJu0Ywddc+At9AFG1DMfn8Bib94/Kp45ld+UFU+ypY5Io3T0qKPPlMR GJ+MLuj9QFEj29rjLn7gxFEqNMpd2FlXTIlYvwke/BwHhcYTDsXEBxsb X-Gm-Gg: ATEYQzzKPJRSLDEo1IZwR8bjEQcIdN6xxKqJbbXpK+e9JW7tlBK9ST7n75A553Qg98x R5pzYuKkRBxSwDcoQ7kVzw/vJwmBGrVR6Cr765jV2hZrGsxEhyNTYYs6vxtMVeJc6fcNJwQTi5F 7c3AvhW9MjvxjZixkybP8R7ZMjOcmwgJj5TZQInZkko14mum1qA8ReLMoO2RWmZ2kvMe6qINala W2U3ZurMtval2KYsbpxn+AFXmbdYhkvvt5Ttyv1R5O4/uCeu1RIx2fqsOw8hIKmJq9jHkPRAg00 epJCWP+74sclo8U7OjcPY3dFDjO8LXxznSXSrvlonYjiMaH7isKlZFab704kfr3GTYEdaCFm+B7 OOfr80skSbT/nnogU0+n84LswJrKLfUevFjTDsaIvp9C+mpkMM7f8qLLxrM8TTrvdUDMdIBTFiN OUjK4/DBkOHPitdkawU4ebT0i3kG7VLBMVhF1wpy0jwbowiPGevW/64KkBd91E29k= X-Received: by 2002:a05:7300:2327:b0:2ba:7dfa:c81c with SMTP id 5a478bee46e88-2bd7bd3b0femr3958909eec.30.1771818597325; Sun, 22 Feb 2026 19:49:57 -0800 (PST) Received: from google.com ([2a00:79e0:2ebe:8:c6c:6cca:170e:c77b]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2bd7daa3d77sm4068344eec.13.2026.02.22.19.49.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Feb 2026 19:49:57 -0800 (PST) Date: Sun, 22 Feb 2026 19:49:54 -0800 From: Dmitry Torokhov To: Tzung-Bi Shih Cc: Fabio Baltieri , Benson Leung , Guenter Roeck , Simon Glass , linux-input@vger.kernel.org, chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/7] Input: cros_ec_keyb - simplify cros_ec_keyb_work() Message-ID: References: <20260222003717.471977-1-dmitry.torokhov@gmail.com> <20260222003717.471977-5-dmitry.torokhov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sun, Feb 22, 2026 at 06:47:46PM +0800, Tzung-Bi Shih wrote: > On Sat, Feb 21, 2026 at 04:37:13PM -0800, Dmitry Torokhov wrote: > > @@ -376,12 +378,10 @@ static int cros_ec_keyb_work(struct notifier_block *nb, > > pm_wakeup_event(ckdev->dev, 0); > > > > if (ckdev->ec->event_data.event_type == EC_MKBP_EVENT_BUTTON) { > > This can also be simplified: `event_data->event_type`. Indeed, will update. Thanks. -- Dmitry