From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f177.google.com (mail-dy1-f177.google.com [74.125.82.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CFFFA1B3B19 for ; Mon, 23 Feb 2026 03:51:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771818675; cv=none; b=kcP2NSs7j12Q9XdLVRubghvEs4n3dk1S3StxvgnsRAmja2SDqgzmeWgAqaP+bb36/T7r5lNvTT498QVMQPv7O8+pX2itXNH+VM7jSO676Wg1qGMSp3eUoAYh+25YxQ+G5DWr2nYQORKLap26myLJhmP7lpzr4Rj64VnEmpKFFzo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771818675; c=relaxed/simple; bh=9TBG4KJWUkto8xndWZTre4mHkMZaycGfjsH3VaLQrFs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=njMww9m9zQoUFWqOfp2bYBa3feh5eUb9klgLoMD9KQ/aAgv2Y1QsKSw8NpOyhHA2odXamfTm6H0hSjP2U8pwHMRENA7IZr53BYGN7rb5xKsa+d8OXDMyPa8l1FOphd8f226L820xn8kdrikjEqSK0ZkOk/LHvl/LHMMC0TeLLl0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GGPVp14s; arc=none smtp.client-ip=74.125.82.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GGPVp14s" Received: by mail-dy1-f177.google.com with SMTP id 5a478bee46e88-2baa6ec5638so1637581eec.0 for ; Sun, 22 Feb 2026 19:51:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771818674; x=1772423474; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=YXpc3Kmvnut3VwP6NNidiPJA7ThQhlqteukIsGvSTQ0=; b=GGPVp14sza6574sp/SnkeVJbLQ//5wVCIVVkmbvG7hxPU93BusFi2Ms7xQt8tKyoXo PKHKh7rUpPIUUTFfKvvHaZ/qZCykL0KLW7LNBnrD9Jr5rKbHeIhhiGhL2MPd3PD9igFY dSvnskSqG/aiUlXdgs63aPYQoZ1LUuE0MZ3Vfo7/cG+BWJI1CCF5jP3YAgD/+DDaalo7 QIE445azzymQMaduPVROjCqMEjjWw1CdVfDF66pUu1Mgy7+tspiOpe2HVkUPp8OAJpUn kFsSnTfignMUFfj7FtluSvwcM2150wZD/8NXSRE4UmRiGvzL6z6vwPv2lAaNOdU3Barc NyGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771818674; x=1772423474; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YXpc3Kmvnut3VwP6NNidiPJA7ThQhlqteukIsGvSTQ0=; b=MGZQkeR734Dlg7Le8Gp+OqpWFzxxFk8oxFbNrU4jRE1punuFzaEnymPj1Jv/rOFh/R LXAQ3pjJ4IYIUDa/kM1fpuFCmW8zqLH0/8rhQFFZ7s3JytMffKqHajs2p+HzYPg0lcZW dax/8nVEgSyPdvs7aHhW6qI9GKSc22gE3VWcBSUVIKeT/IQKGp5jcuxWSzje2Mq4h1Na 9l2VXiOJKufg9BLlPPQyM/WpHPviwEjQValr6p/IyYTdb3YK/PjTYozZSWzuXckjhcsQ qmrfwBN//KLWq7NcoCzgEg5n5wL53HSFXQIqL04ENBh/AVaIv5dcBCFGlllFZney4aFo qseA== X-Forwarded-Encrypted: i=1; AJvYcCUD9MUb5NOC8LFsd9RAnItVHco4uR3OQ3oWbV8eBW816lYAFLDZQzqoigcCSvwcAfC4qGTWhSgQYR0TNvs=@vger.kernel.org X-Gm-Message-State: AOJu0Yxoq2qb5K8LRMuwvW/OssIv+nZPO3WAeBHVaj5aoSLEz7BFbu7X yioPiGwLv6qHbi9SB3R5/yE6XjcAqUXTrQ7Hfxin+LKlbw9AP8xAdx/V X-Gm-Gg: AZuq6aK3g2vU30iEmll4rL74z7oLqKQg6fkYB2Uq2rlwcdT3LWd7TSrcJeTwKOQM4cZ bRe0PBcD92oDlQrcsAhpunP1H1shiWesF+3sQ7JUg/OvysSsLbLgS3GQcluDhUQib3/ZIw+PQQ3 UpNeuw3rqI/UQ2KO6c3OHBu9v41aApCiH1e2OpIaIygZyQXYj3M+wZ6xKXVpxhVw/HWaxkBh4iE /7zEy2UN2lAdXLCNKfq00UuZxk+avZdd+YrN0FOi+BSd5PP/FJbDnbmB8kXti0969Q0Klr7u8Tu QoRN1y3ZHXUV/uS8UVFJZfEuhgnn2Iqttp/6TFLI96u7bKmrPJ9XuR8LDarvj8xr9o+IOpxxLf4 +l0DfHVfZygKAuJqlHRFvFwGrJxb+eygkBCcpG+n7spB54+mh2NmxKhUFx9+Bu7YU2gACYfeUBK tg9euB0FfDrVF+qsbiUmzk2nAt1kQ+JtnteWumEOQM3iFWWRt21xayPsUgk4Ijeik= X-Received: by 2002:a05:693c:3618:b0:2b6:f13c:8d58 with SMTP id 5a478bee46e88-2bd608405f2mr5499375eec.20.1771818673826; Sun, 22 Feb 2026 19:51:13 -0800 (PST) Received: from google.com ([2a00:79e0:2ebe:8:c6c:6cca:170e:c77b]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2bd7da3eefasm4173867eec.5.2026.02.22.19.51.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Feb 2026 19:51:13 -0800 (PST) Date: Sun, 22 Feb 2026 19:51:10 -0800 From: Dmitry Torokhov To: Tzung-Bi Shih Cc: Fabio Baltieri , Benson Leung , Guenter Roeck , Simon Glass , linux-input@vger.kernel.org, chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 7/7] Input: cros_ec_keyb - factor out column processing Message-ID: References: <20260222003717.471977-1-dmitry.torokhov@gmail.com> <20260222003717.471977-7-dmitry.torokhov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sun, Feb 22, 2026 at 06:48:18PM +0800, Tzung-Bi Shih wrote: > On Sat, Feb 21, 2026 at 04:37:15PM -0800, Dmitry Torokhov wrote: > > +static void cros_ec_keyy_process_col(struct cros_ec_keyb *ckdev, int col, > > + u8 col_state, u8 changed) > > What does the second 'y' of keyy stand for? It was supposed to be "keyb", I'll fix it before applying. > > > +{ > > + for (int row = 0; row < ckdev->rows; row++) { > > + if (changed & BIT(row)) { > > Maybe > > if ((changed & BIT(row)) == 0) > continue; > or > if (~changed & BIT(row)) > continue; > or > if (!test_bit(row, &changed)) > continue; > > to save an indent level. I do not think indent is too deep here so we can't spare one level... Thanks. -- Dmitry