From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f52.google.com (mail-dl1-f52.google.com [74.125.82.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CEB21B3B19 for ; Mon, 23 Feb 2026 03:54:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771818879; cv=none; b=ie4xGXINdwyZZpw7qfzvi2RJ2sYw+73qPo3816eP1I6OSK6UUj+s1vS0LeWc4mwWKH74SjEDasTRgve1ZdDn+0i6PPryH0+X/JGpGntFWjlXHGNIgHcqiKyYPJ/9TlsW9cGK2DgwsrcM3h6qYF+m8enF5AlugIiB7sOQODNSryc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771818879; c=relaxed/simple; bh=DL/O85xB+imBUpPglQSS6Wj5oesIn23PeIjvILrTVaY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=puTQdZJRvX22vgY9ahP+sn2eTNGBlXke8i1IKw6/SS/QIWOv7RwRvNZox4SiJuhT2w020Tj3V50OlJ9O2d914B4Z3PFPOBJqVuCDBZKFnqaDyyWWP81s3l+jaAinv61t+aeSYmuWhFPcTqnN/wv+lX5n4Q8EEbctCJisJU8BuLU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GPWvVOgO; arc=none smtp.client-ip=74.125.82.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GPWvVOgO" Received: by mail-dl1-f52.google.com with SMTP id a92af1059eb24-12776bebe9fso55247c88.1 for ; Sun, 22 Feb 2026 19:54:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771818877; x=1772423677; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=9qPPGc8+eZXSIn5RBSIe71t3+20AlyQ271j9hhpmbm8=; b=GPWvVOgO2npbLaAwuD7ldosPCMJJoEKVACmnMTLGPjqYIdPFo5uU+pOBNM331M4eVm 8rrtn+hjfdg5AxGswyB+M3q6MPAaPwKQoLam0oJnBjFwuJivUOoaGv3Z5swBOQCQguEF GdH8BcFtdWRWtzn5P7Yya/vpfRRzNMliTJiesVVDpx5nMP6oLg9HQlcAW1MZNV/9LrJl BWGaGLCJMATXEmnS7J4H/EY9ddmnM5NwbNfOVgtGw0HF/+z/VdfmoUe2Knn3U0WyZs0D QtVMbil9wgCPNORBaDt/45axydKg6xejB113RbC2N0ts7w2b5EmL0p3oVDulp/JivTh6 VDrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771818877; x=1772423677; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9qPPGc8+eZXSIn5RBSIe71t3+20AlyQ271j9hhpmbm8=; b=nUQjJztfqdGvCc0cqD36bk5rmItyaleORQi3BCN9oVvEDxZNEBhmZHkL3TlsTmWKRb LQtPkrGarTnT3mdQNKcNuv7lH7L3cn2H9F3QExN8lWLkoVg8W7eHwoIHYfNA3WssPEIr 9LEU+l417LF6EXpyhRns+9M7kSkBCYJJPW70IaN9g/Et8U+fleejT3zm1lb6ckLOIjea M02Ck9Bvgb9fhUaFtMhxgTb+8DuuN1Riz7dDt81EtUrm/7XNk/yNdVmFLQPdBLyMiexF NtltSjrkpjF8occ1ZWDngp8O5Y2+0v/Oz17d5RT/1lcnMumD5vOOB9ShC5iBlW9AjqNP G9Cg== X-Forwarded-Encrypted: i=1; AJvYcCVIcVCOTozt8lGhPzO7v8IdaJtbdhKIVYey1t4OnZ58LC86A2VTOmYlD/tepbI96/gZdhfIQIK48+Qy7A4=@vger.kernel.org X-Gm-Message-State: AOJu0YxGBWhsHYGRStgVDSxsWx0ZlZ0U1vdQsa1c9v8KPB3hLg+Mgu2G 5BaVWVJWHJ/uMN+U7OXlArxbAP5n+p/CIhz4z08KkZSzyY2KLjeXcNozw/OQyA== X-Gm-Gg: ATEYQzx70tAKASaXsLSNagBsIf04+D73HUpuJ6GnC0BNMbf8nNstFR8t6mzM4M3gBc/ t+LID6BtrG/TaQ9dvbEW05uS2lAs4B54Gbqsah2CkQtPi3V/eTx3IABdc6mCoPQStc0AfKswrQ+ drXnx864j38T6Oi1EOYZ7xKYwKyUXBETeuyCLOTczpAW5tgDMjUluam/lUkGfFkbLrpRP5kshDB EEEvJClGBfpHh7QQsdvxJnQRqnxNAO9cdwzNdL8Z8Q6fVsapaWQyCLlazb3GrNx42jdobvV0ktf oROytMHVYFFIo/s72n8PbvEenSqA1m/ynt8qobP3gpbCAB8qagww7DhkNlejrmXwixwn1Zym/M0 SazA6ICJXw6g6H/fuIqj5WP9YowfCMiYz6tc74yJdOh9QyA2dhedPMm2actLFRBKEEGTd8ofi8Y GeCL3fnHGjbH9Xrr/NjPH2793MruoxZqeWPo1E0v/i3AFAxdTFtjFgkvvwqQsJv3k= X-Received: by 2002:a05:7300:ac90:b0:2b8:5159:eca5 with SMTP id 5a478bee46e88-2bd7bc71d7amr3018015eec.14.1771818877478; Sun, 22 Feb 2026 19:54:37 -0800 (PST) Received: from google.com ([2a00:79e0:2ebe:8:c6c:6cca:170e:c77b]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2bd7dbe82d3sm4446364eec.21.2026.02.22.19.54.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Feb 2026 19:54:36 -0800 (PST) Date: Sun, 22 Feb 2026 19:54:33 -0800 From: Dmitry Torokhov To: Rudraksha Gupta Cc: Konrad Dybcio , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, beomho.seo@samsung.com, jcsing.lee@samsung.com, linux-input@vger.kernel.org, nick.reitemeyer@web.de Subject: Re: [PATCH] ARM: dts: qcom: msm8960: expressatt: Add coreriver,tc360-touchkey Message-ID: References: <20251205-expressatt-touchkey-v1-1-1444b927c9f3@gmail.com> <532531d2-8f26-4ffa-9355-7821a4d64200@oss.qualcomm.com> <1e74b956-a45a-4d3e-b7fa-e4d5dc0390db@gmail.com> <97d9d942-236c-4f8a-902e-0ad2ab684a76@oss.qualcomm.com> <1ebc2e1b-f1aa-4559-90a0-feb628d5bfe1@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1ebc2e1b-f1aa-4559-90a0-feb628d5bfe1@gmail.com> Hi Rudraksha, On Thu, Feb 19, 2026 at 08:33:43PM -0800, Rudraksha Gupta wrote: > Hello all, > > > Top posting for once (context below). > > Not too sure what the next steps are to get the tm2 touchkey in. Should I > resend the patch, contact someone else that can help provide guidance, or > something else? > > > Adding Dmitry Torokhov (official maintainer) and Nick Reitemeyer (person who > introduced this variant). Sorry, I am not sure what the question is... It seems that you made the driver work without any additional changes? > > > Thanks, > > Rudraksha > > > On 12/16/25 04:59, Konrad Dybcio wrote: > > On 12/9/25 8:10 AM, Rudraksha Gupta wrote: > > > > > Add the tc360 touchkey. It's unknown if this is the actual model of the > > > > > touchkey, as downstream doesn't mention a variant, but this works. > > > > > > > > > > Link: > > > > > https://github.com/LineageOS/android_kernel_samsung_d2/blob/stable/cm-12.0-YNG4N/drivers/input/keyboard/cypress_touchkey_236/Makefile#L5 > > > > This driver mentions a register called CYPRESS_MODULE_VER - maybe > > > > it could help confirm the model? > > > > > > > > Konrad > > [...] > > > > > When run on mainline, this is what was outputted: > > > > > > samsung-expressatt:~$ cat /sys/bus/i2c/devices/0-0020/module_version > > > 0x06 > > > samsung-expressatt:~$ cat /sys/bus/i2c/devices/0-0020/fw_version > > > 0x09 > > > > > > > > > fw_version matches downstream ClockworkMod Recovery dmesg: > > > > > > ~ # dmesg | grep "FW Ver" > > > <3>[    2.201312] cypress_touchkey 16-0020: Touchkey FW Version: 0x09 > > > <3>[    2.206317] cypress_touchkey 16-0020: Touchkey FW Version: 0x09, system_rev: 8 > > > > > > > > > Unfortunately, I'm not to sure what the other variant versions are, so I will CC the driver's maintainers: > > > > > > MODULE_AUTHOR("Beomho Seo "); > > > MODULE_AUTHOR("Jaechul Lee "); > > Sounds like the best idea, I have no clue either > > > > Konrad > > -- Dmitry