From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f41.google.com (mail-dl1-f41.google.com [74.125.82.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 21DC97080D for ; Mon, 23 Feb 2026 04:57:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771822677; cv=none; b=bd+WxJNpGUDl+E1yqJkV+0XVvjFEyPqhki2/TyMxt4CeC/Upj850aaQttTxryxz3tPKnkd1RZWDlJm0k19qHpP4CosCysATVVBXxsfN15cKtf+s0DaxvY8cdyzxQsiEIwMIDZtExjTl8pzb9sOJZM1r1yOpRZjkPjMSBCnYXkZI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771822677; c=relaxed/simple; bh=1+fj/osOFOTUhi6//cNsWxgUvEAAcYmf9baAm1ts5cY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=g+bimBoSU4rsZgNdN9YhriFkK47ST+1RjHbHacixNHcBqZkfuROyJTnZgm1OSjA8wHodaUBqpPEOPnBF/H5+1Uz30OMdIBBBos8nNlERgfBP8CqooJnMLCkwvne1rblQzC2CtEo+GJiuX/61pkLK4hCB9DBLyo8ln+BkksTC7TM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SKCKqHKN; arc=none smtp.client-ip=74.125.82.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SKCKqHKN" Received: by mail-dl1-f41.google.com with SMTP id a92af1059eb24-1274204434bso3252537c88.1 for ; Sun, 22 Feb 2026 20:57:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771822675; x=1772427475; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ZoD6tE+yirYO2wDnJyh3VhePC5QLfqyFQbq0eMsMM6o=; b=SKCKqHKNcvrisaNOx+xrUeJZW3r4vvf+FJEl/sWKdeIWhyGxvzHy8BJW8UL1qeeF0P XrQK2POy3PeNqnEXJTCBduCWG8nKuSauqBu4uCKFUVjvn3zOhwkLCiG4EnNpmGH6EhE9 5fOh8uGhU/iGiedONOPvgEN3pmgX5mLRP2WXe22W2Qjot65JGLRGWshf6okRQhyPFsCo TLrDTloQXH3Pk7wWEJs/4IhDy9+4iyv0JrONaTwMgxguIL6JgbQGJO4tnam4B90qbCns deoC5Zud2h4Z/MhIIjkDKdEoz0Djbda36SOcNbPCJi6W/N7qQ7sTds3tdkq0FvcdikrL rZmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771822675; x=1772427475; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZoD6tE+yirYO2wDnJyh3VhePC5QLfqyFQbq0eMsMM6o=; b=OSKBMt+qGUB1heZI2wMoTIlzYzmBgh/2MZflqsijYkXpbyWyPNO+v2h3tpW1EXSikN C9ZHchvn+HDk4iNyGQ+ZP9M44mGgcp3Nv40hJSNXbxcbYGAaBEBMaprrV7JL6WSu3skn go3Y/2q6vIM6uaM40E/Y+UGVJaI7TmOkXWrnXJIQcbksOfIrB21zaFHyBGLaQoEQyci5 +luMifNJuidyx4moqVFnXqT4JwGSuqogD0s8T5fVP7xuk+tyjxTp/F0VdyEHk56G/8rb l2ViE0dfTgKTWiN4u3Em0OjrzLISo/64PFA/45Y0P/OpF9jc5f12cq9WAuUiu+xCyQyl ohww== X-Forwarded-Encrypted: i=1; AJvYcCXdYxp1kFzW9KWqaNpbmGABy+sPGf5EerFT4oI7YpQWNJaV1l1bI1373I7krAm6vTojxk819zEEk7SjjDU=@vger.kernel.org X-Gm-Message-State: AOJu0YxKpvWQeMjia2mxLLeCwW04o6j2PXkD6Nbr1obO1ugRrigndMtw xnL7lqgVnug/eZHRO3nsnwaueTuBbp3Gguy8jY9GYvQPnCMdAyf1LC7x X-Gm-Gg: AZuq6aJOYo6KWCJRWZ2n4ttBUsIzlkMKSDyXnmuO2yBzCdVoehnhKHmJ7uvjJHpbn7f w3PXvFYdFA6kSEh/8fVznC8ttELaAiC/vgIEWP5ktHA7PJqv3rtTS2TFD7xbzbmQKHs+L5QZ43n /0LAK7qRhukmJIEhKR/YWlm5cqowiCI12olHrOKjhF67L2hmd+gpz/61PSGzgSpQeEgO+Vmi31N v8iEfZTVSF4F1BzvDNYM4VfIy9Am0UMQDyrZ4poamKTwpthi0n1P5NEfLRrCDREsdhjhTVP3eWZ 48P146Q6GtxdlkDE0MWgjEkJNV1zQyGRQ5vMb6jwvXsksl0eJEK1pYFVgFkmq/u17FnEHcrS9Z6 hNdfontwTFGsrZk2881BBKZApOnbe48XB7vHoHvP4zJfvF/dp6gQBjiOIzoIuttdr627ZkhtGOr acr4P6NkYv9DgnrE1LhK05eqoo7kQhpCBkCaogDuMsHEnW2wUAtp9YHxOLZQJRiXU= X-Received: by 2002:a05:7022:48c:b0:11b:f271:835a with SMTP id a92af1059eb24-1275fa41703mr6770004c88.3.1771822675098; Sun, 22 Feb 2026 20:57:55 -0800 (PST) Received: from google.com ([2a00:79e0:2ebe:8:c6c:6cca:170e:c77b]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1276af2ea06sm8045507c88.7.2026.02.22.20.57.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Feb 2026 20:57:54 -0800 (PST) Date: Sun, 22 Feb 2026 20:57:51 -0800 From: Dmitry Torokhov To: Marc Dietrich Cc: Thierry Reding , Arnd Bergmann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jonathan Hunter , devicetree@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] ARM: tegra: paz00: configure WiFi rfkill switch through device tree Message-ID: References: <82f24afb-1fd2-bfc9-2215-4526aff372ba@gmx.de> <07c024a6-d2f9-5805-4ae7-cbc89cda53bf@gmx.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <07c024a6-d2f9-5805-4ae7-cbc89cda53bf@gmx.de> Hi Marc, On Sat, Feb 21, 2026 at 03:24:35PM +0100, Marc Dietrich wrote: > Hi Dmitry, > > On Sat, 14 Feb 2026, Marc Dietrich wrote: > > > Hi Dmitry, > > > > On Fri, 13 Feb 2026, Dmitry Torokhov wrote: > > > > > As of d64c732dfc9e ("net: rfkill: gpio: add DT support") rfkill-gpio > > > device can be instantiated via device tree. > > > > > > Add the declaration there and drop board-paz00.c file and relevant > > > Makefile fragments. > > > > > > Signed-off-by: Dmitry Torokhov > > > --- > > > > > > This is not tested on real hardware, compile tested only... > > > > > > arch/arm/boot/dts/nvidia/tegra20-paz00.dts | 8 ++++ > > > arch/arm/mach-tegra/Makefile | 2 - > > > arch/arm/mach-tegra/board-paz00.c | 56 ---------------------- > > > arch/arm/mach-tegra/board.h | 2 - > > > arch/arm/mach-tegra/tegra.c | 4 -- > > > 5 files changed, 8 insertions(+), 64 deletions(-) > > > > > > diff --git a/arch/arm/boot/dts/nvidia/tegra20-paz00.dts > > > b/arch/arm/boot/dts/nvidia/tegra20-paz00.dts > > > index 1408e1e00759..d1093ad569e6 100644 > > > --- a/arch/arm/boot/dts/nvidia/tegra20-paz00.dts > > > +++ b/arch/arm/boot/dts/nvidia/tegra20-paz00.dts > > > @@ -706,6 +706,14 @@ vdd_pnl_reg: regulator-3v0 { > > > enable-active-high; > > > }; > > > > > > + rfkill { > > > + compatible = "rfkill-gpio"; > > > + label = "wifi_rfkill"; > > > + radio-type = "wlan"; > > > + reset-gpios = <&gpio TEGRA_GPIO(D, 1) GPIO_ACTIVE_HIGH>; > > > > I guess this can be removed, as it should trigger the LED, which is > > already included elsewhere .... > > > > > + shutdown-gpios = <&gpio TEGRA_GPIO(K, 5) GPIO_ACTIVE_HIGH>; > > > + }; > > > + > > > sound { > > > compatible = "nvidia,tegra-audio-alc5632-paz00", > > > "nvidia,tegra-audio-alc5632"; > > > > I'll give it a try and report back. > > rfkill (and LED) works as expected. With the reset-gpio line mentioned above > removed, you can add my Tested-By. Thank you Marc. I am still a bit confused about the reset gpio. As far as I understand looking through old commits reset gpio (PD1) is distinct from the LED gpio (PD0) that is currently being controlled by "gpio-leds". I guess the rfkill driver needs at least one of "reset" or "shutdown" gpios, and that is why it continues to work with only shutdown, but I am trying to understand if PD1 was never connected to the WiFi chip reset line and instead is used for something else, or if it is indeed a reset line... Was the patch not working with reset-gpios present? I am trying to gather data to craft a proper commit message. Thanks. -- Dmitry