From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Danilo Krummrich <dakr@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>, Tejun Heo <tj@kernel.org>,
Lai Jiangshan <jiangshanlai@gmail.com>,
Tobias Schrammm <t.schramm@manjaro.org>,
Sebastian Reichel <sre@kernel.org>,
Dan Carpenter <dan.carpenter@linaro.org>,
Lee Jones <lee@kernel.org>,
Dzmitry Sankouski <dsankouski@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Benson Leung <bleung@chromium.org>,
Tzung-Bi Shih <tzungbi@kernel.org>,
driver-core@lists.linux.dev, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
Sebastian Reichel <sebastian.reichel@collabora.com>,
linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
chrome-platform@lists.linux.dev
Subject: Re: [PATCH 3/9] power: supply: max77705: Free allocated workqueue and fix removal order
Date: Mon, 23 Feb 2026 13:29:03 +0200 [thread overview]
Message-ID: <aZw5_66M3jV30c1l@smile.fi.intel.com> (raw)
In-Reply-To: <388e52a2-4537-46f0-84d9-eb7a1f3b1660@kernel.org>
On Mon, Feb 23, 2026 at 11:19:13AM +0100, Krzysztof Kozlowski wrote:
> On 23/02/2026 09:57, Andy Shevchenko wrote:
> > On Mon, Feb 23, 2026 at 08:27:31AM +0100, Krzysztof Kozlowski wrote:
...
> >> ret = devm_request_threaded_irq(dev, regmap_irq_get_virq(irq_data, MAX77705_CHGIN_I),
> >> NULL, max77705_chgin_irq,
> >> IRQF_TRIGGER_NONE,
> >> "chgin-irq", chg);
> >> - if (ret) {
> >> - dev_err_probe(dev, ret, "Failed to Request chgin IRQ\n");
> >> - goto destroy_wq;
> >> - }
> >> + if (ret)
> >> + return dev_err_probe(dev, ret, "Failed to Request chgin IRQ\n");
> >
> > This should be just
> >
> > return ret;
> >
> >
> > devm_*_irq() prints the message. No need to repeat this in the caller(s).
> >
>
> I guess separate commit then.
WFM!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-02-23 11:29 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-23 7:27 [PATCH 0/9] workqueue / drivers: Add device-managed allocate workqueue Krzysztof Kozlowski
2026-02-23 7:27 ` [PATCH 1/9] workqueue: devres: " Krzysztof Kozlowski
2026-02-23 8:56 ` Andy Shevchenko
2026-02-23 10:18 ` Krzysztof Kozlowski
2026-02-23 11:34 ` Andy Shevchenko
2026-02-23 11:43 ` Krzysztof Kozlowski
2026-02-23 11:48 ` Andy Shevchenko
2026-02-23 11:52 ` Krzysztof Kozlowski
2026-02-23 12:12 ` Andy Shevchenko
2026-02-23 13:52 ` Matti Vaittinen
2026-02-23 10:36 ` Danilo Krummrich
2026-02-23 10:44 ` Krzysztof Kozlowski
2026-02-23 15:42 ` Tejun Heo
2026-03-05 20:16 ` Krzysztof Kozlowski
2026-02-23 7:27 ` [PATCH 2/9] power: supply: cw2015: Free allocated workqueue Krzysztof Kozlowski
2026-02-23 7:27 ` [PATCH 3/9] power: supply: max77705: Free allocated workqueue and fix removal order Krzysztof Kozlowski
2026-02-23 8:57 ` Andy Shevchenko
2026-02-23 10:19 ` Krzysztof Kozlowski
2026-02-23 11:29 ` Andy Shevchenko [this message]
2026-02-23 7:27 ` [PATCH 4/9] power: supply: mt6370: Simplify with devm_create_singlethread_workqueue Krzysztof Kozlowski
2026-02-23 7:27 ` [PATCH 5/9] power: supply: ipaq_micro: Simplify with devm Krzysztof Kozlowski
2026-02-23 7:27 ` [PATCH 6/9] mfd: ezx-pcap: Drop memory allocation error message Krzysztof Kozlowski
2026-02-23 7:27 ` [PATCH 7/9] mfd: ezx-pcap: Return directly instead of empty gotos Krzysztof Kozlowski
2026-02-23 7:27 ` [PATCH 8/9] mfd: ezx-pcap: Avoid rescheduling after destroying workqueue Krzysztof Kozlowski
2026-02-23 7:27 ` [PATCH 9/9] platform/chrome: cros_usbpd_logger: Simplify with devm Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZw5_66M3jV30c1l@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=corbet@lwn.net \
--cc=dakr@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=driver-core@lists.linux.dev \
--cc=dsankouski@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jiangshanlai@gmail.com \
--cc=krzk@kernel.org \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=rafael@kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=skhan@linuxfoundation.org \
--cc=sre@kernel.org \
--cc=t.schramm@manjaro.org \
--cc=tj@kernel.org \
--cc=tzungbi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox