public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ian Ray <ian.ray@gehealthcare.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Jeremy Cline <jeremy@jcline.org>,
	Ryosuke Yasuoka <ryasuoka@redhat.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Ian Ray <ian.ray@gehealthcare.com>
Subject: Re: [PATCH] nfc: nci: Fix zero-length proprietary OIDs
Date: Mon, 23 Feb 2026 09:29:59 +0200	[thread overview]
Message-ID: <aZwB98JRGrv_uz9k@zeus> (raw)
In-Reply-To: <20260220133601.53b3b7fe@kernel.org>

On Fri, Feb 20, 2026 at 01:36:01PM -0800, Jakub Kicinski wrote:
> On Fri, 20 Feb 2026 13:25:35 +0200 Ian Ray wrote:
> > Before:
> >
> > -- >8 --
> > kernel: nci: nci_recv_frame: len 3
> > -- >8 --
> >
> > After:
> >
> > -- >8 --
> > kernel: nci: nci_recv_frame: len 3
> > kernel: nci: nci_ntf_packet: NCI RX: MT=ntf, PBF=0, GID=0x1, OID=0x23, plen=0
> > kernel: nci: nci_ntf_packet: unknown ntf opcode 0x123
> > kernel: nfc nfc0: NFC: RF transmitter couldn't start. Bad power and/or configuration?
> > -- >8 --
> 
> FWIW the last message in "After" still doesn't sound particularly happy
> so it may be worth explaining why this makes the device usable ;)

The theory here is that we use +3.3V to power pn7160, but maybe the
evaluation kit requires a higher supply.  We will test and confirm this
before sending V2.

> If there's more that needs to be fixed for the device in question to
> work it'd be best to have all the necessary fixes in one series.
> 
> > [1] drivers/nfc/nxp-nci/core.c
> > [2] NXP_NCI_RF_TXLDO_ERROR_NTF
> 

Thanks,
Ian

      reply	other threads:[~2026-02-23  7:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-20 11:25 [PATCH] nfc: nci: Fix zero-length proprietary OIDs Ian Ray
2026-02-20 21:34 ` Jakub Kicinski
2026-02-23  7:26   ` Ian Ray
2026-02-20 21:36 ` [PATCH] " Jakub Kicinski
2026-02-23  7:29   ` Ian Ray [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aZwB98JRGrv_uz9k@zeus \
    --to=ian.ray@gehealthcare.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=jeremy@jcline.org \
    --cc=krzk@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=ryasuoka@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox