From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9E5120E334 for ; Mon, 23 Feb 2026 07:32:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771831959; cv=none; b=JHWMH8/eNnBDmkqRsM4BjblmI8Qb6HAifQlcubbvgisxG00Y/+IHf0V4eDYGBvuJ2NNrKCLdM7DupiFaC7I26jEkS0xxiBo6GYksD19xNMeyEUqZwQb8CvskbXWZL7UNHTuWvqhzhy62TYNoFqtEjkUjblG5TeOmekYIYiNZ5jw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771831959; c=relaxed/simple; bh=PvbDrgjMqskHg6FOXDs44TNWgdIfcNAEdhkJQLQRQxA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fHUPFOghVHukotl6Yrk50roy0UkiBM4FMjFNJlvhdTdL6T51In8oXyIt6RJPB3qV4pacwNE1qzPp9t5d+Vg+MnzMYwfkp5etnK7+P1qUBNdFpSDdWkM5fcZv7/P3QBQVFP34ataA0w4xpOuyPOguwBdsEkSDbYN3+JBm6ZkwFXs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=zWgCav88; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zWgCav88" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4837907f535so35080975e9.3 for ; Sun, 22 Feb 2026 23:32:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1771831955; x=1772436755; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=n6CGQmSeC/8d7YXzEWFhZsk3FEUZiTNTyafXM+HHtyQ=; b=zWgCav888EB97/L/MmK/MF6AxCh65XPdPxMqPn6y3xY/JQFKXMXr4vgdylkdrNT68m wDfconzeD/qox5Ucp6R80y16fWq8JVDZKfptUmwP8gJIwAxZ4P7EJcmpn3U2/PV8AG55 gNIdo3vd4YxBozIAm26tOAEmATgGIXg3I9vleHYfXUmxYu8dJg6tcO3EFO4otuMn3TXg /wVBV8hpK4zUufe2v3LtV2+jvhJv2S62iYbqBQSW4j0SRvf6tojglL/wLHEVSYNfiec1 XHGje3J0/fqOir+wEwGatw3SkfdcMOx3sLzFj715hG4LXK/OKX+/DsNJvG46bX61efCZ wpUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771831955; x=1772436755; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=n6CGQmSeC/8d7YXzEWFhZsk3FEUZiTNTyafXM+HHtyQ=; b=GIrjTdF7DzH/XmNBUD/6KCI0leOc/J8TjLRN0mqDU+wD5bTGC4FpK236SKSQiYqBMr 9xlxf2nPpaYAJHY99/AQxRdg2QIEM+hRPS2Xd93BC3wcp10az2eeUUR3j8jhnjvSWqoX t+eiWqOvyK76KMmcczYjobeG3+mVYP9xCCnfJWCfZXrjMfMTrH+vYzZkWE48mhp4AzOs wy59DGy/1nnb/1GQyDc/7vY36Xr7C3moCTyOGFIcpJ6VCR9QFr8cpuFNoevZSnB5Ln7p MHCZLwkhgHpxgP6js83j5McVEviQ/8GJ+XEhRCawU+o/pUtN4inpaF+ljjU2m64kVF6i fvYw== X-Forwarded-Encrypted: i=1; AJvYcCXMgYiZwsWyDzlwJ9hm9oX9k3rkBNtqE15CqS4o2LLq0rUF56Ct98LDvSZQCiFNEjZW+KN7B/hB85emo8A=@vger.kernel.org X-Gm-Message-State: AOJu0YwpN0P7ir9oYQuktF0klVLDOH85CpkX8iSYWSSHSBw5m/kWWWcU OY58hnhVDVD8DjWnP4K/f0PcVZOHrh88w1cjll8pHaWYnoLXl4RgUeARoq76/4/LmSc= X-Gm-Gg: AZuq6aIKaZfZKfoLq1n53M32esoCqYC71H9UYwtffQ7zNKR2/31n8LejDnW4KUc/TU8 q9qjRQWngT3ax6k8f2RrEWjTKBMWM28VqpX7vyO+YGf891GYHvFzsau5a/5Ml5PNlzRgm84EPFt XBLhtEU+TxKTbr+6bvRNZ75Jwh8DZrGeGeYob4lm3nQRmeMNEZBMiYTx20Y3JiVF9tzQRazySU9 xZlhu+2MaertUPo8qZee7MflwUKqPkYAm61+1Tab5mqg8kRZP8Zirjfeu86s+/qbY1PNdEF/3GF eh4ZHRllm1+VaYY5k+1TqtRZBPa8JQVtq2lZYVQPv0e9T2XXvbGJE7BtAfLBD4Jp6eD73Q1bIwH ggWS34JGbmwKyLRa3TXcedMWjPJY3h0Zy6qZJaA9wxXII3of4nFo7itHfRMQHB8ZetwfBUuTFre 7JaiZczdrzuJaCuAM6u+OX8aCR3yMMIlhEE5hrthY= X-Received: by 2002:a05:600c:3b27:b0:483:702f:4641 with SMTP id 5b1f17b1804b1-483a95bd842mr116765665e9.3.1771831955135; Sun, 22 Feb 2026 23:32:35 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483a9b6698asm290515395e9.2.2026.02.22.23.32.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Feb 2026 23:32:34 -0800 (PST) Date: Mon, 23 Feb 2026 10:32:31 +0300 From: Dan Carpenter To: Priit Laes Cc: Greg Kroah-Hartman , Minu Jin , Archit Anant , Andy Shevchenko , Yuvraj Singh Chauhan , JJ Strnad , Julia Lawall , Ethan Tidmore , Navaneeth K , Artur Stupa , William Hansen-Baird , Randy Dunlap , Tanjim Kamal , Abraham Samuel Adekunle , Michael Straube , Hans de Goede , Vivek BalachandharTN , Zhuoheng Li , Michael Huang , Nino Zhang , Thomas Gleixner , =?iso-8859-1?Q?Rog=E9rio?= Fernandes Pereira , Ingo Molnar , Diksha Kumari , Karthikey D Kadati , Khushal Chitturi , SeungJu Cheon , Akiyoshi Kurita , Erick Karanja , Sun Jian , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 11/11] staging: rtl8723bs: rtw_ieee80211: Reduce global symbols Message-ID: References: <20260221190628.50273-1-plaes@plaes.org> <20260221190628.50273-12-plaes@plaes.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260221190628.50273-12-plaes@plaes.org> On Sat, Feb 21, 2026 at 09:01:41PM +0200, Priit Laes wrote: > Mark internally used symbols/functions as static and drop some unused > ones. > WPA_CIPHER_SUITE_WRAP/RSN_CIPHER_SUITE_WRAP are left as commented, as > these might be actually useful for understanding the code. > > Changes since v1: > * Comment out unused variables WPA_CIPHER_SUITE_WRAP/RSN_CIPHER_SUITE_WRAP Put this under the --- cut off line > > Signed-off-by: Priit Laes > --- ^^^ Here. But really we're not going to allow commented out code. Just delete it. There are reasons why people would merge dead code, such as for example, in some cases code needs legal approval and it's easier to get everything approved at once even when it's not needed immediately. But here we're not going to allow it. This would be easier to review as separate patches: [patch 1] Delete dead code. [patch 2] make functions static [patch 3] move the arrays and make them static const regards, dan carpenter