[PATCH] iio: adc: nxp-sar-adc: Remove unnecessary type casting

[PATCH] iio: adc: nxp-sar-adc: Remove unnecessary type casting

[Felix Gu]

The readl_poll_timeout() macro returns a signed integer error code.

In nxp_sar_adc_calibration_wait(), the return value is casted to u32
before being returned as int, which is unnecessary.

Signed-off-by: Felix Gu <ustc.gu@gmail.com>
---
 drivers/iio/adc/nxp-sar-adc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/iio/adc/nxp-sar-adc.c b/drivers/iio/adc/nxp-sar-adc.c
index 9efa883c277d..a6e4888a8464 100644
--- a/drivers/iio/adc/nxp-sar-adc.c
+++ b/drivers/iio/adc/nxp-sar-adc.c
@@ -247,7 +247,8 @@ static inline void nxp_sar_adc_calibration_start(void __iomem *base)
 
 static inline int nxp_sar_adc_calibration_wait(void __iomem *base)
 {
-	u32 msr, ret;
+	u32 msr;
+	int ret;
 
 	ret = readl_poll_timeout(NXP_SAR_ADC_MSR(base), msr,
 				 !FIELD_GET(NXP_SAR_ADC_MSR_CALBUSY, msr),

---
base-commit: d4906ae14a5f136ceb671bb14cedbf13fa560da6
change-id: 20260222-nxp-sar-adc-1906a65ce5b6

Best regards,
-- 
Felix Gu <ustc.gu@gmail.com>

Re: [PATCH] iio: adc: nxp-sar-adc: Remove unnecessary type casting

[Jonathan Cameron]

On Sun, 22 Feb 2026 02:09:08 +0800
Felix Gu <ustc.gu@gmail.com> wrote:

> The readl_poll_timeout() macro returns a signed integer error code.
> 
> In nxp_sar_adc_calibration_wait(), the return value is casted to u32
> before being returned as int, which is unnecessary.
> 
> Signed-off-by: Felix Gu <ustc.gu@gmail.com>
Hi Felix,

Make sure to include the author of the code you are touching in the +CC list.
Added Daniel.

I think this is simple enough, so I've picked it up now but I'm fine adding
tags or indeed dropping it if other reviews come in.  I'll be rebasing
or rc1 later in the week.

Applied to the testing branch of iio.git

Thanks,

Jonathan

> ---
>  drivers/iio/adc/nxp-sar-adc.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/nxp-sar-adc.c b/drivers/iio/adc/nxp-sar-adc.c
> index 9efa883c277d..a6e4888a8464 100644
> --- a/drivers/iio/adc/nxp-sar-adc.c
> +++ b/drivers/iio/adc/nxp-sar-adc.c
> @@ -247,7 +247,8 @@ static inline void nxp_sar_adc_calibration_start(void __iomem *base)
>  
>  static inline int nxp_sar_adc_calibration_wait(void __iomem *base)
>  {
> -	u32 msr, ret;
> +	u32 msr;
> +	int ret;
>  
>  	ret = readl_poll_timeout(NXP_SAR_ADC_MSR(base), msr,
>  				 !FIELD_GET(NXP_SAR_ADC_MSR_CALBUSY, msr),
> 
> ---
> base-commit: d4906ae14a5f136ceb671bb14cedbf13fa560da6
> change-id: 20260222-nxp-sar-adc-1906a65ce5b6
> 
> Best regards,

Re: [PATCH] iio: adc: nxp-sar-adc: Remove unnecessary type casting

[Felix Gu]

On Mon, Feb 23, 2026 at 12:03 AM Jonathan Cameron <jic23@kernel.org> wrote:
>
> On Sun, 22 Feb 2026 02:09:08 +0800
> Felix Gu <ustc.gu@gmail.com> wrote:
>
> > The readl_poll_timeout() macro returns a signed integer error code.
> >
> > In nxp_sar_adc_calibration_wait(), the return value is casted to u32
> > before being returned as int, which is unnecessary.
> >
> > Signed-off-by: Felix Gu <ustc.gu@gmail.com>
> Hi Felix,
>
> Make sure to include the author of the code you are touching in the +CC list.
> Added Daniel.
>
> I think this is simple enough, so I've picked it up now but I'm fine adding
> tags or indeed dropping it if other reviews come in.  I'll be rebasing
> or rc1 later in the week.
>
> Applied to the testing branch of iio.git
>
> Thanks,
>
> Jonathan
>
> > ---
> >  drivers/iio/adc/nxp-sar-adc.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/iio/adc/nxp-sar-adc.c b/drivers/iio/adc/nxp-sar-adc.c
> > index 9efa883c277d..a6e4888a8464 100644
> > --- a/drivers/iio/adc/nxp-sar-adc.c
> > +++ b/drivers/iio/adc/nxp-sar-adc.c
> > @@ -247,7 +247,8 @@ static inline void nxp_sar_adc_calibration_start(void __iomem *base)
> >
> >  static inline int nxp_sar_adc_calibration_wait(void __iomem *base)
> >  {
> > -     u32 msr, ret;
> > +     u32 msr;
> > +     int ret;
> >
> >       ret = readl_poll_timeout(NXP_SAR_ADC_MSR(base), msr,
> >                                !FIELD_GET(NXP_SAR_ADC_MSR_CALBUSY, msr),
> >
> > ---
> > base-commit: d4906ae14a5f136ceb671bb14cedbf13fa560da6
> > change-id: 20260222-nxp-sar-adc-1906a65ce5b6
> >
> > Best regards,
>
Hi Jonathan,

Thank you for the reminder.

I used b4 prep --auto-to-cc and am not sure why Daniel's email was
missed in this patch, as it was correctly included in another patch.

Best regards,
Felix

Re: [PATCH] iio: adc: nxp-sar-adc: Remove unnecessary type casting

[Andy Shevchenko]

On Mon, Feb 23, 2026 at 12:38:58AM +0800, Felix Gu wrote:
> On Mon, Feb 23, 2026 at 12:03 AM Jonathan Cameron <jic23@kernel.org> wrote:
> > On Sun, 22 Feb 2026 02:09:08 +0800
> > Felix Gu <ustc.gu@gmail.com> wrote:

> > Make sure to include the author of the code you are touching in the +CC list.
> > Added Daniel.
> >
> > I think this is simple enough, so I've picked it up now but I'm fine adding
> > tags or indeed dropping it if other reviews come in.  I'll be rebasing
> > or rc1 later in the week.
> >
> > Applied to the testing branch of iio.git

> Thank you for the reminder.
> 
> I used b4 prep --auto-to-cc and am not sure why Daniel's email was
> missed in this patch, as it was correctly included in another patch.

Please, do *remove* the context that is unrelated to the reply. See this email
as an example. Do not waste others' time on this.

-- 
With Best Regards,
Andy Shevchenko