From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Marcus Folkesson <marcus.folkesson@gmail.com>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
Peter Rosin <peda@axentia.se>,
Michael Hennerich <michael.hennerich@analog.com>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Andi Shyti <andi.shyti@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v7 1/5] i2c: core: add callback to change bus frequency
Date: Mon, 23 Feb 2026 16:55:36 +0200 [thread overview]
Message-ID: <aZxqaGxsUuD8vxQL@smile.fi.intel.com> (raw)
In-Reply-To: <aZxqBOaFId-9WfnR@smile.fi.intel.com>
On Mon, Feb 23, 2026 at 04:54:01PM +0200, Andy Shevchenko wrote:
> On Mon, Feb 23, 2026 at 03:33:50PM +0100, Marcus Folkesson wrote:
...
> > + /*
> > + * If the adapter is a root adapter without set_clk_freq implemented, this feature is not
.set_clk_freq()
> > + * supported
Please, also respect English grammar and punctuation: Missed period here.
> > + */
> > + if (!i2c_parent_is_i2c_adapter(adapter))
> > + return -EOPNOTSUPP;
> > +
> > + /* Update the clock_hz for non-root adapters, even if set_clk_freq is not implemented,
.set_clk_freq()
> > + * to allow * the clock frequency to be propagated to root adapters that do support it.
> > + */
>
> /*
> * Please, keep the style of multi-line comment consistent
> * and as per above.
...including one thing ^^^
> */
>
> > + adapter->clock_hz = clock_hz;
> > + return 0;
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-02-23 14:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-23 14:33 [PATCH v7 0/5] I2C Mux per channel bus speed Marcus Folkesson
2026-02-23 14:33 ` [PATCH v7 1/5] i2c: core: add callback to change bus frequency Marcus Folkesson
2026-02-23 14:53 ` Andy Shevchenko
2026-02-23 14:55 ` Andy Shevchenko [this message]
2026-02-23 14:33 ` [PATCH v7 2/5] i2c: mux: add support for per channel " Marcus Folkesson
2026-02-23 14:57 ` Andy Shevchenko
2026-02-23 14:33 ` [PATCH v7 3/5] i2c: davinci: calculate bus freq from Hz instead of kHz Marcus Folkesson
2026-02-23 14:59 ` Andy Shevchenko
2026-03-09 11:14 ` Marcus Folkesson
2026-03-09 11:33 ` Andy Shevchenko
2026-02-23 14:33 ` [PATCH v7 4/5] i2c: davinci: add support for setting bus frequency Marcus Folkesson
2026-02-23 15:01 ` Andy Shevchenko
2026-02-23 14:33 ` [PATCH v7 5/5] docs: i2c: i2c-topology: add section about bus speed Marcus Folkesson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZxqaGxsUuD8vxQL@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=andi.shyti@kernel.org \
--cc=brgl@bgdev.pl \
--cc=brgl@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcus.folkesson@gmail.com \
--cc=michael.hennerich@analog.com \
--cc=peda@axentia.se \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox