public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Leo Yan <leo.yan@arm.com>
Cc: James Clark <james.clark@linaro.org>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Ian Rogers <irogers@google.com>, Jiri Olsa <jolsa@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v2 1/2] perf bench: Fix initialization of union
Date: Mon, 23 Feb 2026 11:12:27 -0800	[thread overview]
Message-ID: <aZymm3rGRtztu29p@google.com> (raw)
In-Reply-To: <aZdd2clm2RQGLnT4@google.com>

On Thu, Feb 19, 2026 at 11:00:41AM -0800, Namhyung Kim wrote:
> Hello,
> 
> On Thu, Feb 19, 2026 at 03:02:56PM +0000, Leo Yan wrote:
> > On Thu, Feb 19, 2026 at 10:38:57AM +0000, James Clark wrote:
> > > 
> > > 
> > > On 19/02/2026 10:36 am, James Clark wrote:
> > > > 
> > > > 
> > > > On 19/02/2026 12:44 am, Namhyung Kim wrote:
> > > > > Recent compilers don't initialize all members (or the largest member) in
> > > > > an union.  Instead it seems to set the first member only.  So some perf
> > > > > bench output shows invalid numbers like below on my system with GCC 15.
> > > > 
> > > > I couldn't find V1 of this so I wasn't sure if it was discussed already,
> > > > but wasn't the plan to fix this with a compiler option:
> > > > 
> > > > https://lore.kernel.org/linux-perf-users/20250319110454.3230687-1-leo.yan@arm.com/
> > > > 
> > > > and
> > > > 
> > > > https://lore.kernel.org/linux-perf-users/20250320105235.3498106-1-leo.yan@arm.com/
> > > 
> > > Oh I see V1 was only the second patch, that's why I couldn't find it.
> > 
> > Thanks for bringing up this, James.  The latest patch would be:
> > 
> > https://lore.kernel.org/lkml/20250402173056.829400-1-leo.yan@arm.com/
> > 
> > This patch intends to apply the option across tools, but no response
> > from the maintainers.  Seems to me, it may be good enought to apply the
> > option to perf first.
> 
> Thanks for the reminder, yeah it looks better.

Leo, can you please resend that patch to linux-kbuild list and CC the
maintainers?  It seems you did it to Clang folks only..

Thanks,
Namhyung


  reply	other threads:[~2026-02-23 19:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-19  0:44 [PATCH v2 1/2] perf bench: Fix initialization of union Namhyung Kim
2026-02-19  0:44 ` [PATCH v2 2/2] perf bench: Add -t/--threads option to perf bench mem mmap Namhyung Kim
2026-02-19 10:43   ` James Clark
2026-02-26  7:02   ` Ankur Arora
2026-02-27 21:42   ` Namhyung Kim
2026-02-19 10:36 ` [PATCH v2 1/2] perf bench: Fix initialization of union James Clark
2026-02-19 10:38   ` James Clark
2026-02-19 15:02     ` Leo Yan
2026-02-19 19:00       ` Namhyung Kim
2026-02-23 19:12         ` Namhyung Kim [this message]
2026-02-24 12:20           ` Leo Yan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aZymm3rGRtztu29p@google.com \
    --to=namhyung@kernel.org \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=irogers@google.com \
    --cc=james.clark@linaro.org \
    --cc=jolsa@kernel.org \
    --cc=leo.yan@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox