From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f53.google.com (mail-dl1-f53.google.com [74.125.82.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0760A36AB55 for ; Mon, 23 Feb 2026 21:58:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771883925; cv=none; b=ipAfdw+wb3p4aXbFxTb+ATyKpgF8m3SS/IlQKHO3ft2c/lJlITXj4oLpDthRtLnwYr93lotlZgqO0IG4LMGsXJ0LBC01o/AVwm37B+0XWvgDac70sST3W1VG4xTBoBbkQA27rM7T1+vcgMJfq2AAlnEciP70wgq8y6b2lj1GIlU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771883925; c=relaxed/simple; bh=U+932Mn0YgfKAD/xkm1bX1zAHmzcoChHibGTIzZrHrI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=k2t9EJ3q+V+J9xhFCcs6WVYtOpqc565LWSu42xSD72ESE5j2UB3/3mqZChbTQZgqwmgXklLU8CU6hmMSe7iFfwX0BmloZ2EXOnHf7cDjdjysJGD7hBD0sNFR4GUR60sO++uxkexyf3qzmA1asVGzvE7XOxwsd6tMTRpqOaRcChI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PoXjqQ7U; arc=none smtp.client-ip=74.125.82.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PoXjqQ7U" Received: by mail-dl1-f53.google.com with SMTP id a92af1059eb24-126ea4e9694so1409087c88.1 for ; Mon, 23 Feb 2026 13:58:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771883923; x=1772488723; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=O/HprNfkw3exbVeNB8hHbkDBLyIxN5yp9J024tunG0I=; b=PoXjqQ7UqW5F8e3chOEfA8WGJIAccBa0BUt6FK5f0pZ79mu0HAMzyKd4qvDyrqAMkC 2nC2bvJP2itjdMEf33+lpEazD1wFZuS3a2bRIv5BOM3lwV3UwIF/IqLANVPzze7nKHYw 4KTN+gU4GbRj0+sXiS5Kd/Jn+ukGpSp5enYQcNrRH3Xk6O/Xv6i95haLj1AxtrvRNmbA iPnmJXjVSvyMs5ByhbVysBlssg5FSmmZRP/rWF/sEllDqqtZF7tt4qhsdq8x9VEeZV/I y7mCRZqgpgr78+PnBIEBcQ2TWXhccXsgpTXs5SAMd7bSABinCQqr+lG3PtmIUVOTU8DR SG6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771883923; x=1772488723; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=O/HprNfkw3exbVeNB8hHbkDBLyIxN5yp9J024tunG0I=; b=fFOwB4tltp4sUZ/K4XeCs4fJw+4D3blFequ8+kFpSV8E/dtHY4wG9/jezVU2Ytd4gH Az5LtMnUxr4JP35HJAGZSVSEBG6bRYjeh3MUeqkfzWaWSrp+s6iXn6ezHxMjJKRvxT4H tAehgq0RwVSyuth4p8E2b6MMMeP9amGZNbfBQ/GSIzD0sNolYDErj8Qj/UFAeP6uHz3D lZCUH4BbTHZORoKsmIBFLnu3c4AKnK49bpNKpI4WorVhIQUPMKVzqfr643kXTI0xOwed +2aY5ni2wCOVp8IBlAmkljJrcKBCav3M7bA6yrE0jJEa7s8yeDXZ4pJwSsxoh4x3rR4y 1hNg== X-Forwarded-Encrypted: i=1; AJvYcCWU7yR7L9Zspu54uvr3HaaQ4OHqo1iIkRzvZ1bN8Si3GZk2JMpO0zpVN27VkDoSuoSK0Cy7wSo5/S0jhAY=@vger.kernel.org X-Gm-Message-State: AOJu0YyuNLUFRvHSwv3HiukmDN22GKlauGfFrYsIUazYsZ3zRyxzLUBX AoH6jau4PYIJ/mDk97UF4vHkplBRh9AI+XKGzXAd+/3qsy3rPmboJcrc X-Gm-Gg: AZuq6aKywf4OAVxFFGcFPQ6i7hLT9vzm3HOr3EC4nHDONi8PY6CT6uSpazcxzv2YNd8 p4/XpFU6JjRduejgDIMZ9H8eU2lX/V1CM+MtNz4oCMzlpRlZtA+W5TeJGcATauZRRP8C7MH6r2a o0ARK2w2CNUXw1JTIgx3KN9rSZiFupjuYo2Vnv7tlA+G0O68b4A/nNkaTeFk/PkovejJ1H9UKHM roS5AHog289ou3WZL0vE/ALkwbeOSiC9hk1Cg4I3fJ6hXIRkrACHNoScA3gSBzLX8RzcgRRXFxX EQCgoQC+e/W7J/ky9MvwzfVVeAhIIvR/7dnTEYlCcYHSQ2T8dOHWIACuKBRX0gEr0DEJ9HiflkI UosyTcHXrNWqWt2W9LoFM56cl3tRS/TW6zCtDRSHCr08CkMmcUbQTexYkzq8lkPcOUY9uPffcdk iu1JbqpEeKrQX8wAqdpLiCkZCe06IzgHqURlo40r/sJKH1oA9BUv0+lqKfno0GFdt+ X-Received: by 2002:a05:7022:4a1:b0:11f:2c69:32 with SMTP id a92af1059eb24-1276acb1c7fmr3953940c88.7.1771883923048; Mon, 23 Feb 2026 13:58:43 -0800 (PST) Received: from google.com ([2a00:79e0:2ebe:8:1b48:5d6e:ab6e:5287]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1276af2ea06sm10322127c88.7.2026.02.23.13.58.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Feb 2026 13:58:42 -0800 (PST) Date: Mon, 23 Feb 2026 13:58:39 -0800 From: Dmitry Torokhov To: Bart Van Assche Cc: Peter Zijlstra , Ingo Molnar , Will Deacon , Boqun Feng , Waiman Long , linux-kernel@vger.kernel.org, Marco Elver , Christoph Hellwig , Steven Rostedt , Nick Desaulniers , Nathan Chancellor , Kees Cook , Jann Horn , Nick Dyer , linux-input@vger.kernel.org Subject: Re: [PATCH 15/62] Input: synaptics-rmi4 - fix a locking bug in an error path Message-ID: References: <20260223215118.2154194-1-bvanassche@acm.org> <20260223215118.2154194-16-bvanassche@acm.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260223215118.2154194-16-bvanassche@acm.org> Hi Bart, On Mon, Feb 23, 2026 at 01:50:30PM -0800, Bart Van Assche wrote: > Lock f54->data_mutex before the first 'goto error' statement since > jumping to the 'error' label causes that mutex to be unlocked. > > This bug has been detected by the Clang thread-safety checker. > > Cc: Dmitry Torokhov > Cc: Nick Dyer > Cc: linux-input@vger.kernel.org > Fixes: 3a762dbd5347 ("[media] Input: synaptics-rmi4 - add support for F54 diagnostics") > Signed-off-by: Bart Van Assche > --- > drivers/input/rmi4/rmi_f54.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/input/rmi4/rmi_f54.c b/drivers/input/rmi4/rmi_f54.c > index ac4041a69fcd..fd57ebb1cb50 100644 > --- a/drivers/input/rmi4/rmi_f54.c > +++ b/drivers/input/rmi4/rmi_f54.c > @@ -539,6 +539,9 @@ static void rmi_f54_work(struct work_struct *work) > int i; > > report_size = rmi_f54_get_report_size(f54); > + > + mutex_lock(&f54->data_mutex); > + Thank you for the patch. Do you mind if I move mutex_lock() above the call to rmi_f54_get_report_size()? It does not extend critical section by much, and I think logically makes more sense. > if (report_size == 0) { > dev_err(&fn->dev, "Bad report size, report type=%d\n", > f54->report_type); > @@ -546,8 +549,6 @@ static void rmi_f54_work(struct work_struct *work) > goto error; /* retry won't help */ > } > > - mutex_lock(&f54->data_mutex); > - > /* > * Need to check if command has completed. > * If not try again later. Thanks. -- Dmitry