From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5EA6428D8DB for ; Tue, 10 Mar 2026 06:15:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773123324; cv=none; b=O07/UY/puJpWX7kTO+x49xBVtQ5TlZAK7RyCylkD8DITi6+ZquQUfMxs4RS3O6aaQ447Ec1WFzjNw/azewsyjEYRG6eobHb/ZzriWUCtyroXqTU+ZJgmGgYKslT+GWpSgISIulp+6A+uZy+r3/K4SMtSUPZnPNbkMJy5OFUAfnc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773123324; c=relaxed/simple; bh=1er7LkezfAFSOP1NGwBywoioOUqMCd+5bCfFyYunW9A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QUBd3dYonxMLmu11yqZMzjzfiKV2PVBhIkdLMf0yJtP2W/8s56p+MD9cLHcK1rWnnBACx5sHSXcq9rcpdwZ432bOD4PYE1uOJ+k2A3RCsfssApSucb+i9sAJ7Auie5UmRzaAw2HP6KHWhp4xRjNpCyd95cHkEZ+XWgCcjoyq+xA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=f6l8RBqz; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="f6l8RBqz" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-82748257f5fso6886761b3a.1 for ; Mon, 09 Mar 2026 23:15:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1773123323; x=1773728123; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=nZhurTqHkOB/Z9dHHGlE2leBBgsn3TEX7amO10nnH24=; b=f6l8RBqzRujV3HLvR1W/Hqu5AW8vNndYymRVuQQo3Z+BgDeOnvQK8pOa7ULgGiw1tS K53yYprSEUIGvnKnxFHoEgF+zfH+X9qe/PGGa7zZcuTfx3pVr6m9xDdlvkDagDyCLsV6 SYsDRr2OeDXLEvlc1nrBWYhxBDsJASzp1zh+A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773123323; x=1773728123; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nZhurTqHkOB/Z9dHHGlE2leBBgsn3TEX7amO10nnH24=; b=c/ivIhlCUiLfBFwLzFd1T/dBis88/BrjmQRJ7oC87UzHUXjBYUAS3rFOPL5Rup4o06 CRFFeQm7M0DUS2ntJO6Vo8Nfj80VmGUUjvroHFiwUr+H4/0m80o2t1/vzsb1fCGwvfR+ tmNCrIP9McQLhB9X8kvIGNG75dr6/ymYTSs2X9qqRx89dfRUe5QWlwsoajSSLEQHCibd hjz1kKQ+f+Ei0Z0AhHRpJWYAqA4QLR20Jw48TuNtqMIWH/ic7X9V63Nf1uG/cMz9LZrd 1csfd6gPlTa1xnrcN8pPvVnsYpw7xeeFIBInGQRxVu3TeGjeCJ4qYKNgTswmT46sYj4J FIiw== X-Forwarded-Encrypted: i=1; AJvYcCUMjIXtmcF46JRnwN3FueYfKGJNARjNRl5TeYUJmLDqEZAAXd6pr3j+8LSxvY7Z2eGJcwMLZdXQ7eVrXVg=@vger.kernel.org X-Gm-Message-State: AOJu0YwXKDzv+LWkxGMapWYRoyz/f8ubb36ITIKKq5PaDkk5MSAG0f0x Burdmgn0jpPRq31qJOPynl7NIGcU2p2N6bm9w6Fmf5PdMfLblxQAVjJOBPurz+GYYw== X-Gm-Gg: ATEYQzxd5OcRTz61t0kygKbxlYjGAeXgKI21cfTSO+Zw2BnqNn6O3Ps8wayI+YVxAi1 8lTU+9hhrGnw6qIfodRasxxgduZ3lo5yY5F5XWHl8L6Y+ydGTVwVaIoSCJ/mXRRevyRBeNw/3xP a8h2Qibf2bO3aK/wkdEsbIcYZpy8EgtXWTHLVZyWcM6c7rmmE9aL6cCchQLAtR6cvoM9VaUJYTW mLl7SezxYLK5da+keJRhtDnD69RuHOXKW3EaQh626U9aRCjXsG4Z5M21nYN2dCSfRDo4HMSunH6 iIcEw/31YB7clo1iIp+UfEH3y1dVPy96O0UvrSCFkufQJjpMfm/E0YsoRWSz1kHX7kDRcqBUOgF vx4Eyjx6NyTUz6ZbHvLUgrBup6FBH2x3hvbhc8wYzlPERHgaBEXjV2rUaKqIvc0ND4GpFm2z19X 6shSDT+0TOxXRL2p3R1eCMMz8rJAvU5HdIU9dprz2WPCUZETg1sl4qTZBOkbn23aQ= X-Received: by 2002:a05:6a21:3f91:b0:398:94eb:1bfd with SMTP id adf61e73a8af0-398ab2ddc20mr1738818637.10.1773123322772; Mon, 09 Mar 2026 23:15:22 -0700 (PDT) Received: from google.com ([2a00:79e0:2031:6:5620:959c:240f:eb2a]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-829a4636a9dsm12304586b3a.4.2026.03.09.23.15.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 23:15:22 -0700 (PDT) Date: Tue, 10 Mar 2026 15:15:19 +0900 From: Sergey Senozhatsky To: gao xu Cc: Sergey Senozhatsky , Minchan Kim , Jens Axboe , "linux-block@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Andrew Morton , "surenb@google.com" , zhouxiaolong Subject: Re: zram: Optimize LZ4 dictionary compression performance Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On (26/03/10 02:54), gao xu wrote: > + memcpy(zctx->cstrm, &drv->base_cstream, > + sizeof(*zctx->cstrm)); Do we need to do this memcpy() every time? A nit: if it cannot fit on one line, then let's align sizeof(*zctx->cstrm) with "(".