From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50879322B6D for ; Tue, 10 Mar 2026 06:22:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773123726; cv=none; b=XgHelbSPW5qnLjeA1jq7J/zTfTRygCPJ/RbCxDhkln8Yo7ybcJeg2wzGVd/MAAgBcz2NxHykHPRtVcMvk1w6egevnJtzhY9gUtsi9Py0hX7kVMuNSuWQ6Kz126maYs20QFl7Rt429uSMVmbVsGAat6mMVSYiqBR3LN11ABc1KIM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773123726; c=relaxed/simple; bh=nsEtdyBHYuNtrwfkSUd+kMCvDYIhEsa5VyEqqaR5Uck=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YZdRQCOrtwYJbd8HXYC7Qt8KXlGd0n5HF36o3Uc9QnODCxESa28Va+bYtN/rgtcwYfbP03H85lhvRxVjxKF1v+ybt0Tq6dDkL2hOuur33bCinyidpGs4b3uysrkC3p/7mN18Ib5TDo8YlgbkmYZULbH27U2c1Qgan4b5MnlxWbI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Qh88ktry; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Qh88ktry" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2ae505619baso54258635ad.2 for ; Mon, 09 Mar 2026 23:22:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1773123725; x=1773728525; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=64ARV6b6LChpJbIycIcc+WA+oaIfxBmH1ZYyI/Pm2QM=; b=Qh88ktryNKkBbHcmfeN7s1KCF2wPDA9aZG5vN0QW5NEcBxTHtk8L5SYVogG4IjkgE0 e9W8eVRTs9/sk9ci+8a0XjNxH6l05Tuy7HrHc4UA7SG/lFdudBjHd8uAECCEqbKqXBj7 rif2syzTZ+6Y4JdPleddhsWfd4dm4AZlWxv90= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773123725; x=1773728525; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=64ARV6b6LChpJbIycIcc+WA+oaIfxBmH1ZYyI/Pm2QM=; b=XAWGBIZd3MT5gI8uYxfD1B7Xbm2GCD50P+xJ29kW9JwD0pns+4Z7jbW+/RrPUqW1AI gyne8xGm18CFTPahcjpbIztaRJylyHoE6wufAuN4VJwkALMMEBXUnJYc2/B+mKUO2tcM KHJ1trh500Dy/Y8UmzDYX4UUCjXllveIm2wN15JzT1moRblsVj9tCiMJwgO7zAnPo9Ta 2lDm11H0PeNClDx3tsJGZOLyyf1iGjMtt9hhzh2xLs7Dl9/gMcgrRj6UyAzVb99YYZxT kWcKyGocCk4jNQRlPfi2dZaVzyDeAsZHZ7+cSJH90DlgIEdojWQpwvubkYoiwyPwS1hu 5u0g== X-Forwarded-Encrypted: i=1; AJvYcCXq8V0kJsOghM3Sx08GF4qVGaiiedQ3aarFeWbbXrzgqElMqZrdEvHZVQQUUBmfc8xm5lSFBPourLr3GA0=@vger.kernel.org X-Gm-Message-State: AOJu0Yz/4rbMI5wSs7ajYJjK2b8B2zmx7ZIElQ6BXqnH3nNmTnwz2cKo ihPIJfiDhGAy01063a2G4L2tEn8yCJt1HlQMBvGFxVzLu7KUt77G8rrOfC29Pu4iqg== X-Gm-Gg: ATEYQzyJn0YKRzJI3TC9Othc0H3xN8WU9rvH/jbIlVAFSkc0rmDkwQZaolvX6hLaiBR HvmC4AzDIq5nQsIOb7PO1/YevUq1avQYW7DTsktQ5rqGjgZT9A8uIVBPlVLZpSKIT3u44LjWuty YEHiSaDfAOrG579j1G6yg+QR68qWjUymEI3dNs5HS7EegNRR7vieRc4DM4SrN0jN/z6G0zrlw5F UI5QKR/oN7xUjCPVQchueQE7rG73g2AdH5L/vZfrG0a+m27xOvIq9iwKYBqhX4JdG+tRSUSiN3J 7bbhYYUF3yKJ6/2qMOYQJ0mT2FxSOXXQtl5sY7SHP2NkuY7Co5riEqss9GIH3X1QsZaLwSF2E5S vPN98HaebDnWDp1cxdbl1suE5JlTQVFV0jGg8WalxgIImv1wHOeTg1Tl+F1eMq0QPtocGEsbH1m H3RDxqh6cLq40MSmEfBg9wAiTwzO0PXqhkbdzNvQywg1ntXNb9PAOgp+yaP4dchxM= X-Received: by 2002:a17:902:db0c:b0:2ae:80d2:bb79 with SMTP id d9443c01a7336-2ae823fe8e0mr154921645ad.2.1773123724714; Mon, 09 Mar 2026 23:22:04 -0700 (PDT) Received: from google.com ([2a00:79e0:2031:6:5620:959c:240f:eb2a]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ae83e57b1fsm185091195ad.12.2026.03.09.23.22.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 23:22:04 -0700 (PDT) Date: Tue, 10 Mar 2026 15:22:00 +0900 From: Sergey Senozhatsky To: Sergey Senozhatsky Cc: gao xu , Minchan Kim , Jens Axboe , "linux-block@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Andrew Morton , "surenb@google.com" , zhouxiaolong Subject: Re: zram: Optimize LZ4 dictionary compression performance Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On (26/03/10 15:13), Sergey Senozhatsky wrote: [..] > > + /* rebuild base_cstream when the dictionary changes */ > > + if (!drv->base_c_valid || drv->dict_gen != params->dict_gen) { > > + ret = lz4_build_base_cstream(params); > > + if (ret) > > + return ret; > > + } > > We should not need this, unless I'm missing something. Params should ^ should not > change once algorithms are setups and the device is init.