From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDECD2980A8 for ; Tue, 10 Mar 2026 05:39:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773121185; cv=none; b=jpWvT2FXBN5Mi2aCpcQ6rmSx1qzXJo+vhvZguvM6+xiAtanOXxfKDsfHNDhBQbmzHjPaxU1xXHGvsrzr4B2nafIEWEQTIdaKqytvo55q/pDtwgv3uIuoHgGHiR7Xtv+d1O5UQNiI7fvCdw3BCzBYxzGerzymDNTPy8l2PX51U6w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773121185; c=relaxed/simple; bh=nB9xIMLjhF/iaWa4zTIp5oFpdXpCe7lSh9rcsGcI/uw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=s80od2xgeSuzStjG7ThN1mPWx1fU1MoSKfhK4Sy6u+kmoVWEGLyaiqYL5ZaXfreECjD1T/i9PDedsz5NMmFTd3dbb6Bdl8j7pPfTquvlerGpWoQalGZ91vm4QgdBZGPa6UeJ+cL/xlIEO1MEArFUI8e2Vf1j41GtP7SCWhFFdek= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Op3OaI6/; arc=none smtp.client-ip=209.85.215.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Op3OaI6/" Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-c7358a7a8d1so5829997a12.3 for ; Mon, 09 Mar 2026 22:39:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1773121183; x=1773725983; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=HvRlyDyTSjBWwIiXQKIbLdkGLZLef1DOzpb4yqLasSE=; b=Op3OaI6/2R8eSi9EDq7nQmQUEkTL+oFWvS9zsm5TEdlMRfyo9S3p2K4TMygMRL2Oq7 igDCgfdsOsVThny6nDHScjnxV7+RxwDVwPAup+Xc3uEoZ9UEAP331Cgg5kvXAn1ITx47 Uu2UzP9lU24LpBj30EwEg0wNXdRPjwTDKF/u8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773121183; x=1773725983; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HvRlyDyTSjBWwIiXQKIbLdkGLZLef1DOzpb4yqLasSE=; b=SQr40SxJL5+AgC91qRQshBn0kyUxH6RJRZPc46Kn8MFLFDX4gbYh3loxsQE4assjFb UaQ6q43I4jOOZrZIetUCEQ0WTME6WHQy/PJgbF7DnqthwvdCHEPCb4sJTd0+Ognn77ma 3d66oDIRn6uZlsH0s7/W9X2ICy+J9fSj0HgkFYZKsNalKh07OSA2vf0VQQpsktEZYF81 iwRLL12gE5BrMN/PLayzP20fSzXjxhNhOO4uAXgdPmCB0z97AwEWHcRfnbnlUoQTqEgj sJOJvJj/Bozi0yw6L8rmbfulPe5XnPrLstCdW5qNAwq1DSjcr7e3y77c1kEeWgksucFW m9CA== X-Forwarded-Encrypted: i=1; AJvYcCXDNMEcy3RvjQUEMtw2TabzFwZIP6U7R3xX+iejDfl5Hlg6H6YWlUPpuXnZko0H8v3KBWggR0wkFsnc72E=@vger.kernel.org X-Gm-Message-State: AOJu0Yz5IQi+51FyE4f8vL93ss0fQIHQc/v2QyEunGfEwfWO5kMYjGRW 1ilm+BdHvvwaVrImnIOOKJFJBP3a2MLirPUBqDYYhfaEdD2eS1EpwzUAcc24uWAAog== X-Gm-Gg: ATEYQzxXIq6bXybI6Fl/embkAxrzaR3c4ynEPIfyUXY1FlYWTrBx+SaoQDzMOWeV/ki +JlJiff3kgNrvpBzV9gEo1OpF3MiOHC8ftfs5noowHZbsDVqdEaO9OCszkL8IAbk/zlg0ahNyhq JdaEFR4AKZGcZ8zjmRlBbWO6zKduJVb7ctUfwds5D5UkqM3uQNbatuTM+9XjVt4OTh8slvcJIXy tCY5LVSW9oY982ZAAvMRZnJwvLl9eNUL/1IWHAu9JNHo69luC4SlxEdY+WVSkAAi6kez4Xd1Uti G28crKH3cvtaV1TwO0QzJzNGLP8/CdP/uCFIWS16dVRa83Yzi5Rbp34+pWbBAFlf6rvnNA4MaNu IjYDjE2hjqW2SC+IDgOL4MmG6aEpn9+0sz0AsOfURF92UiIyXG0zEtKIYN3n3KyBPlABbB6WLt7 SqOEvZRFChGArZNM1X3Ud5fX09fbJg0CgfB/2Lsu/WE80sVMnH9ysw6r8HLJbMe4k= X-Received: by 2002:a05:6a21:6f16:b0:393:dc6b:a0eb with SMTP id adf61e73a8af0-398590d6298mr13032783637.64.1773121183093; Mon, 09 Mar 2026 22:39:43 -0700 (PDT) Received: from google.com ([2a00:79e0:2031:6:5620:959c:240f:eb2a]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c739e170c87sm11446175a12.18.2026.03.09.22.39.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 22:39:42 -0700 (PDT) Date: Tue, 10 Mar 2026 14:39:39 +0900 From: Sergey Senozhatsky To: gao xu Cc: Sergey Senozhatsky , Minchan Kim , Jens Axboe , "linux-block@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Andrew Morton , "surenb@google.com" , zhouxiaolong Subject: Re: zram: Optimize LZ4 dictionary compression performance Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On (26/03/10 02:54), gao xu wrote: [..] > @@ -78,10 +121,16 @@ static int lz4_compress(struct zcomp_params *params, struct zcomp_ctx *ctx, > req->dst_len, params->level, > zctx->mem); > } else { > + /* rebuild base_cstream when the dictionary changes */ How often does it change and under what circumstances? > + if (!drv->base_c_valid || drv->dict_gen != params->dict_gen) { > + ret = lz4_build_base_cstream(params); > + if (ret) > + return ret; > + }