From: Timur Tabi <timur@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>,
Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Cc: jhugo@codeaurora.org, Stephen Boyd <swboyd@chromium.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH v2] gpiolib: Show correct direction from the beginning
Date: Tue, 2 Oct 2018 07:26:47 -0500 [thread overview]
Message-ID: <aa06e450-84a7-11f9-3972-08f1c9dbd1c4@kernel.org> (raw)
In-Reply-To: <CACRpkdaccTSqpKQeUc1c6UEMo+fZmB+w0BQJL--gubrLMmKSgw@mail.gmail.com>
On 10/2/18 2:38 AM, Linus Walleij wrote:
>> But as today the only driver that seems to be using valid_mask is msm,
>> so perhaps a hack is something better and then when we have a second
>> driver that requires it we figure out the real requirements. But it is
>> definately your decision;)
Please note that MSM is supposed to be the *first* driver, not the only,
driver that needs valid_mask. So let's not make any code changes that
limit this feature to the MSM driver.
> I would just add some exported function to gpiolib to do what you
> need so you can set up the valid_mask before calling
> gpiochip_add*.
I think that should be okay. Drivers should know pretty early whether
they need valid_mask or not.
next prev parent reply other threads:[~2018-10-02 12:26 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-21 10:36 [PATCH] gpiolib: Fix gpio_direction_* for single direction GPIOs Ricardo Ribalda Delgado
2018-09-21 10:36 ` [PATCH v2] gpiolib: Show correct direction from the beginning Ricardo Ribalda Delgado
2018-09-21 12:25 ` Timur Tabi
2018-09-27 6:51 ` Stephen Boyd
2018-09-27 12:19 ` Timur Tabi
2018-09-27 14:04 ` Jeffrey Hugo
2018-09-27 14:19 ` Timur Tabi
2018-09-27 14:34 ` Jeffrey Hugo
2018-09-28 19:14 ` Jeffrey Hugo
2018-09-28 19:22 ` Timur Tabi
2018-09-29 6:23 ` Ricardo Ribalda Delgado
2018-09-29 13:21 ` Timur Tabi
2018-09-29 13:25 ` Timur Tabi
[not found] ` <D3E6F4C4-E1C4-4D88-B118-878576BF5281@gmail.com>
2018-10-01 11:54 ` Linus Walleij
2018-10-01 13:36 ` Ricardo Ribalda Delgado
2018-10-01 14:27 ` Jeffrey Hugo
2018-10-01 21:20 ` Linus Walleij
2018-10-02 7:15 ` Ricardo Ribalda Delgado
2018-10-02 7:38 ` Linus Walleij
2018-10-02 12:26 ` Timur Tabi [this message]
2018-10-02 12:51 ` Linus Walleij
2018-09-25 7:36 ` [PATCH] gpiolib: Fix gpio_direction_* for single direction GPIOs Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa06e450-84a7-11f9-3972-08f1c9dbd1c4@kernel.org \
--to=timur@kernel.org \
--cc=jhugo@codeaurora.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ricardo.ribalda@gmail.com \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox