From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B5E724A078 for ; Fri, 24 Apr 2026 14:13:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777040000; cv=none; b=tr4NExHwF+CmWgHW81wDtVb8j+VNSIAlZVDGNRt0cYQtHWPxToitnxHq2pJqENOJZVeFaKPAkmPi2VA8ChwCXDUnq91FsrP7OAUvYFTzFPu9Pc1T+iS4SmhqzoXTjij2mlYA4DLgsHyftpNvgeAwTq56P7xm6M5dgBU8wI1q68U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777040000; c=relaxed/simple; bh=y5xWrYfVQJGD1c2gpGmxsIdJlpuZuKi2LVj4vQlZ1vg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=A5NjBeiSioyT6zG6EJTG0A6GU9iICyEnFkTvTwzVu/jcUvRMi+9JN6PZf8eaH9/9NEn6othcUPqcQPU88fxvFKcWkpwf1QHpeTTcEHABowQ1S8i+bD4qMt2ZnDR9UPXD0BTl/Q4ZmLZpoSBQ3lQbnxZq34q6hKwTSo4tBIUdj8k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=G5Prosa2; arc=none smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="G5Prosa2" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1777039998; x=1808575998; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=y5xWrYfVQJGD1c2gpGmxsIdJlpuZuKi2LVj4vQlZ1vg=; b=G5Prosa2QF1SNoaP7BHCwtNeRqcTHbsg5Aj5bG9doxbAF1IblN/m1oaI 3IX/ZwUmwFGO4bHxl0eU/lAoU2y2WxTrptFDfS24eR4HQ1I38OSDNSjtn qlyfRJntFJzcxY1tEvzgod19e475y8f7payIn0+5/MnszJnaJ11FeIvSE sTnzxVm/dfq+HLoEEgZsVVhDGlBKLDmSOWZ0IHf9n0f6vuqBmccLZCUHL 5qb4IihHcB7iCAsNKYGzBMsV4BU0pWwrYgMXnpC4DGPYqd0tWrwwrVSOP 7/hFlupzOE2ZpyXQ73g7FvuZS8JrW/Mb7PvZh8TShu2N+fjrg+t4GbIn9 g==; X-CSE-ConnectionGUID: d0nfzGXITUK7D+hg2O4RuQ== X-CSE-MsgGUID: fQo+QP0DTJSOsUtPFYcBIQ== X-IronPort-AV: E=McAfee;i="6800,10657,11765"; a="89404186" X-IronPort-AV: E=Sophos;i="6.23,196,1770624000"; d="scan'208";a="89404186" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Apr 2026 07:13:17 -0700 X-CSE-ConnectionGUID: OPVmvdFdQBysKWD+deWhVg== X-CSE-MsgGUID: FaMhVWedT+C/YuLkKYmTow== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,196,1770624000"; d="scan'208";a="230318504" Received: from smoticic-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.245.89]) by fmviesa008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Apr 2026 07:13:13 -0700 From: Jani Nikula To: Maxime Ripard , Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Jyri Sarha , Tomi Valkeinen Cc: Devarsh Thakkar , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Maxime Ripard , Laurent Pinchart Subject: Re: [PATCH v2 07/28] drm/bridge: Implement atomic_print_state In-Reply-To: <20260423-drm-state-readout-v2-7-8549f87cb978@kernel.org> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland References: <20260423-drm-state-readout-v2-0-8549f87cb978@kernel.org> <20260423-drm-state-readout-v2-7-8549f87cb978@kernel.org> Date: Fri, 24 Apr 2026 17:13:10 +0300 Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Thu, 23 Apr 2026, Maxime Ripard wrote: > Bridges have some fields in their state worth printing, but we don't > provide an atomic_print_state implementation to show those fields. > > Provide one. > > Reviewed-by: Laurent Pinchart > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/drm_bridge.c | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c > index 5b8e171afbe5..fba440bddcb3 100644 > --- a/drivers/gpu/drm/drm_bridge.c > +++ b/drivers/gpu/drm/drm_bridge.c > @@ -506,14 +506,35 @@ drm_bridge_atomic_create_priv_state(struct drm_private_obj *obj) > return ERR_CAST(state); > > return &state->base; > } > > +static void > +drm_bridge_atomic_print_priv_state(struct drm_printer *p, > + const struct drm_private_state *s) > +{ > + const struct drm_bridge_state *state = drm_priv_to_bridge_state(s); > + struct drm_bridge *bridge = drm_priv_to_bridge(s->obj); > + > + if (bridge->of_node) > + drm_printf(p, "bridge: %ps (%pOFfc)\n", bridge->funcs, bridge->of_node); > + else > + drm_printf(p, "bridge: %ps\n", bridge->funcs); > + > + drm_printf(p, "\tinput bus configuration:"); > + drm_printf(p, "\t\tcode: %04x", state->input_bus_cfg.format); > + drm_printf(p, "\t\tflags: %08x", state->input_bus_cfg.flags); > + drm_printf(p, "\toutput bus configuration:"); > + drm_printf(p, "\t\tcode: %04x", state->output_bus_cfg.format); > + drm_printf(p, "\t\tflags: %08x", state->output_bus_cfg.flags); Nitpick, please see drm_printf_indent(). Not having the \t's in the format strings makes them easier on the eyes. BR, Jani. > +} > + > static const struct drm_private_state_funcs drm_bridge_priv_state_funcs = { > .atomic_create_state = drm_bridge_atomic_create_priv_state, > .atomic_duplicate_state = drm_bridge_atomic_duplicate_priv_state, > .atomic_destroy_state = drm_bridge_atomic_destroy_priv_state, > + .atomic_print_state = drm_bridge_atomic_print_priv_state, > }; > > /** > * drm_private_obj_is_bridge - check if a private object backs a bridge > * @obj: private object to check -- Jani Nikula, Intel