public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Taniya Das <tdas@codeaurora.org>
To: Stephen Boyd <sboyd@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@codeaurora.org>
Cc: Andy Gross <andy.gross@linaro.org>,
	David Brown <david.brown@linaro.org>,
	Rajendra Nayak <rnayak@codeaurora.org>,
	Odelu Kukatla <okukatla@codeaurora.org>,
	Amit Nischal <anischal@codeaurora.org>,
	linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
	linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] clk: qcom: gdsc: Add support to poll for higher timeout value
Date: Mon, 9 Apr 2018 14:10:06 +0530	[thread overview]
Message-ID: <aa305cce-1244-45cb-267d-565f1f95b0e8@codeaurora.org> (raw)
In-Reply-To: <152297065260.143116.4250583205921081457@swboyd.mtv.corp.google.com>

Hello Stephen,

Thanks for the review comments.

On 4/6/2018 4:54 AM, Stephen Boyd wrote:
> Quoting Taniya Das (2018-04-02 03:45:44)
>> From: Amit Nischal <anischal@codeaurora.org>
>>
>> For some gdscs, it might take longer time up to 500us for
>> updating their status. So add support for the same by
>> defining a new flag 'GDS_TIMEOUT' to mark such gdsc in
>> order to poll their status for longer timeout value.
>>
>> Signed-off-by: Amit Nischal <anischal@codeaurora.org>
>> Signed-off-by: Taniya Das <tdas@codeaurora.org>
>> ---
> 
> Let's just increase the timeout to 500 if it's required? This is a
> timeout, so we're not really expecting to hit it anyway so optimizing
> the uncommon case is not useful.
> --

Will fix this in the next series.

> To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation.

--

  reply	other threads:[~2018-04-09  8:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-02 10:45 [PATCH 0/3] Update reset and poll logic for GDSCs Taniya Das
2018-04-02 10:45 ` [PATCH 1/3] clk: qcom: gdsc: Add support to reset AON and block reset logic Taniya Das
2018-04-02 10:45 ` [PATCH 2/3] clk: qcom: gdsc: Add support to poll for higher timeout value Taniya Das
2018-04-05 23:24   ` Stephen Boyd
2018-04-09  8:40     ` Taniya Das [this message]
2018-04-02 10:45 ` [PATCH 3/3] clk: qcom: gdsc: Add support to poll CFG register to check GDSC state Taniya Das
2018-04-06 16:40   ` Stephen Boyd
2018-04-09  8:41     ` Taniya Das

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aa305cce-1244-45cb-267d-565f1f95b0e8@codeaurora.org \
    --to=tdas@codeaurora.org \
    --cc=andy.gross@linaro.org \
    --cc=anischal@codeaurora.org \
    --cc=david.brown@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-soc@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=okukatla@codeaurora.org \
    --cc=rnayak@codeaurora.org \
    --cc=sboyd@codeaurora.org \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox