RE: [PATCH v6 4/4] iommufd/selftest: Add coverage for IOMMU_GET_HW_INFO ioctl

Liu, Yi L
2023-08-11T06:57:53Z

> From: Jason Gunthorpe <jgg@nvidia.com>
> Sent: Thursday, August 10, 2023 12:46 AM
>
> On Tue, Aug 08, 2023 at 08:35:10AM -0700, Yi Liu wrote:
> > From: Nicolin Chen <nicolinc@nvidia.com>
> >
> > Add a mock_domain_hw_info function and an iommu_test_hw_info data
> > structure. This allows to test the IOMMU_GET_HW_INFO ioctl passing
> > the test_reg value for the mock_dev.
> >
> > Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
> > Signed-off-by: Yi Liu <yi.l.liu@intel.com>
> > ---
> > drivers/iommu/iommufd/iommufd_test.h | 9 +++++++
> > drivers/iommu/iommufd/selftest.c | 16 ++++++++++++
> > tools/testing/selftests/iommu/iommufd.c | 17 +++++++++++-
> > tools/testing/selftests/iommu/iommufd_utils.h | 26 +++++++++++++++++++
> > 4 files changed, 67 insertions(+), 1 deletion(-)
>
> Don't forget to add it to fail_nth

Sure. Btw. Would you share us the rule on determining whether an ioctl/path
requires fail_nth case or not.

Regards,
Yi Liu