From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F354C072A2 for ; Fri, 17 Nov 2023 17:15:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346122AbjKQRPM (ORCPT ); Fri, 17 Nov 2023 12:15:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50912 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231601AbjKQRPK (ORCPT ); Fri, 17 Nov 2023 12:15:10 -0500 Received: from out-177.mta1.migadu.com (out-177.mta1.migadu.com [95.215.58.177]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 571DED6C for ; Fri, 17 Nov 2023 09:15:04 -0800 (PST) Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1700241302; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HEDhNZrH8MvqjaHDgYaCvonHmsUHYS4uG+z5r2r0VRQ=; b=g2llqfJlhvSeujHlwGzKY8TaH4b9KrWeMpu5RUYAC7UiFxrCSJ6vY46AAy6iJGgJxAQtLE fffFOowZVsUrDd+H8C9Na13lS75c3jrOdXlJIiqrSmvyMAMyKDuiW8Ku50bgJJX9SnjpCw 2+4oqDgUBRu/G5f+WVlvUu6BQPg4C/k= Date: Sat, 18 Nov 2023 01:14:49 +0800 MIME-Version: 1.0 Subject: Re: [PATCH 8/8] drm/bridge: it66121: Allow link this driver as a lib Content-Language: en-US To: Dmitry Baryshkov Cc: Phong LE , Neil Armstrong , Maxime Ripard , Sui Jingfeng , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Laurent Pinchart , Thomas Zimmermann References: <20231114150130.497915-1-sui.jingfeng@linux.dev> <20231114150130.497915-9-sui.jingfeng@linux.dev> <1b59d647-c345-4260-b07b-22abb70ae17a@linux.dev> <7b85d057-3d66-435a-a657-dd69067b6bef@linux.dev> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sui Jingfeng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 2023/11/17 17:03, Dmitry Baryshkov wrote: > On Fri, 17 Nov 2023 at 06:24, Sui Jingfeng wrote: >> Hi, >> >> On 2023/11/16 23:23, Dmitry Baryshkov wrote: >>>>>> Then you will need some way (fwnode?) to >>>>>> discover the bridge chain. And at the last point you will get into the >>>>>> device data and/or properties business. >>>>>> >>>>> No, leave that chance to a more better programmer and forgive me please, >>>>> too difficult, I'm afraid of not able to solve. Thanks a lot for the >>>>> trust! >>> From my point of view: no. >> >> I respect the fact that the community prefer generic mechanisms. >> If our approach is not what the community want, can I switch back >> to my previous solution? I can reduce the duplication of our >> localized it66121 driver to a minimal, rewrite it until it meets >> the community's requirement. I know our device looks weird and >> our approach is not elegant. But at the very least, we could not >> mess the community's design up by localize. Otherwise, I don't know >> what is the better approach to solve such a problem. >> >> Can I switch back or any other ideas? > I keep on repeating: create the i2c device from your root device > driver, which parses BIOS data. > This is not my own problems, currently it66121 (but not only) display bridge driver don't works on X86 either. What we are trying to do is to provide a generic, non-platform dependent solution. It is not only relevant to my driver. In fact, this series made no assumption which hardware/display controller will be the user. I have investigated before respin this patch, there are other hardwares which ship the it66121 display bridge. For example, the Fresco Logic FL2000dx USB 3.0 to VGA display adapter[1][2]. Even the windows have a driver. [1] https://github.com/FrescoLogic/FL2000 [2] https://oemdrivers.com/graphics-fresco-logic-fl2000