From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A50D396B9C for ; Mon, 9 Mar 2026 11:14:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773054861; cv=none; b=swAUpD6Puo2BhYhb1VyC1y1WQZFN5riSsl+OVgob8ewEgFX3wcyD3PdxQG7WLzKlofkMV2l/B0UlckLugzH8d/hzq03ffRSTzlMmJ/z2rDCKnWtjej7kZHwsfAg71WHDHnuVrY88F7QHQhVxZllpgu9Ouab9YYIBn4NF4AK14gc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773054861; c=relaxed/simple; bh=GuuVYNrc1TFjU7BPxFDcNqIfIpVLYd7YEp3Uxr43OFA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=N/DgCcFLF2HwWdjFEpr5HsczkDddrsYUOLeNaJJJ3SiPjUlNnJbB6i5IwSawrFRNbEWAPfb02la+8osw/RyOOCOUsumm3BV/sBY6/vZop2iFiO3ZMdsGJamcONMtgDCOyd2+T//kPIjBNE3ZeZXA5d6oN0/dxmUakhv8BF1Y6Oo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Py3GAl+j; arc=none smtp.client-ip=209.85.208.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Py3GAl+j" Received: by mail-lj1-f180.google.com with SMTP id 38308e7fff4ca-38a5584e31fso6707161fa.0 for ; Mon, 09 Mar 2026 04:14:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773054859; x=1773659659; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=B5Bl4X7yI81ScRHLniRdDiy4Lg39CIQtHgwg3me+MHc=; b=Py3GAl+jHJygwOv8yxt/zNzl0xaTa3JXKaAXZoDx2rB040HjYOM8HRx+SDDmBee5oF e1IDHRxiKPnNo7zNfg/LH48ERKXIV4GvGfteH+2EVtfbrgurxhYreR00u5z4XgrFlc8/ DrprndaQ2AQGdsJkafKeMqrqnjdtSxeEV729TAfMXx6iV84u77eDLiCf4Voad9bbwETJ 4v/dhv3B6YcNCke5f0gC8bHBnWW3A2T+o+HhZkxHXzhFg8axcQ91Gdu7UBs0JzG1KQxo SkXy6cKewdIKwi39ZnvLy3NAScZXlFQf4SiXfjHCzi9IlmBZewYoRG+ADERXqnf7ErR3 NYWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773054859; x=1773659659; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=B5Bl4X7yI81ScRHLniRdDiy4Lg39CIQtHgwg3me+MHc=; b=T9a6Lopv2QgMh6G9ej/l82Arr5pYXB9IObDKQ2qAPglnPWZrffymjUG7Tbx+rf71ce IBq+njTUxASArc5b/C+etF6mPEkbgIOkNog/GuJYemYKQxwvSeO9g0OVb/B0oaBFDuGh qcXuF55m1cq23IhDCku/CUeaE+Z5hN63qzKk1T275bGutuUUQprtyUOjYZdgxmo8BwJq BpQgdXIIxDzBsG++D3ZQeqBTTuzXw97FBKFHJLyjWc+bfXRB1cr2xNW88BOzM05ZCE1F M7F9yh6/WxwQwDU8rXU95lUJt5vwe2cp+r8sy8atdrEAelk8R1515RPPQhHC//1WC+T9 vwBA== X-Forwarded-Encrypted: i=1; AJvYcCXqW3Ol74HRZ7e50zJzT3NSCVOUnrB4qH1U/FwCjkYJ1wMcmfEEyMRJkmR0yr8w1H5HgwUdWm7F/EQpiyQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yza9E+4WeppCukQ9/g1Ax5UHobll2BQGutpbUPFxfUh+GJBolON u/3E2TaosORop08pKrzwxG6Oag82AF1+SDtQ+Ji8FJG90b5H5UIztVOEhvmiPKzF X-Gm-Gg: ATEYQzxwKOTgjl+7pWCql9mCfJoGZa9vn3dZve65F+sBbDX5NFNUMtfahENoE94hWK8 /Ziohaz2BmcNF6oFCNpc01PJs61Z2qN2RPQiFaxtclN/AMmtBeaX5kK57mchL+n1Z8xMGWgKpab /YPZIkH4sHeQXXZEr0rQ1OVu783Zbhy0tE8LbEgH+VbMlHKE51PnRw5AT5UZfpglezd2Qu9vNkP Z74bDVX+uWwqN1nc8ZbiE/004uExJncQFIIh/iAf03GD6hlq0IUpXhgYi+6L/jBOQpZx7bAYLuR priKNynauI4oK2tTFHyU23AR3Jxy3jayiqpj67E+H6SmP2IaMfzXNMBt9RIK5X4VCMNNCVFljaV 69aNlM0mR5Ujsri+gQqLUqSlesAAvIL01FL7FE1IwhUWJ2whA1klTY8oXXux5JEv4TpuPwFrMWH CCZANmYc9fXVffXRbE/sPJrNJmJJ3puA7E4fP764S1ffPJM+c7N0eIY31tZut1 X-Received: by 2002:a05:651c:41dc:b0:38a:29ea:ee48 with SMTP id 38308e7fff4ca-38a40e6c046mr29974411fa.18.1773054858535; Mon, 09 Mar 2026 04:14:18 -0700 (PDT) Received: from gmail.com (83-233-6-197.cust.bredband2.com. [83.233.6.197]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38a4203ea59sm15213891fa.33.2026.03.09.04.14.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 04:14:17 -0700 (PDT) Date: Mon, 9 Mar 2026 12:14:15 +0100 From: Marcus Folkesson To: Andy Shevchenko Cc: Wolfram Sang , Peter Rosin , Michael Hennerich , Bartosz Golaszewski , Andi Shyti , Bartosz Golaszewski , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v7 3/5] i2c: davinci: calculate bus freq from Hz instead of kHz Message-ID: References: <20260223-i2c-mux-v7-0-ec75b214718a@gmail.com> <20260223-i2c-mux-v7-3-ec75b214718a@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="mJq/Dl0uaZftLsjw" Content-Disposition: inline In-Reply-To: --mJq/Dl0uaZftLsjw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Andy, On Mon, Feb 23, 2026 at 04:59:49PM +0200, Andy Shevchenko wrote: > On Mon, Feb 23, 2026 at 03:33:52PM +0100, Marcus Folkesson wrote: > > The bus frequency is unnecessarily converted between Hz and kHz in > > several places. > > This is probably an old legacy from the old times (pre-devicetrees) > > when the davinci_i2c_platform_data took the bus_freq in kHz. > >=20 > > Stick to Hz. >=20 > ... >=20 > > - clk =3D ((input_clock / (psc + 1)) / (dev->bus_freq * 1000)); > > + clk =3D ((input_clock / (psc + 1)) / (dev->bus_freq_hz)); >=20 > Two pairs too many parentheses! >=20 > clk =3D (input_clock / (psc + 1)) / dev->bus_freq_hz; >=20 > ... >=20 > > + dev_dbg(dev->dev, "bus_freq_hz =3D %dHz\n", dev->bus_freq_hz); >=20 > %u ? Thank you for your comments, both this and the other. This driver has a a few other style & formatting issues, would you prefer to fix those in a separate patch in this patchset or in a following one? >=20 > --=20 > With Best Regards, > Andy Shevchenko >=20 >=20 Thanks, Marcus Folkesson --mJq/Dl0uaZftLsjw Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEBVGi6LZstU1kwSxliIBOb1ldUjIFAmmuq4MACgkQiIBOb1ld UjLTwRAArYUfraX/TF6LW2865GGn5YoXBr+d3Bibi69zxz4WYBQsXuAIjRfA2yl/ yed43OaeOBalpxCnHrdbbEEnA31IVB1dm9IO1PLT855x5EwCc+JXv+NAQGTt6tFC PPxPZiajK7/odFHYxUA3jEDzlWwdPv9Km9Pa7QkK/Gri4uxLt+VKq94qPJiAKVIk Tx/1ffT31ymNAbynHH7xd9wIlo+8frHKdrKI0hVLXq8/s+UDJxZMsO9TcO/KKnhH a38tYWwNq3Mj7sHi0cmK1axsOKCMtPBf4feh/mxRIxQ++45gBg3MvXQ8vHihVFUE ntLiJG8QVJyL/h7cxTEDCefP5xLFR0hc+vrtYQxrhN5NZearOdvjAIuO0UDRNNw3 YW748qAtEWw17MBZDz4bEAoY/slfoTWPyov2IOhkQAiuaqKRLdaDyav76EtrvG7M 4glgspLbv8NtQzJq3zfvuYqwJughPVx4FRf2+52u+6JxRwEzQnN6nhe/DQEWtFb0 V/1bbVhaHd7raU2+liFFoJpqfmlDyVc9xYJ22EiD3txBJzO4dv3owV90DF5J1wli ZSR91NN0pQ6oMw5G67cg2u5RKukk1vvI8vs0e+3yoh74QqImHZV5SNcHZWNmmfdC nDc0eShyJUTPn/qNE7BjGH0858/P2uwhSH1r6E0uIgHbll8l2Fg= =mhhV -----END PGP SIGNATURE----- --mJq/Dl0uaZftLsjw--