From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 076F23BED55 for ; Mon, 9 Mar 2026 14:37:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773067035; cv=none; b=W504ONW7sfycWZIAnwfONyeMXtgr2/Yjng4w2iPRIK06l+RS9eLuld/oQT2Qi9DHewXbGW68wzPMjlOdE6jk9ZimzHzrrrj+qHX5Rh8PJVCYHToirK/tCs6uJqgbeSB3jDqoD04TZQ+pxNjvdZbTssbOPEQCMSlLg/zkNhW12jg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773067035; c=relaxed/simple; bh=9wFHCio89LaMW7wPY7AbeCn2g20iYeKS9H6nhdbkUFA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kXi2rc2y6y0i7fhZW3CNdE/ccutmTVZwXUAoWYAEQXlGxveMUpfwhtye11oIx+MGs0uA1IFaI2C1ZWlvODnpPwuX71gJQj0mW1yvblnf3gqqVVW96EtuVN8iUAXPPxX5VVlApHWv1hosciQbyhueRFb87C/baFTmDw/Esp0luVk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=rK0FGgZr; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="rK0FGgZr" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-3590042fa8eso7344225a91.1 for ; Mon, 09 Mar 2026 07:37:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773067033; x=1773671833; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=RGC50SoNQ/IL+9dTh5yK8xHvRueXeBTNyhrhCxqJ7wI=; b=rK0FGgZrloX0aFougthPY5DNGrwdZp1eCR818R3EntKElY7q6CaFmILqn383R369bS Pc4Shy3HctIOa98oLymGd+7cH5byA4ieKuY5JLz6euwzvtTbIVIN2f+eDGjUi5FGi8C7 s98JoJ4NCIDYpecXffUOxTAp82MFZFEUAdXnZgBB+Zyg25573mvSxriYnkcHlNtDj9Bs k8/InPIslcIulhqdAEH71kxcDknmnq6+2JU7MJGQGQ32dS3l55yhdb4HMAXFmFHiDb+c 774PUzF0Nz4WKm296sMJHMpTniIUuE/gU6A43dY57U+4dPf4V+yoJvPY02vDNw33i/Nn Srwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773067033; x=1773671833; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RGC50SoNQ/IL+9dTh5yK8xHvRueXeBTNyhrhCxqJ7wI=; b=fUa/W18UEqUVj3ECqVaAZO9/oyOgwL1XZLNho66r7PVwxGtVZJ0uiWvhCl2OlRoL/G yNPXfLUETu6lkwTO6kIpjj1+LuU9zSgbdsmOQGDrr4vDgpIGd/l7ebfA8UB9+EScbWaB 1+jvZjZK+zyEE9uKkjnxTilc6mrVS5Yg7iTNxLWUcfgE5IVOjuDWr8Q69EEF9BKLt7vZ +UoMpdxm04d9GWn1mqWb/8LwBJz4dEoKpk/nEhVKthLn2lmSl2BG2YEapqULzSfFEjTc WSaMH9KVXhAjZ2mZ3t+Ts8vtb6+7lkDor4xZ3KAIUPmj69uVnwwPCSPa1pOnuzGv0Gvg 7KSA== X-Forwarded-Encrypted: i=1; AJvYcCVyFepLXUvJruH3D8F/dL9RXVAL/IBPRr/KmW/JIThQZBXXZim1r3ba5gIgfnjzu6XpwUrXPlhD0PQEwcE=@vger.kernel.org X-Gm-Message-State: AOJu0YyafbUxf2SIVIahVF7AWNL3JoF0bQDhFZrHev19zH5TSxrpuWF4 jSr365iNCrJP0VvlCyrhaPO/DnLyicdDEnmio4N8ojPKVC9ydQiY7+iUcmFM87Wly0k= X-Gm-Gg: ATEYQzxszRCClKCfQxjdkOAVsKH+gqPd4pDa5wUddX+6KpQtmoqNR61bw4Y30qpktgz n9+k5CyWTFfbHlnEBq9F5Ls0ugJ4SP/g7iBVv4ZSE2rTab7OmJFhS8FBDius6jHyGXpzTx/1J74 p/0LOVmutNppYUal+wCC4EX34O5TJ0tY75pRY+HQfObcga1SzJaL6gCnB0FOVXOflgTWA7Dv/8N sYQGbEC3ap8V1X+PnEPQbBlnx2hY9+ac5Oxz4asDHBCDGGAoUbNb3gDgp+FgWzndnRiW6u1lcqm 2MEHlHfMgWsRoxYs/pi7zHtSFpdWqVTSa0HklQgDYLuunAsiqhLJIo7TM2qSmh6PGo6dZ4Mg+e2 JOVyz56oIe9w1H8phyIS4Ey94cw6CWL7zHN3lLCLp0F3dWd2qJwPzV2Bd4sYfXhJxKVu7o9p1xB fwQ4JnH1oopQbW4AapMZetf6gaLjY= X-Received: by 2002:a17:903:4405:b0:2ae:4dce:7e92 with SMTP id d9443c01a7336-2ae82421b26mr106299285ad.14.1773067033127; Mon, 09 Mar 2026 07:37:13 -0700 (PDT) Received: from p14s ([2604:3d09:148c:c800:9504:de97:a114:6f18]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ae840b2e9dsm157222545ad.85.2026.03.09.07.37.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 07:37:12 -0700 (PDT) Date: Mon, 9 Mar 2026 08:37:10 -0600 From: Mathieu Poirier To: Jori Koolstra Cc: gregkh@linuxfoundation.org, Bjorn Andersson , "open list:REMOTE PROCESSOR MESSAGING (RPMSG) SUBSYSTEM" , open list Subject: Re: [PATCH] drivers: rpmsg: class_destroy() is deprecated Message-ID: References: <20260308140850.1138376-1-jkoolstra@xs4all.nl> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260308140850.1138376-1-jkoolstra@xs4all.nl> On Sun, Mar 08, 2026 at 03:08:49PM +0100, Jori Koolstra wrote: > The class_destroy() function documents that: > > Note, the pointer to be destroyed must have been created with a call > to class_create(). > > However, class_create() is deprecated. rpmsg already uses > class_register() but the class_destroy() calls should also be replaced > with class_unregister(). > > Link: https://lore.kernel.org/all/2023040244-duffel-pushpin-f738@gregkh/ > Signed-off-by: Jori Koolstra > --- > drivers/rpmsg/rpmsg_core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Applied - thanks, Mathieu > diff --git a/drivers/rpmsg/rpmsg_core.c b/drivers/rpmsg/rpmsg_core.c > index 96964745065b..948541656950 100644 > --- a/drivers/rpmsg/rpmsg_core.c > +++ b/drivers/rpmsg/rpmsg_core.c > @@ -650,7 +650,7 @@ static int __init rpmsg_init(void) > ret = bus_register(&rpmsg_bus); > if (ret) { > pr_err("failed to register rpmsg bus: %d\n", ret); > - class_destroy(&rpmsg_class); > + class_unregister(&rpmsg_class); > } > return ret; > } > @@ -659,7 +659,7 @@ postcore_initcall(rpmsg_init); > static void __exit rpmsg_fini(void) > { > bus_unregister(&rpmsg_bus); > - class_destroy(&rpmsg_class); > + class_unregister(&rpmsg_class); > } > module_exit(rpmsg_fini); > > > base-commit: d466c332e106fe666d1e2f5a24d08e308bebbfa1 > -- > 2.53.0 >