From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C82733D668A for ; Mon, 9 Mar 2026 15:09:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773068997; cv=none; b=c2z1c1y9eZK24WFNziWH9eJF3nV1EbT4lb7IaxVMCzUzobMelE+HY0pxQ7zOEJcK0RCKluTbG+axwYLTtlrOr5tG4nLNPVjzoA7A+V8DyOT3oi4LWKlH6jgNuJzNiX1ybgi5IJoNOQJ7mZcufbupx9uWffx6zDSsfloA6W+aW9I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773068997; c=relaxed/simple; bh=viVfYZ8OKZXVEa/iVdY4DgeANWbwKgm6k61jxlrmoK0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Lg83XDYWZUXBcXRwUnXYMMznC8BxCNPLMorMoG0jpkN3CYFc+E7/k32yYEVRvY6taPQOMdCByvx+BFs1JxmWTYOBkFJGr3BV0i+v0WXJrHt8Y2pBesOuoLeHG6hDyYaUX07Hqjo0o4uVGufqgS/E9lPnbjLG6kC9dyV4Yenaqew= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=b4L3zOto; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=aE1NTwsf; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="b4L3zOto"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="aE1NTwsf" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773068996; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ugkBZJbjXTewXquJACdQmpk7FShKGPugDg36WCZMqGU=; b=b4L3zOto5hjwEn8+Pf7Z4BDgt4YZ5hZZLl9KXPUUinKAdWnv7l8ctR9i1gznFheSsfx2J8 oSN2P3V82pD8BV3eGx1H4k3iMmt1UYm4qdLav6MMSzLT1bxQIGWp4S3kCLBghjElla/cSq qj96K6z/bZDEvV9VtfqR48wa0yiTVHg= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-391-SfXMhZOpNz-dA3cKgBL9yw-1; Mon, 09 Mar 2026 11:09:54 -0400 X-MC-Unique: SfXMhZOpNz-dA3cKgBL9yw-1 X-Mimecast-MFC-AGG-ID: SfXMhZOpNz-dA3cKgBL9yw_1773068994 Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-50921f7da6dso3458981cf.0 for ; Mon, 09 Mar 2026 08:09:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1773068994; x=1773673794; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=ugkBZJbjXTewXquJACdQmpk7FShKGPugDg36WCZMqGU=; b=aE1NTwsfHld5fhtGCAN9iQKYbAbBpfY1oIm17vw3lVXynCygwiP0Z4QOWpIPlJ6Jr7 gwrRtxF8BJTm52BKRYstbWk9aHy2y7yhw95LLYdRvqdzW4KxYW09TtFGkvP/lZPNIByZ b07feaoMBiYh5wub3QhrQ5yc1h34xQxcqK5R9bFVRzJUL6cEBQELvNTyy6jmzADQWXOO 5s+pG3DQXyGIRcBz9RdAsxanSYBjn6INYNOScNvkMNoIWrHAHsKQwaXU0H2I54umca5E /w5R1AjOZGM6yaq/ZLbVBY7HbNly9xXzA6argnEx0o1Aj5Urdj9HsawyxPt1qQ3y//rj OwiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773068994; x=1773673794; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ugkBZJbjXTewXquJACdQmpk7FShKGPugDg36WCZMqGU=; b=vsEiB5anS2wt8n7dD7Db55oXmgMDt/TWltv3FbVT+4/YMR+ZLq9Suefiv7B7b6h/zC dX5wHPXckNCt5xP3NsAZ0DPvP0rvyg0zD23HdEuYscE8ce0RMncWG2n1bU804p7PR22Y LO1++k56IdkXltgLzEl1IN60tViaqU2ozbcncZUJRc4XUYC9ethbs9SyIV39HQW3O0FS 8YeRdq68NjTCfYwSPxTgZ9aXivzqIVjNmToxttKB6wCfBNMGzfMW+aA9HiIXVkjF9Z6N N8Exd5eU5f6Wf6v5/iMbJWoXMHc9Lr6QeQAlMDB6ErCC2x4yKulmAI/FClWalsamTu8E s/nA== X-Forwarded-Encrypted: i=1; AJvYcCXBKh226wU7tcNbiGgMFsht2TwV9x13ShtXGiZx5NuRbmd3Dn+43XrvlpOsUrZWE8FftU9Eh4ZqOjfnsfA=@vger.kernel.org X-Gm-Message-State: AOJu0Yyg6U5y5eNyx016myTaZesIqXtO2TuGAESiL0EIy+VlYKAWycwL nabBJjVNT4ausXx/gzctblTdL3lVwqhoWrzaEQ45dh6ISmSKVbgh4WSgoswKHZPAXyoupoen+Vy tRNm+jWMeCGr9nLrq7B1wRRkz5WkLkJTukgcGAZuVOf2NCRSH8GhkULmCeBemGiyYvw== X-Gm-Gg: ATEYQzyqMqMZzib03kjeL+EBoUlY9f0infVCJ02lL+WVUDzyugDdPV9b/IShXnlC5Wk HWWZcesSTcwo33Pu88usBkMcELK0YiNKVInu0iUCcRV7VKkD4OorkpCuSrHK1UaqOSX+4mc+3vH Mc6AYxuo8z1RvRnHGlcXzJbqHpuIEouiZhjUwmjJpD0eQz2nwowHsZp6P5m3l0/KBOhCQ8I43eY ydEI8FtWElzwj6RQsT/d3xITwOeF7ph2lZvVfyXOtyTfYwaFap2ib8SuAIm2WRgHvdrcqv1jl+R mhtPb66v+hTpCQG7YDDGo8J0QKT+M7ye1huMr7v0PSbTx3IB8SOLMf6GcXrDsR9f17sOOBZU+8v du5BUv2hwiBTyxvtnfssWfpXM2VsF5V8weWr5vwEwdaOD4b0OaWzd7App X-Received: by 2002:ac8:5ad3:0:b0:509:116c:8e05 with SMTP id d75a77b69052e-509116c97fbmr76653971cf.43.1773068994219; Mon, 09 Mar 2026 08:09:54 -0700 (PDT) X-Received: by 2002:ac8:5ad3:0:b0:509:116c:8e05 with SMTP id d75a77b69052e-509116c97fbmr76653381cf.43.1773068993814; Mon, 09 Mar 2026 08:09:53 -0700 (PDT) Received: from redhat.com (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-50907d98162sm44069531cf.25.2026.03.09.08.09.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 08:09:53 -0700 (PDT) Date: Mon, 9 Mar 2026 11:09:51 -0400 From: Brian Masney To: Geert Uytterhoeven Cc: Michael Turquette , Stephen Boyd , Khuong Dinh , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: xgene: Fix mapping leak in xgene_pllclk_init() Message-ID: References: <0d175826e203f2c2fa7060d57763286ec3fe2f43.1772705227.git.geert+renesas@glider.be> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0d175826e203f2c2fa7060d57763286ec3fe2f43.1772705227.git.geert+renesas@glider.be> User-Agent: Mutt/2.2.14 (2025-02-20) On Thu, Mar 05, 2026 at 11:11:16AM +0100, Geert Uytterhoeven wrote: > If xgene_register_clk_pll() fails, the mapped register block is never > unmapped. > > Fixes: 308964caeebc45eb ("clk: Add APM X-Gene SoC clock driver") > Signed-off-by: Geert Uytterhoeven Reviewed-by: Brian Masney