From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87B993939B5 for ; Mon, 9 Mar 2026 15:13:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773069190; cv=none; b=enFrpcK9P06eofp+y4KKkgPlX1Q9i4C2HevR6rnka0/gEHFB4jua64eBVRd7b/sWKFNuHcyPncGt/E6UvqvWirIhS2jBam7oy1jReMXwOq60ZeWNKM7XiFwDlfRFfaN5sPmlZdm7crm/z4WNjFWK3kHSXHR3UdAvuNocwvmtMWo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773069190; c=relaxed/simple; bh=aP1l5mGckZi8uPiNMHIwqyekMx9AdADqZ5kasaUQLQ4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XJWIdVLfG6Bl/CHtYcZCaz9YspU6zmFLasqo4ULrXQy7FDfnxk9q5KFAYIiZFxpDUMHuG/w1zq7JPtP7twsncCsd8AuCCujOpJcn/XV51IU2U/l7qXlGw+AJ2uDMO/zhHgNV5WOhGpLzTkSwFdLAAFs26A04Y4+KbgmuqQPj1bg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=bhaQD/Zp; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=AyIofFFO; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="bhaQD/Zp"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="AyIofFFO" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773069188; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pj7TRP/LukT6gDbE70HzP4GEHwGpkwj6GBHStbfv6GI=; b=bhaQD/ZpP6RwBaNRyJqQ7ujQsPA9A+Volcz4w/wMy66BI3B5fQxMYmtiXxggpfN9fZpA1o j0fMjPgzZxxqn86sd2TvaALZDcrBq7i0svDJGgwFcoNn007XiMC0tqi0Df4TACBSzc+zCM PhI4PfNmSRyiP3wCfjZTBTOHo7J8aEs= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-493-hWfiVp6nNJClIeGDbjUQuQ-1; Mon, 09 Mar 2026 11:13:06 -0400 X-MC-Unique: hWfiVp6nNJClIeGDbjUQuQ-1 X-Mimecast-MFC-AGG-ID: hWfiVp6nNJClIeGDbjUQuQ_1773069186 Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8cd84943c76so779604985a.0 for ; Mon, 09 Mar 2026 08:13:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1773069186; x=1773673986; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=pj7TRP/LukT6gDbE70HzP4GEHwGpkwj6GBHStbfv6GI=; b=AyIofFFOWUjwwDkalBzbnMGqTMoQ5v7wtorPqSLJyH6M57BPwdoiL2+OrLxBeu84w9 5YfzVchE3Lx3FarScyoujRpnps5L0KAvOl1ICpfmweYNhxbkw4XWPzEI5fl2sBl1nAMU tFcvW+5DlTxfRjrCgwZjlMi3Wb5Nh7QZL+SYk8VqqOBhC3/HI17dIT1W1dps+4HBsiZP QNZWGaIE9VHVVmS+CHAgzwBgqzg/ZLchIa8HBCq+SypmlyaA/mJG8ISlzBTl6tlsKkfp L2aDBNd3VaqGYEBaKYrO9l5zxMUlFhMD6dly6ZOUDgVS8lKmtgSN3I9FZ75b3mNfFqn6 W1ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773069186; x=1773673986; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=pj7TRP/LukT6gDbE70HzP4GEHwGpkwj6GBHStbfv6GI=; b=rL7Ccbi6hufkz3RoKUtvhmhcD/het9pNoGCr1vlxVLx5/ZImrTd+obi0OVfXw9Ryvy XOdB/gQynwmbOwQbi8FPnH9yz+6o7tJluptWHe/Pit5KgyyZLW+IWiOZYlgULTJ1niJ6 iw6cWtiMANlDohd5E5M6bnGe4KCWeQNak5RkkPMv3O1vtaeYtgSdZJY6CpAbQPVMYl4O 1ZxnxsHYLujuk0/8rek/eazjuSPgk4Ea1LSnJ0gmBLVtmOV5Qo3nEV3douLU7HzOrvMv 6j8IuOp6nEfoUGkwjjH9+Ps6DPuMfnjQJas9dGrhdsBV+41sWkWAFTVvbHpEYyRFPD2b sHww== X-Forwarded-Encrypted: i=1; AJvYcCWDUimQQEuWE5Wk/BP45ieXRvImSwlLQ/by5F6qeGAwq6GMeefeiL3YOu35pPM9HoAJJtJ4s3P8mXfft3s=@vger.kernel.org X-Gm-Message-State: AOJu0YwnIfbDs8qvpexBhQsW3m4TNvzlawVLYEOg1J2PAJ1PRRqCC/Si EEYPCvm24f6eyUE0jMGZVDoxbckG4dJB3NgyMXco62C3BsqXalkIDiyW1h7VX3JPxSOS+RptwIp 5PaHuEeefWl9Gj+MhLjO14AO6YiosaNZxO3D0e3VKTzxaRbUmwk79z4EXaYv0/ZtvNg== X-Gm-Gg: ATEYQzzMGVRKuDaVat+8B9wqs4KhNbbJBo2kKu2ZPXe3J0M5S4cQgtQ1Oqb1O7MYmK/ OA6m4psq8nNUXJBzvq0egAxp1MsWZsG660vPiELcY5749QAPnfZcBY77jEstv3M15e4fLFZPlk5 iB1zANdLPxHDVA1nP3V0jfMPWgMsE1PdmDTzjbmhmKkgRGZhRuOQr7NR6BI0NEXgDR0uUFoTaXy UcJ6l4kQKQ4JMUrCxuqZ22MSLPhwoZDDXTlxyERuNDEmUXcdoiKOFI6UTV/wimyt8dbiIXhl8Zr 16g/UqTnc1F0e+d9Mg4IcGXSF+709xHDtDbMawWxAvTS2K2gtwvQPB7WOSXL7KOa9e9b4DKiKnB ygSDAbvgPHw+0wpQeMR3wsVNe0xiMbN/27axEeqP1EOftNZTbVnGjw6Y3 X-Received: by 2002:a05:620a:45ac:b0:8cd:8ee1:2ee4 with SMTP id af79cd13be357-8cd8ee1374fmr228104685a.23.1773069185902; Mon, 09 Mar 2026 08:13:05 -0700 (PDT) X-Received: by 2002:a05:620a:45ac:b0:8cd:8ee1:2ee4 with SMTP id af79cd13be357-8cd8ee1374fmr228100385a.23.1773069185437; Mon, 09 Mar 2026 08:13:05 -0700 (PDT) Received: from redhat.com (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8cd6f566fd5sm700212985a.43.2026.03.09.08.13.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 08:13:04 -0700 (PDT) Date: Mon, 9 Mar 2026 11:13:00 -0400 From: Brian Masney To: Geert Uytterhoeven Cc: Michael Turquette , Stephen Boyd , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: Simplify clk_is_match() Message-ID: References: <703be6fe95cad2e738c712877fcdaa63a7809802.1772705499.git.geert+renesas@glider.be> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <703be6fe95cad2e738c712877fcdaa63a7809802.1772705499.git.geert+renesas@glider.be> User-Agent: Mutt/2.2.14 (2025-02-20) On Thu, Mar 05, 2026 at 11:12:33AM +0100, Geert Uytterhoeven wrote: > Linux style is to handle early-on failure. Inverting the first > condition lets us simplify the second, and improves readability. > > Signed-off-by: Geert Uytterhoeven Reviewed-by: Brian Masney Stephen: There are 8 places in clk_test.c where clk_is_match() is called, so I feel we should be good testing coverage wise.