From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF94F3ED10E for ; Mon, 9 Mar 2026 22:05:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773093918; cv=none; b=eWS0y6lvHqNpw4OypC6V6OV8ybVFRWJTK1IyZhGC8QEnScvB99ag3Pw7zXLQeN/l+F3/l4O5qQxttXREbACSpNR9faC0YTtuLJZfd8YfHhrR01xFFl/hnpEVshQMxZkT4Yz0GCCDWhZuzjTKgNkctRrIo58DEGeT0rDLhF4ENJM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773093918; c=relaxed/simple; bh=PjWUePiPqWJI6X/GePnLQ5j02XSnOFq4ejtuT0XNOaw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=R+Ec/9vghBNxU9ZMo3cRrHEwNdSrOP/9lAsH5b4zRVFPKaWdAupi7/pNkKT0VJ59PHdESw/L9eeYpG0UXo5HO6HNeG4/jG/24BTUWa/9QJV8BgbPJZPw44s7X1EnF2jC725VZUc57Uux10+npJ6hADhN/FTdfKmcKnx9ZF9SwRc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=PC2nnBwh; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="PC2nnBwh" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-48540355459so9168925e9.3 for ; Mon, 09 Mar 2026 15:05:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773093915; x=1773698715; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=sh1/MPGVOz0ssapVsSFxczXDSSRPJy6NxkgRJpIQR1c=; b=PC2nnBwhMPMjY1shgY8ZPla9VRjBwP3KPznYwylH2SqgQfikCSS6EZ7npqzBbgZfD9 VPGHovHpfXMbJcsHK5X5Ewsf2gAw6uf2XACyIqD/q/cM7A5QhYERnLkZP/X/s2MY7GEc R91oa8VVfcdfGBtfbS1e+Msjr3tjNfz1HGc7ozVuKGYrLKnx6wubXZbqCoo99ux15mNB of0/CTfYMM+bsq4mMltVWfg50O3qi2E3RYyd9lStvm1CTj/kCOYE85nW346PliU0PB4c dfB2PrVSPuAN4GTDNicFURkG4TIlyzWvXfFtLtjmdxBP+utlu80Jo6h+kncNIsjaQPVk 6fsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773093915; x=1773698715; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sh1/MPGVOz0ssapVsSFxczXDSSRPJy6NxkgRJpIQR1c=; b=kLsnDbviGukq0YZXqkS5sz7UN8y/GwumB6qQR9ugIxQapGXSFYDYGfo2QGYoaoikE5 Fc93x/hscdy6EcJ3dfZ+zDKxOlN3mUPksiL66Q9nZqssHg6bBduFiJwZCoN7YXaMAvwO 0wBAbAmOWCzKjj7tgO6HZUf5po5ulAz1tPu/pgpr9WUEBMSqHDPa9N1UdGJSg+vUbPCV 8xc16P9nEDfuwdBhZUl6nsT/hOIbIT83uPmY99fmQMkOHO0h9ezIt8dJ0Y73aNechQRY a8Oqq39wJcEA4tc8b9efdukn2z0c3+lW0qwWGj5RoX00Ta00SDptZRDgIADDi3qrAaM4 WQQQ== X-Forwarded-Encrypted: i=1; AJvYcCWFDz05rAeCtexC+jl+tO8YEMZ/fMhRUBfmHAJQ0a6fnTQZftK1cHr88HMVSfU1a/Am4KHTBvfxZi+lJes=@vger.kernel.org X-Gm-Message-State: AOJu0YyRgP6hbtxhVk8BL4pRX5c++ubvEa29QMtboWLLp43ECgsbSLqu 8hDzd2RlJ+JZPr+wDtwEUtZuArIu+y7spWTu2Sv+ff3kI+uwfmVL7hP2JxHwSYMDdvo= X-Gm-Gg: ATEYQzxCiLzN71ulyldNtGRPql8vDICPjC2bocNUUpegP47vtf9G73BJmgnJcZ7No4g aWJClT1V/OYS2W6Dpbb/RhkYjZgpAsFc5bXrIViRFhhldqm1Yo2r1tG4C9DvNPqlc5abxB+Zesu AzY6mpRPwJsrtdPwQEDknU3rt5wvoGnjppDrsYxxPtHpSvgR9HNTnADhe8zY6j2pxnpD9CoMuv/ Sun3LHdWEjMNBQMJ/GbB/2ejrET1pxPrHDpLoPDbjhPnAgErvAO/YmSuv2nSNuhORQm4W7o3/i1 1P8gll+XbdsRrm+C/rIFJ7tC/d6Dj/Xaq45psyfjev3+KI5puRInjsh07CSUqvnvmXco41W+80V 2WawuLlVJS85JNGN5jVwJULcH2Ic5qrP92dsZrU7UHZ+OoK5sGHT/nMRBo8KuEAvDPNGoAOpE4I he/euavDQAzGSv/BPCdQo84AgF+3kX X-Received: by 2002:a05:600c:310f:b0:485:390d:74f1 with SMTP id 5b1f17b1804b1-485390d76ebmr93464035e9.13.1773093914913; Mon, 09 Mar 2026 15:05:14 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48541a6bbcesm23594395e9.3.2026.03.09.15.05.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 15:05:14 -0700 (PDT) Date: Tue, 10 Mar 2026 01:05:11 +0300 From: Dan Carpenter To: Luis Soza Rodriguez Cc: pure.logic@nexus-software.ie, johan@kernel.org, elder@kernel.org, gregkh@linuxfoundation.org, greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Luis Soza Rodriguez Subject: Re: [PATCH] staging: greybus: loopback: use sysfs_emit in sysfs show functions Message-ID: References: <20260309165522.26388-1-contact@sluisr.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260309165522.26388-1-contact@sluisr.com> On Mon, Mar 09, 2026 at 10:55:22AM -0600, Luis Soza Rodriguez wrote: > As per the kernel's documentation, sysfs_emit() is the preferred way > to format strings for sysfs attributes. It handles buffer overruns > safely. Replace sprintf calls with sysfs_emit across all loopback > sysfs show macros. > > Signed-off-by: Luis Soza Rodriguez > --- > drivers/staging/greybus/loopback.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c > index aa9c73cb0..3a502d89d 100644 > --- a/drivers/staging/greybus/loopback.c > +++ b/drivers/staging/greybus/loopback.c > @@ -125,7 +125,7 @@ static ssize_t field##_show(struct device *dev, \ > char *buf) \ > { \ > struct gb_loopback *gb = dev_get_drvdata(dev); \ > - return sprintf(buf, "%u\n", gb->field); \ > + return sysfs_emit(buf, "%u\n", gb->field); \ > } \ > static DEVICE_ATTR_RO(field) > > @@ -137,8 +137,8 @@ static ssize_t name##_##field##_show(struct device *dev, \ > struct gb_loopback *gb = dev_get_drvdata(dev); \ > /* Report 0 for min and max if no transfer succeeded */ \ > if (!gb->requests_completed) \ > - return sprintf(buf, "0\n"); \ > - return sprintf(buf, "%" #type "\n", gb->name.field); \ > + return sysfs_emit(buf, "0\n"); \ > + return sysfs_emit(buf, "%" #type "\n", gb->name.field); \ > } \ > static DEVICE_ATTR_RO(name##_##field) > > @@ -158,7 +158,7 @@ static ssize_t name##_avg_show(struct device *dev, \ > rem = do_div(avg, count); \ > rem *= 1000000; \ > do_div(rem, count); \ > - return sprintf(buf, "%llu.%06u\n", avg, (u32)rem); \ > + return sysfs_emit(buf, "%llu.%06u\n", avg, (u32)rem); \ > } \ > static DEVICE_ATTR_RO(name##_avg) > > @@ -173,7 +173,7 @@ static ssize_t field##_show(struct device *dev, \ > char *buf) \ > { \ > struct gb_loopback *gb = dev_get_drvdata(dev); \ > - return sprintf(buf, "%" #type "\n", gb->field); \ > + return sysfs_emit(buf, "%" #type "\n", gb->field); \ Please, keep the \ characters aligned properly. > } \ > static ssize_t field##_store(struct device *dev, \ > struct device_attribute *attr, \ > @@ -199,7 +199,7 @@ static ssize_t field##_show(struct device *dev, \ > char *buf) \ > { \ > struct gb_loopback *gb = dev_get_drvdata(dev); \ > - return sprintf(buf, "%u\n", gb->field); \ > + return sysfs_emit(buf, "%u\n", gb->field); \ Same. > } \ > static DEVICE_ATTR_RO(field) > > @@ -209,7 +209,7 @@ static ssize_t field##_show(struct device *dev, \ > char *buf) \ > { \ > struct gb_loopback *gb = dev_get_drvdata(dev); \ > - return sprintf(buf, "%" #type "\n", gb->field); \ > + return sysfs_emit(buf, "%" #type "\n", gb->field); \ Same. regards, dan carpenter > } \ > static ssize_t field##_store(struct device *dev, \ > struct device_attribute *attr, \