public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org, driver-core@lists.linux.dev,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Danilo Krummrich <dakr@kernel.org>
Subject: Re: [PATCH v2 3/5] regcache: Move HW readback after cache initialisation
Date: Thu, 26 Feb 2026 15:27:24 +0200	[thread overview]
Message-ID: <aaBKPIsYHnvRSGL0@smile.fi.intel.com> (raw)
In-Reply-To: <ea6308f8-2a70-4b46-8052-b98d6f5ca5c9@sirena.org.uk>

On Thu, Feb 26, 2026 at 12:20:44PM +0000, Mark Brown wrote:
> On Wed, Feb 25, 2026 at 05:15:57PM +0100, Andy Shevchenko wrote:
> > Make sure that cache is initialised before calling any IO
> > using regmap, this makes sure that we won't access NULL or
> > invalid pointers in the cache which hasn't been initialised.
> 
> Either this (I suspect it's this) or the subsequent patch is introducing
> regressions in the ASoC tests on several of my systems in the form:
> 
> # ok 1 get_value.AT91SAMG20EK.13
> # # AT91SAMG20EK.13 Inpwm8731 1-001b: ASoC error (-5): at soc_component_read_no_lock() on wm8731.1-001b for register: [0x00000004]
> ut Mux
> 
>   https://lava.sirena.org.uk/scheduler/job/2498613#L1549
> 
> It's not absolutely everything but it's multiple systems (several with
> Wolfson devices, plus the Pine64 Plus which has an integrated Allwinner
> CODEC).  I didn't check beyond seeing the failures yet.

Thanks!

I also run kunit test cases and it seems like half-failing. I'm about to check
deeper what's the cause. (Obviously it works in my case on real HW, but...)

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2026-02-26 13:27 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-25 16:15 [PATCH v2 0/5] regcache: Avoid accessing non-initialised cache Andy Shevchenko
2026-02-25 16:15 ` [PATCH v2 1/5] regcache: Remove duplicate check in regcache_hw_init() Andy Shevchenko
2026-02-25 16:15 ` [PATCH v2 2/5] regcache: Split regcache_count_cacheable_registers() helper Andy Shevchenko
2026-02-25 16:15 ` [PATCH v2 3/5] regcache: Move HW readback after cache initialisation Andy Shevchenko
2026-02-26 12:20   ` Mark Brown
2026-02-26 13:27     ` Andy Shevchenko [this message]
2026-02-26 13:41       ` Andy Shevchenko
2026-02-26 13:57         ` Mark Brown
2026-02-25 16:15 ` [PATCH v2 4/5] regcache: Define iterator inside for-loop and align their types Andy Shevchenko
2026-02-25 16:15 ` [PATCH v2 5/5] regcache: Amend printf() specifiers when printing registers Andy Shevchenko
2026-02-25 19:15   ` Mark Brown
2026-02-25 19:24     ` Andy Shevchenko
2026-02-25 19:26       ` Andy Shevchenko
2026-02-26 11:10       ` Mark Brown
2026-02-26 11:47 ` (subset) [PATCH v2 0/5] regcache: Avoid accessing non-initialised cache Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aaBKPIsYHnvRSGL0@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=broonie@kernel.org \
    --cc=dakr@kernel.org \
    --cc=driver-core@lists.linux.dev \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox