From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E1663921C2
	for <linux-kernel@vger.kernel.org>; Thu, 26 Feb 2026 21:02:53 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1772139773; cv=none; b=tewQ2yGuisoylPM6JCsCX9gwMs3HvoWKMPh9TsI7ALhofHXKW72KXWnRWlAGgrUr4/WU6B3Vy2mQQHOiBnQiwDRwi2C2B7JGRnqHrY8plhE26pGQKhl5Ei7fDDSlul4KbGxWmlASafhPrWWJvJO6Wiq0idYESOjRQJLWcsg6vnw=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1772139773; c=relaxed/simple;
	bh=MWLJMH0nzhlpF4A4AP+9+udjil156fiY6KfeNtsk5aM=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=ZhpapRvRl2GwZybBzmCaqKysU0slEfFn5aU2kHjJbT0hMc01m0yegR1i9H0Ptv9oa+8MLm7WlOSV7271BhuyH5dtw1zoZ1D65H+s7mxSR782xE5wnB+tE3VavCkfq2alu4Tzi/0K83uNauNUFXBfGnSmC+Ay2JqOMcTwGDrnj6U=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QloXhuXF; arc=none smtp.client-ip=10.30.226.201
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QloXhuXF"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9BEE9C116C6;
	Thu, 26 Feb 2026 21:02:52 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1772139773;
	bh=MWLJMH0nzhlpF4A4AP+9+udjil156fiY6KfeNtsk5aM=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=QloXhuXFVxavvv3in9nXJWwIzP02qf6mgoA58Ob0pP+xm42F8ljAioBwjUxywf2DF
	 VvKddF45nI6l6RS/xPmEQnevZKtUBojXnB2aEuLrK6pGHfx2HmOY+TLblpdjVmKPZv
	 pd3Z4XfAvf79ez9OOrgGNR6crEq8Zga9fl6yKj6nwbjgLrReCT8YmoElQ2MDuKxZl6
	 vK2eMKGfMyIUeadOSRu1LazWf60d4s7YFlbdhBogFCBqifBC4rcINyBMkytLb7qN07
	 2qyEgd1W4AAj27iF0MeyjaJ80/uU6ExlF7ghADNxwqathfPe0NMPK4G2zDMx/fYiql
	 Q5CTbkmfe0O8Q==
Date: Thu, 26 Feb 2026 14:02:50 -0700
From: Keith Busch <kbusch@kernel.org>
To: Caleb Sander Mateos <csander@purestorage.com>
Cc: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
	Sagi Grimberg <sagi@grimberg.me>,
	Chaitanya Kulkarni <kch@nvidia.com>, linux-nvme@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 4/8] nvme: always issue I/O Command Set specific
 Identify Namespace
Message-ID: <aaC0-mfU4Q4im-yW@kbusch-mbp>
References: <20260226190416.297725-1-csander@purestorage.com>
 <20260226190416.297725-5-csander@purestorage.com>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20260226190416.297725-5-csander@purestorage.com>

On Thu, Feb 26, 2026 at 12:04:11PM -0700, Caleb Sander Mateos wrote:
> -	if (ns->ctrl->ctratt & NVME_CTRL_ATTR_ELBAS) {
> -		ret = nvme_identify_ns_nvm(ns->ctrl, info->nsid, &nvm);
> -		if (ret < 0)
> -			goto out;
> -	}
> +	ret = nvme_identify_ns_nvm(ns->ctrl, info->nsid, &nvm);
> +	if (ret < 0)
> +		goto out;

I don't think we can do this identify unconditionally. The controller
has to at least pass nvme_id_cns_ok().