From: Yujie Liu <yujie.liu@intel.com>
To: "Christian König" <christian.koenig@amd.com>
Cc: "Matthew Brost" <matthew.brost@intel.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Kenneth Feng" <kenneth.feng@amd.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Patrik Jakobsson" <patrik.r.jakobsson@gmail.com>,
"Danilo Krummrich" <dakr@kernel.org>,
"Philipp Stanner" <phasta@kernel.org>,
"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Pierre-Eric Pelloux-Prayer" <pierre-eric.pelloux-prayer@amd.com>,
"Srinivasan Shanmugam" <srinivasan.shanmugam@amd.com>,
"Tvrtko Ursulin" <tvrtko.ursulin@igalia.com>,
"Sunil Khatri" <sunil.khatri@amd.com>,
"Lijo Lazar" <lijo.lazar@amd.com>,
"Asad Kamal" <asad.kamal@amd.com>,
"Yang Wang" <kevinyang.wang@amd.com>,
"Hawking Zhang" <Hawking.Zhang@amd.com>,
"Tao Zhou" <tao.zhou1@amd.com>,
"Gangliang Xie" <ganglxie@amd.com>,
"Candice Li" <candice.li@amd.com>,
"YiPeng Chai" <YiPeng.Chai@amd.com>,
"Matthew Auld" <matthew.auld@intel.com>,
"Luben Tuikov" <luben.tuikov@amd.com>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Michał Winiarski" <michal.winiarski@intel.com>,
"Michal Wajdeczko" <michal.wajdeczko@intel.com>,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, intel-xe@lists.freedesktop.org
Subject: Re: [PATCH 1/7] drm/gpusvm: fix kernel-doc warning for drm_gpusvm_pages_valid_unlocked()
Date: Fri, 27 Feb 2026 10:08:10 +0800 [thread overview]
Message-ID: <aaD8is1OE05GuJxL@X299> (raw)
In-Reply-To: <c0323ccf-5c35-4dcb-a409-a1e63d157b19@amd.com>
On Thu, Feb 26, 2026 at 12:39:01PM +0100, Christian König wrote:
> On 2/26/26 06:56, Yujie Liu wrote:
> > [Some people who received this message don't often get email from yujie.liu@intel.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> >
> > On Wed, Feb 25, 2026 at 07:06:25PM -0800, Matthew Brost wrote:
> >> On Thu, Feb 26, 2026 at 11:00:32AM +0800, Yujie Liu wrote:
> >>> Warning: drivers/gpu/drm/drm_gpusvm.c:1351 function parameter 'svm_pages' not described in 'drm_gpusvm_pages_valid_unlocked'
> >>> Warning: drivers/gpu/drm/drm_gpusvm.c:1351 expecting prototype for drm_gpusvm_range_pages_valid_unlocked(). Prototype was for drm_gpusvm_pages_valid_unlocked() instead
> >>>
> >>> Fixes: 6364afd532bc ("drm/gpusvm: refactor core API to use pages struct")
> >>
> >> I fix this one already. Believe it merged yesterday.
> >
> > Thanks. I will drop this patch and respin the series after waiting
> > briefly for possible comments on other patches.
>
> I also strongly suggest to split that patch set up by driver/subsystem and send it out individually. So that we can upstream it through different branches.
>
> When it is send out as one patch set then that usually indicates that in needs to be applied in that order. That is clearly not the case here, but it would be nice to have it separately in my inbox.
Thank you very much for the guidance. I'll keep this in mind and
carefully follow the rules and upstream workflow.
Since patch 1 and 5 have already been fixed, and patch 4, 6, 7 have been
picked up by Alex, I'll respin to send out patch 2 and 3 individually.
Best Regards,
Yujie
next prev parent reply other threads:[~2026-02-27 2:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-26 3:00 [PATCH 0/7] drm: fix some kernel-doc warnings Yujie Liu
2026-02-26 3:00 ` [PATCH 1/7] drm/gpusvm: fix kernel-doc warning for drm_gpusvm_pages_valid_unlocked() Yujie Liu
2026-02-26 3:06 ` Matthew Brost
2026-02-26 5:56 ` Yujie Liu
2026-02-26 11:39 ` Christian König
2026-02-27 2:08 ` Yujie Liu [this message]
2026-02-26 3:00 ` [PATCH 2/7] drm/scheduler: fix kernel-doc warning for drm_sched_job_done() Yujie Liu
2026-02-27 6:47 ` Philipp Stanner
2026-02-27 8:02 ` Yujie Liu
2026-02-26 3:00 ` [PATCH 3/7] drm/gma500: fix kernel-doc warning for framebuffer init/create functions Yujie Liu
2026-02-26 3:00 ` [PATCH 4/7] drm/amdgpu: fix kernel-doc warning for amdgpu_ttm_alloc_mmio_remap_bo() Yujie Liu
2026-02-26 16:52 ` Alex Deucher
2026-02-26 3:00 ` [PATCH 5/7] drm/xe/pf: fix kernel-doc warning for SR-IOV VF restore function Yujie Liu
2026-02-26 11:36 ` Michal Wajdeczko
2026-02-26 3:00 ` [PATCH 6/7] drm/amd/pm: fix kernel-doc warning for smu_msg_v1_send_msg() Yujie Liu
2026-02-26 16:54 ` Alex Deucher
2026-02-26 3:00 ` [PATCH 7/7] drm/amd/ras: fix kernel-doc warning for ras_eeprom_append() Yujie Liu
2026-02-26 16:53 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaD8is1OE05GuJxL@X299 \
--to=yujie.liu@intel.com \
--cc=Hawking.Zhang@amd.com \
--cc=YiPeng.Chai@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=asad.kamal@amd.com \
--cc=candice.li@amd.com \
--cc=christian.koenig@amd.com \
--cc=dakr@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=ganglxie@amd.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=kenneth.feng@amd.com \
--cc=kevinyang.wang@amd.com \
--cc=lijo.lazar@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luben.tuikov@amd.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=matthew.auld@intel.com \
--cc=matthew.brost@intel.com \
--cc=michal.wajdeczko@intel.com \
--cc=michal.winiarski@intel.com \
--cc=mripard@kernel.org \
--cc=patrik.r.jakobsson@gmail.com \
--cc=phasta@kernel.org \
--cc=pierre-eric.pelloux-prayer@amd.com \
--cc=rodrigo.vivi@intel.com \
--cc=simona@ffwll.ch \
--cc=srinivasan.shanmugam@amd.com \
--cc=sunil.khatri@amd.com \
--cc=tao.zhou1@amd.com \
--cc=thomas.hellstrom@linux.intel.com \
--cc=tvrtko.ursulin@igalia.com \
--cc=tzimmermann@suse.de \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox