From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E123C331239 for ; Thu, 26 Feb 2026 23:40:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772149249; cv=none; b=sj1g7aKXmuhLdoFQtsAf2hVwch/CDwQxu34wSqtrGSU+nH7+g56YMMzgqooFps9hqCaQxA+8FLG+3KegwCevRND55+/luqtjxQdSpMc1kGW+zCitD/uwcvyRqDJkPxEpj2jvWVuwGpWSuwp5IUNeW0RaK2CthubZCsUnMKQqNIU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772149249; c=relaxed/simple; bh=773E1Qu3WZaNjUpNYslYsC6fIc6QMX05+z2A/JT5Lmg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=iWJ1gMQm/cqouckCtMdvLllSr/hHFDByowGNwYlavG3wqtEdNtuslVrQYzuj2laxR88Cu9g2DwoNDmQgdhuQ9YgQV8dhYcTI/gU5Fa83kyvDlq0kkV2os8Ir3ZU+OOppiSjKorMqourWl+XusOVuk0St0nzn8r6pKzMbJkNuL2o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=hzfEJy+/; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="hzfEJy+/" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2aae4816912so9563865ad.2 for ; Thu, 26 Feb 2026 15:40:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1772149247; x=1772754047; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=dweZEP9P9syIIaIBNbJewu0YbCAV1KvejPrlkY4pDLk=; b=hzfEJy+/xVgMtXdTO18W8dd4TxjvUCU3ZO16mrYqOOWsNM3Cfj7xMKd7kOOeIqtHyO Bo7rfUDvMguucNMGYkRu0SYWYxm+MXGm5jdnkFayBykV3x/0dvRIMYw8eWrh/6ym+JQU rEZGESpNfJQUH/FKbTsOeOmFQ/XEsY4woCWZiBO5FSetVDJSUEZSkkvqG3JVZn8sWorh sNEumiWGre3q7OVZGoTe1clgaEMhB8jOemrj69eWBC//eGPOtk//SWjUpJVRBrcjheGj j6JSOvbi0iTH/nHPYjXvCtefKb9o7tw/8VOHqXWiZfdHoM0iS7dOZZI/UXh9pXMWiSN1 iZPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772149247; x=1772754047; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dweZEP9P9syIIaIBNbJewu0YbCAV1KvejPrlkY4pDLk=; b=qIPkUQYR5HkP3UpOPC/d1bvGHmuiW2jWP5YKyFgiTpgvyLbyFWq/2O15p07OBNrUl5 d80VWa6HX74bhxuvBk9yoP7hPbUORi7/xStn+8zdn9zOo4VW/Az37NH9FrY/V1xFQHB5 6e969IiGDwETN+A014ubHaMSmkyzxmLiZf+Coi+ov48JB0sZJlIWBTlbB+WTCGIuHfcA F+4Piwd6BPVyXkAdSS4J+n4Xkxq9ANX8rlpikB9QZY/9AE+kGJmmP80vReO7f4n9/f62 CC+Mn35YavAzq0RD53ehJ7HbaQ6IJhqs/7fvH3d3DwpPUl9YzVrc+p8ySUrjig8juPcQ nlQg== X-Forwarded-Encrypted: i=1; AJvYcCXHS+LJYoMu7E0Urr26brUMVFFvTAomUndn593vbPgUqfkbkks+TVaARPdHAm+fNET9xqeq4DzCDs10mPA=@vger.kernel.org X-Gm-Message-State: AOJu0Yw8A8osCLhpPaFMaKCvtFQa7zi8koOEElVmoXGdCH3nmiDIzCoh 08WvSI1n09n1znW0ljNnCZcSwga4IYl0vA49a3+hXEbu5DeK4dqNkF0VIE6Uq7iiAQ== X-Gm-Gg: ATEYQzzQONcFrOjH4qMEqMl8Q/oU+XyeVIhz3fxyM/uIBfINBHXM+rYonx4/yT8DLkN ft+toxSfTzZU3i8sWA1ojGDZK84cGafwgWQSmM0VGXZ3Cz2Lig8YZSi9AcDyBMjSHKpOys2+YqA PdmPw8Mj1aI5nJY08sgQ73k8p9PYJC9+O5kLivGYVomzcB4Yw1ZCfaHfkIPA/E62YaQOTzV1I+W GYgreApF7d4+Rp1Ia4Xfv3FDTVV27ol2PakLaeYAsawazMoVNjpm5JqJufv40XMaXHXic0QSELA ZYgGsO6m9m0fHlulnwF1mEtTJdd9NKMBvdubF2GL50uSKqz17nrmSnAP1wMYbeuzhuL5o3IpvqH Bsmz3VpmrqK7hscMqrVbPY/LDgWSh/TZutfNfVj3fHBVWptpF+5QL+3vye03twzp1LN6zd9Wv8y MEWOLI0kKfhOYpviFHGPgC6NOhjrjqRYY6Vn2tRTSJAa5iWn55CcpdO2XhkiQURA== X-Received: by 2002:a17:903:22c9:b0:2ad:cede:3a18 with SMTP id d9443c01a7336-2ae2e46bd8emr6748745ad.33.1772149246778; Thu, 26 Feb 2026 15:40:46 -0800 (PST) Received: from google.com (239.23.105.34.bc.googleusercontent.com. [34.105.23.239]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2adfb5b257esm36167495ad.4.2026.02.26.15.40.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Feb 2026 15:40:45 -0800 (PST) Date: Thu, 26 Feb 2026 23:40:41 +0000 From: David Matlack To: Alex Williamson Cc: Adithya Jayachandran , Alexander Graf , Alex Mastro , Alistair Popple , Andrew Morton , Ankit Agrawal , Bjorn Helgaas , Chris Li , David Rientjes , Jacob Pan , Jason Gunthorpe , Jason Gunthorpe , Jonathan Corbet , Josh Hilke , Kevin Tian , kexec@lists.infradead.org, kvm@vger.kernel.org, Leon Romanovsky , Leon Romanovsky , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-pci@vger.kernel.org, Lukas Wunner , =?utf-8?Q?Micha=C5=82?= Winiarski , Mike Rapoport , Parav Pandit , Pasha Tatashin , Pranjal Shrivastava , Pratyush Yadav , Raghavendra Rao Ananta , Rodrigo Vivi , Saeed Mahameed , Samiullah Khawaja , Shuah Khan , Thomas =?iso-8859-1?Q?Hellstr=F6m?= , Tomita Moeko , Vipin Sharma , Vivek Kasireddy , William Tu , Yi Liu , Zhu Yanjun Subject: Re: [PATCH v2 06/22] vfio/pci: Retrieve preserved device files after Live Update Message-ID: References: <20260129212510.967611-1-dmatlack@google.com> <20260129212510.967611-7-dmatlack@google.com> <20260226155222.5452a741@shazbot.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260226155222.5452a741@shazbot.org> On 2026-02-26 03:52 PM, Alex Williamson wrote: > On Thu, 29 Jan 2026 21:24:53 +0000 David Matlack wrote: > > diff --git a/drivers/vfio/device_cdev.c b/drivers/vfio/device_cdev.c > > index 8ceca24ac136..935f84a35875 100644 > > --- a/drivers/vfio/device_cdev.c > > +++ b/drivers/vfio/device_cdev.c > > @@ -52,6 +46,19 @@ int vfio_device_fops_cdev_open(struct inode *inode, struct file *filep) > > vfio_device_put_registration(device); > > return ret; > > } > > +EXPORT_SYMBOL_GPL(__vfio_device_fops_cdev_open); > > I really dislike that we're exporting the underscore variant, which > implies it's an internal function that the caller should understand the > constraints, without outlining any constraints. > > I'm not sure what a good alternative is. We can drop fops since this > isn't called from file_operations. Maybe vfio_device_cdev_open_file(). Ack. Due to the bug you pointed out below, I think the changes in this file will look fairly different in the next version. But no matter what I'll avoid exporting a underscore variant without outlining the constraints. > > + /* > > + * Simulate opening the character device using an anonymous inode. The > > + * returned file has the same properties as a cdev file (e.g. operations > > + * are blocked until BIND_IOMMUFD is called). > > + */ > > + file = anon_inode_getfile_fmode("[vfio-device-liveupdate]", > > + &vfio_device_fops, NULL, > > + O_RDWR, FMODE_PREAD | FMODE_PWRITE); > > + if (IS_ERR(file)) { > > + ret = PTR_ERR(file); > > + goto out; > > + } > > + > > + ret = __vfio_device_fops_cdev_open(device, file); > > + if (ret) { > > + fput(file); > > Don't we end up calling vfio_device_fops.release with NULL > file->private_data here with inevitable segfaults? Thanks, Yes indeed. In that case I think we need to call vfio_device_try_get_registration() and vfio_allocate_device_file() before anon_inode_getfile_fmode(). We could play games with file->fops to avoid it calling vfio_device_fops.release here instead, but that feels hacky.