From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 425441DE2C9 for ; Fri, 27 Feb 2026 02:38:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772159923; cv=none; b=Yvt05PwM/pXiRQ/yTQ6Oe6CU164bqcGGfy44nSxoKmTgGFGVab4AUThrAChbKzONtTHyEy7OwM12O9KH9bcFGbRUVih3GCnryrpV6e9nlNA7oR8h/V8+xPT2G1vLr5Ewx1Ja2o9PdgzZRDyp3mSfZKCnat1tVWFsoVE4r+ruNNc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772159923; c=relaxed/simple; bh=vGFd9z/E/ywuuI5wTR3Yy2I97bE0XC0/msZcvxIYU6I=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=U9Q0OkpkatF39VxL67B6rlBwQqUChyHGguE2ZrTahQMdd++kYdHMnxyFdZoWzmzeRGpLd1z/G0W2BnRSj+Y01FqClgD5lZLmhJrSwNktdURlIUIHj+zsFiLeqdSOlP07/Lvge8TDCP876el7EYlcMcLa7uuGnehljNIRtBi1SB0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mM7u/AeM; arc=none smtp.client-ip=209.85.215.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mM7u/AeM" Received: by mail-pg1-f175.google.com with SMTP id 41be03b00d2f7-c6e248aa446so593547a12.1 for ; Thu, 26 Feb 2026 18:38:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772159922; x=1772764722; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=s9Fy5twOQmqd13IJtP3D2OUD99NwYh0uDaBdljqk6Dg=; b=mM7u/AeMUaHhEm42RNpgAi41KQaUPpE9Vyb7pkiRjQUY5QyuOlOw5MWnh8LUu0SpEa rmaW6z/k6wDrasgARwTG1Zzq69MboglPggKXHJFIMGcPt8lfko4Quw+uRgAeCRvGrRmC LUXjjW7AfZtHBkSM2V/fwnKcDzWrT32VqyuV+VzXoJokq1c2aBSz0bgi41ZnSjbtNnb9 Y+g8WmzpnbYQYxu1gxLdXIyTzVv7k8UjAYdq9vg5C+U4Vsbgr+V4iaWUAb2IRd3avz/l xrT2HhsWJsO5EWUYQW9k43t58hVgWcIdxCLtvQ2mJ6QLLEoEMdKTfMIWw0cfqyOC8eZC PHqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772159922; x=1772764722; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=s9Fy5twOQmqd13IJtP3D2OUD99NwYh0uDaBdljqk6Dg=; b=WUMyqCutY2dy+urKuQzeCC5fl3V+kKUozwu7iBzGxxNR5KSToKUomisi3mUzP2edO9 UO7Jgn1CwVx5D7T13+cZD06ojNKh6P66m7OqG++BUKtetetsuippVNdouUPfHtoRVU+e W6k4uuocYbFrYW4YdO5MbL/ryfsYLOFZbxAZv1hUuXLKdU9u9EjDVea9u3tHT8Nl11+0 rSSnCy7ddz2M8hXLWWtajWA1x9UHLCzk2tpNrjlCLYMcLk8D3/jWWCKxHHKf2iUDjKtF RPoI98YFRZhfpySLMoBOcL5hzxMp+O+5D0gxj+paOrTiGGl9gUTok+wPVGkE0uT8PKwC Mphw== X-Forwarded-Encrypted: i=1; AJvYcCX/cTcuPpp3p3iol0Z2602sSJacX0txs87WcU5X6hM5nAUEI9U7xwosH6EM0T1+lOK8w4IKw7BB+ATRhr0=@vger.kernel.org X-Gm-Message-State: AOJu0YykxIzeAErgwO2EfI8gV3kF6xl8iMI/Z1qfxgxFw2O3R2JE857n 6z8yz2LC92Xc+6qDD20DlJt/Fgis7MmE5ZAKHXAiLu+xeSI6mZ7Rmegj X-Gm-Gg: ATEYQzyZ2h13Q9RHaQgrtKtbUEbfKHSY5fAMD+bUaC1/CzGHFwLji6Jvfhc6kMOHOq7 zVwNI8xaVJvWWFhlvgt0doK/2LJvfus+43ESakx4QbkD/KPYTZbUcAThr1bfKXrPygwSJnJGZa8 Df7WWbXv01WBfO7hsMP/Ibt90oEht8ZPlte1uOp+GXo4eZ2NspAakIdHV+Bgl4xi5RKvEfrDy8H KOQ1eHkXbX4EnyyJgcCrW4DlPFGvJDn4CLbA2IEPNIsIM9Qh9Cx7pU8qLKC0Ql9nO0bAP4OaU74 3eA8F549/X5gdylIcbFXHXi4LE9+cao33WroVhxv+nciwgZA7a0yYhah7MEWDY+Xrx/sNCAfMd4 NS+lQjN8OLyoLD7jLZSep7P2CyibVQXHd8C3mRdpyjROZre4KS9kfCDAGGN7lgdUltFo5E+3ARN w5tLvP5fEOMC32DQ== X-Received: by 2002:a17:902:db08:b0:2aa:d672:3be with SMTP id d9443c01a7336-2ae2e4f8590mr8314625ad.52.1772159921649; Thu, 26 Feb 2026 18:38:41 -0800 (PST) Received: from localhost ([27.122.242.71]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2adfb5dbac7sm54736215ad.37.2026.02.26.18.38.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Feb 2026 18:38:41 -0800 (PST) Date: Fri, 27 Feb 2026 11:38:39 +0900 From: Hyunchul Lee To: Ethan Tidmore Cc: linkinjeon@kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] ntfs: Fix possible deadlock Message-ID: References: <20260226160906.7175-1-ethantidmore06@gmail.com> <20260226160906.7175-4-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260226160906.7175-4-ethantidmore06@gmail.com> On Thu, Feb 26, 2026 at 10:09:06AM -0600, Ethan Tidmore wrote: > In the error path for ntfs_attr_map_whole_runlist() the lock is not > released. > > Add release for lock. > > Detected by Smatch: > fs/ntfs/attrib.c:5197 ntfs_non_resident_attr_collapse_range() warn: > inconsistent returns '&ni->runlist.lock'. > > Fixes: 495e90fa33482 ("ntfs: update attrib operations") > Signed-off-by: Ethan Tidmore Looks good to me. Thank for the patch Reviewed-by: Hyunchul Lee > --- > fs/ntfs/attrib.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/fs/ntfs/attrib.c b/fs/ntfs/attrib.c > index 71ad870eceac..2af45df2aab1 100644 > --- a/fs/ntfs/attrib.c > +++ b/fs/ntfs/attrib.c > @@ -5124,8 +5124,10 @@ int ntfs_non_resident_attr_collapse_range(struct ntfs_inode *ni, s64 start_vcn, > > down_write(&ni->runlist.lock); > ret = ntfs_attr_map_whole_runlist(ni); > - if (ret) > + if (ret) { > + up_write(&ni->runlist.lock); > return ret; > + } > > len = min(len, end_vcn - start_vcn); > for (rl = ni->runlist.rl, dst_cnt = 0; rl && rl->length; rl++) > -- > 2.53.0 > -- Thanks, Hyunchul